Fix/Patch OnTarget(cid,creature) fix (return false in lua scripts)

Well as you may know that this is bugged on tfs 0.4 so i looked around a bit in the code and it was clearly obvious it was messed out so here is the fix.



go to combat.cpp:

find
[cpp]
ReturnValue Combat::canTargetCreature[/cpp]

search in this function block for
[cpp]
if(deny)
return RET_NOERROR;[/cpp]
replace with [cpp]
if(deny)
return RET_YOUARENOTTHEOWNER;//just any thing that isn't related[/cpp]


now go to game.cpp:

find [cpp]bool Game:layerSetAttackedCreature[/cpp]

search in this function block for [cpp]
if(ret != RET_NOERROR)
{
player->sendCancelMessage(ret);
player->sendCancelTarget();
player->setAttackedCreature(NULL);
return false;
}[/cpp]

now replace with
[cpp]
if(ret != RET_NOERROR)
{
if(ret != RET_YOUARENOTTHEOWNER)
player->sendCancelMessage(ret);

player->sendCancelTarget();
player->setAttackedCreature(NULL);
return false;
}[/cpp]

but onTarget can crash server?

add example

God fix =)

Scooty: Yes.
Bots..

Why would it crash server!?

didnt I understand, for the that serves this alteration? excuse the innocence

Can you add example scripts lua?

Example:
With that code you cannot target (on battle list/right mouse + attack) monster with name 'Demon'.

Doggy should add this example in main post.
Ty Gesior

Gesior.pl said:

Example:

Lua:

function onTarget(cid, target)
  if isMonster(target) and getCreatureName(target) == 'Demon' then
    return false
  end
  return true
end

With that code you cannot target (on battle list/right mouse + attack) monster with name 'Demon'.

Click to expand...