TFS Update to 10.8x, 10.9x series, adding missing features

I can't push any commits until I am done to Expert PvP, so that, you will have to wait until i release the Expert PvP. (90% done).

Slavi Dodo said:

I can't push any commits until I am done to Expert PvP, so that, you will have to wait until i release the Expert PvP. (90% done).

Click to expand...

@Slavi Dodo u can help me with Store System?

Great news! Expert Pvp is finished, A vedio will be uploaded and viewed in another thread! Stay tuned for that.

Slavi Dodo said:

Great news! Expert Pvp is finished, A vedio will be uploaded and viewed in another thread! Stay tuned for that.

Click to expand...

In file included from /otserv/Krown2/store/src/combat.h:27:0,
from /otserv/Krown2/store/src/game.h:24,
from /otserv/Krown2/store/src/actions.cpp:26:
/otserv/Krown2/store/src/player.h: In member function ‘int16_t Player::getPvpItemId(Item*)’:
/otserv/Krown2/store/src/player.h:1185:3: error: no return statement in function returning non-void [-Werror=return-type]
}
^
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/tfs.dir/src/actions.cpp.o] Error 1
make[1]: *** [CMakeFiles/tfs.dir/all] Error 2
make: *** [all] Error 2

Remove this function, it's unusable.

/otserv/Krown2/store/src/game.cpp: In member function ‘void Game:layerRequestTrade(uint32_t, const Position&, uint8_t, uint32_t, uint16_t)’:
/otserv/Krown2/store/src/game.cpp:2427:83: error: right operand of comma operator has no effect [-Werror=unused-value]
if (!canThrowObjectTo(tradePartner->getPosition(), player->getPosition()), true, 8, 6, tradePartner) {
^
/otserv/Krown2/store/src/game.cpp:2427:86: error: right operand of comma operator has no effect [-Werror=unused-value]
if (!canThrowObjectTo(tradePartner->getPosition(), player->getPosition()), true, 8, 6, tradePartner) {
^
/otserv/Krown2/store/src/game.cpp:2427:89: error: right operand of comma operator has no effect [-Werror=unused-value]
if (!canThrowObjectTo(tradePartner->getPosition(), player->getPosition()), true, 8, 6, tradePartner) {
^
/otserv/Krown2/store/src/game.cpp: In member function ‘void Game:layerAcceptTrade(uint32_t)’:
/otserv/Krown2/store/src/game.cpp:2564:83: error: right operand of comma operator has no effect [-Werror=unused-value]
if (!canThrowObjectTo(tradePartner->getPosition(), player->getPosition()), true, 8, 6, tradePartner) {
^
/otserv/Krown2/store/src/game.cpp:2564:86: error: right operand of comma operator has no effect [-Werror=unused-value]
if (!canThrowObjectTo(tradePartner->getPosition(), player->getPosition()), true, 8, 6, tradePartner) {
^
/otserv/Krown2/store/src/game.cpp:2564:89: error: right operand of comma operator has no effect [-Werror=unused-value]
if (!canThrowObjectTo(tradePartner->getPosition(), player->getPosition()), true, 8, 6, tradePartner) {
^
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/tfs.dir/src/game.cpp.o] Error 1
make[1]: *** [CMakeFiles/tfs.dir/all] Error 2
make: *** [all] Error 2

Well, Errors are fixed.

Test that guys! https://github.com/slavidodo/forgottenserver/tree/Lastdeath

Slavi Dodo said:

Well, Errors are fixed.

Test that guys! https://github.com/slavidodo/forgottenserver/tree/Lastdeath

Click to expand...

Errors on Store:

- Debug on version 10.92
- Transfer Coins (Possible Clone TC)

Bugs are fixed, And about cloning, it was not possible, there is a check on database before committing the purchase.
And gamestore was updated, added examples, added some minor fixed.

@topic
Updated EquipObject.
@Elwyn Look at it, this may help! It's fixing all common issues, as well it add stackable items.

@Slavi Dodo
Hello, thanks for all the work that you make, i have few questions:
1.- This sources, have "cast system" working?

2.- Another thing, global depot and store inbox are finished?,
because you need update main post

3.- I think is missing "reward system" feature,
you go to added this: https://github.com/otland/forgottenserver/pull/1641
or you have your own system?

@Slavi Dodo you can not add Boss Reward System in that its source because it presents an error related to depotId want to add the RewardBoss system?

I will add it in addition to global depot. Thanks!

Good work.

@Slavi Dodo Thanks my friend excelent work!

excelent work about the monster flag, I like it alot!!!
question, the store, works perfectly? transfer coins as well?
also, the store inbox how is the progress?

Have any way to fix the premium issue? When people have premium days when will log it appears free acc in window and when deslog appear 32672 days in the same window... how to fix this?

~Silveralol Everything is working perfectly, StoreInbox not yet.

~ Dervin13 Hmm, i will look at that once finished current tasks.

@topic
Could someone contribute and add new mounts,outfits, misc.....

Slavi Dodo said:

~Silveralol Everything is working perfectly, StoreInbox not yet.

~ Dervin13 Hmm, i will look at that once finished current tasks.

@topic
Could someone contribute and add new mounts,outfits, misc.....

Click to expand...

I found some bugs
- the value of coins not show in the market (I think that is only a line in iomarket.cpp to work it)
- the store don't have type offer PREMIUM or PREMIUMTIME

For first ( i said version without market in implementation).
For second, it's not a bug, it's just an enhancement. I added it to task list.

(Forget to say) It's not just a line in iomarket in cpp, It won't be possible unless we move market to lua via modules.