• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

TFS 0.X Gold tranfser limit

J

jestem pro

That is the question
Joined
Apr 20, 2013
Messages
650
Solutions
14
Reaction score
87
Hello, I have a little problem.

I want to make limit of transfering money.


It's a NPC​

So when I send you money, it checks how much you have.
If your balance is greater or equal 1000 ,it shouldn't send.

The piece of the code:
Lua: 
 elseif talkState[cid] == 12 then
                transfer[cid] = msg          
            if getPlayerBalance(transfer[cid])) <= 1000 then

transfer[cid] is player name(it asks you as the parameter), but function getPlayerBalance returns a number.

So I get the error:

Attempt to compare boolean with number.

How this should be correctly:
Code: 
getPlayerBalance(transfer[cid])
 
Sort by date Sort by votes
I don't remember where i've found this script (probably on tibiaking), but test it please:

Lua: 
local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)
local talkState = {}
local moneyTo = {}
local playerTo = {}

function onCreatureAppear(cid)            npcHandler:onCreatureAppear(cid)        end
function onCreatureDisappear(cid)        npcHandler:onCreatureDisappear(cid)        end
function onCreatureSay(cid, type, msg)        npcHandler:onCreatureSay(cid, type, msg)    end
function onThink()                npcHandler:onThink()                end

local function isValidMoney(money)
    if isNumber(money) == TRUE and money > 0 and money < 999999999 then
        return TRUE
    end
    return FALSE
end

function creatureSayCallback(cid, type, msg)

    if(not npcHandler:isFocused(cid)) then
        return false
    end

    if msgcontains(msg, 'help') or msgcontains(msg, 'offer') then
        selfSay("You can check the {balance} of your bank account, {deposit} money or {withdraw} it. You can also {transfer} money to other characters, provided that they have a vocation.", cid)
        talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Balance ----------------------------
-----------------------------------------------------------------
    elseif msgcontains(msg, 'balance') or msgcontains(msg, 'Balance') then
        selfSay('Your account balance is '..getPlayerBalance(cid)..' gold.', cid)
        talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Help -------------------------------
-----------------------------------------------------------------
    elseif msgcontains(msg, 'basic functions') then
        selfSay('You can check the {balance{ of your bank account, Pdeposit{ money or Pwithdraw{ it. You can also {transfer} money to othercharacters, provided that they have a vocation.', cid)
        talkState[cid] = 0
    elseif msgcontains(msg, 'advanced functions') then
        selfSay('Renting a house has never been this easy. Simply make a bid for an auction. We will check immediately if you haveenough money.', cid)
        talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Deposit ----------------------------
-----------------------------------------------------------------
    elseif msgcontains(msg, 'deposit all') then
        moneyTo[cid] = getPlayerMoney(cid)
        if moneyTo[cid] < 1 then
            selfSay('You don\'t have any money to deposit in you inventory..', cid)
            talkState[cid] = 0
        else
            selfSay('Would you really like to deposit '..moneyTo[cid]..' gold?', cid)
            talkState[cid] = 2
        end
    elseif msgcontains(msg, 'deposit') then
        selfSay("Please tell me how much gold it is you would like to deposit.", cid)
        talkState[cid] = 1
    elseif talkState[cid] == 1 then
        moneyTo[cid] = tonumber(msg)
        if isValidMoney(moneyTo[cid]) == TRUE then
            selfSay('Would you really like to deposit '..moneyTo[cid]..' gold?', cid)
            talkState[cid] = 2
        else
            selfSay('Is isnt valid amount of gold to deposit, the maximum is 999999998 gold coins.', cid)
            talkState[cid] = 0
        end
    elseif talkState[cid] == 2 then
        if msgcontains(msg, 'yes') then
            if doPlayerDepositMoney(cid, moneyTo[cid], 1) ~= TRUE then
                selfSay('You do not have enough gold.', cid)
            else
                selfSay('Alright, we have added the amount of '..moneyTo[cid]..' gold to your balance. You can withdraw your money anytime you want to. Your account balance is ' .. getPlayerBalance(cid) .. '.', cid)
            end
        elseif msgcontains(msg, 'no') then
            selfSay('As you wish. Is there something else I can do for you?', cid)
        end
        talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Withdraw ---------------------------
-----------------------------------------------------------------
    elseif msgcontains(msg, 'withdraw') then
        selfSay("Please tell me how much gold you would like to withdraw.", cid)
        talkState[cid] = 6
    elseif talkState[cid] == 6 then
        moneyTo[cid] = tonumber(msg)
        if isValidMoney(moneyTo[cid]) == TRUE then
            selfSay('Are you sure you wish to withdraw '..moneyTo[cid]..' gold from your bank account?', cid)
            talkState[cid] = 7
        else
            selfSay('Is isnt valid amount of gold to withdraw, the maximum value is 999999998 gold coins.', cid)
            talkState[cid] = 0
        end
    elseif talkState[cid] == 7 then
        if msgcontains(msg, 'yes') then
            if doPlayerWithdrawMoney(cid, moneyTo[cid]) ~= TRUE then
                selfSay('There is not enough gold on your account. Your account balance is '..getPlayerBalance(cid)..'. Please tell me the amount of gold coins you would like to withdraw.', cid)
            else
                selfSay('Here you are, ' .. moneyTo[cid] .. ' gold. Please let me know if there is something else I can do for you.', cid)
                talkState[cid] = 0
            end
        elseif msgcontains(msg, 'no') then
            selfSay('As you wish. Is there something else I can do for you?', cid)
            talkState[cid] = 0
        end
-----------------------------------------------------------------
---------------------------- Transfer ---------------------------
-----------------------------------------------------------------
    elseif msgcontains(msg, 'transfer') then
        selfSay("Please tell me the amount of gold you would like to transfer.", cid)
        talkState[cid] = 11
    elseif talkState[cid] == 11 then
        moneyTo[cid] = tonumber(msg)
        if isValidMoney(moneyTo[cid] == TRUE and getPlayerBalance(cid) <= 1000 then
            selfSay('Who would you like transfer '..moneyTo[cid]..' gold to?', cid)
            talkState[cid] = 12
        else
            selfSay('Is isnt valid amount of gold to transfer.', cid)
            talkState[cid] = 0
        end
    elseif talkState[cid] == 12 then
        playerTo[cid] = msg

        if getCreatureName(cid) == playerTo[cid] then
            selfSay('Ehm, You want transfer money to yourself? Its impossible!', cid)
            talkState[cid] = 0
            return TRUE
        end

        if playerExists(playerTo[cid]) then
            selfSay('So you would like to transfer ' .. moneyTo[cid] .. ' gold to "' .. playerTo[cid] .. '" ?', cid)
            talkState[cid] = 13
        else
            selfSay('Player with name "' .. playerTo[cid] .. '" doesnt exist.', cid)
            talkState[cid] = 0
        end
    elseif talkState[cid] == 13 then
        if msgcontains(msg, 'yes') then
            if getPlayerBalance(cid) < moneyTo[cid] then
                selfSay('You dont have enought money on your bank account.', cid)
                return TRUE
            end

            if doPlayerTransferMoneyTo(cid, playerTo[cid], moneyTo[cid]) ~= TRUE then
                selfSay('This player does not exist on this world or have no vocation.', cid)
            else
                selfSay('You have transferred ' .. moneyTo[cid] .. ' gold to "' .. playerTo[cid] ..' ".', cid)
                playerTo[cid] = nil
            end
        elseif msgcontains(msg, 'no') then
            selfSay('As you wish. Is there something else I can do for you?', cid)
        end
        talkState[cid] = 0
    end
    return TRUE
end

npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())
 
Upvote 0 Downvote
Thanks, but I have this one. I wanna add limit of transfering gold from player to another player.

So I need to check balance of the target. but it comapres player name with number what is false and causes the problem
 
Upvote 0 Downvote
Now I get it, sorry I misunderstood you
I don't know much about lua but I think it would be possible and easier to get his balance through SQL commands
something like
Code: 
if SELECT balance FROM players WHERE id = transfer[cid]; <= 1000
OBS: dunno if the query or the code is right and I don't know how to compare SQL results to lua values but I think you got the point
 
Last edited:
Upvote 0 Downvote
Lua: 
getPlayerBalance = function(cid)
                local result = db.getResult("SELECT `balance` FROM `players` WHERE `id` = " .. getPlayerGUID(cid))
                if(result:getID() == -1) then
                        return false
                end
                local value = tonumber(result:getDataString("balance"))
                result:free()
                return value
        end

getPlayerBalance as you can see this function is made as you said.

But I dont get it why, when it gets player name as parameter, it says attempt to compare boolean with number ( number is the 1000 amount of gold)
 
Upvote 0 Downvote
inversely, it gives(transfer[cid] from the code) player name.

so it's impossible to compare string with number
ex. Tom = 1000 its false
 
Upvote 0 Downvote
heyo, your getPlayerBalance function checks for name not creature id (important because offline players don't have a creature id & the script should probably allow transfers to offline players right?)
the 2 problems with your function was getPlayerGUID(cid) which checks for creature id when
transfer[cid] = msg
is actually player name
and
jestem pro said:
if(result:getID() == -1) then
return false
end
Click to expand...
If I'm not mistaken this part serves no purpose & returns a Boolean which is not desired

so
Lua: 
getPlayerBalance = function(name)
    local result = db.getResult("SELECT `balance` FROM `Players` WHERE `id` = "..getPlayerGUIDByName(name))

    local value = tonumber(result:getDataString("balance"))
    result:free()
    return value
end

and then just implement that check from the other script Lurk posted

Lua: 
local maxReceiveAmount = 1000
transfer[cid] = msg

if playerExists(transfer[cid]) then
    if getPlayerBalance(transfer[cid]) + moneyTo[cid] <= maxReceiveAmount then -- check for receivers balance + money you want to send
        selfSay('So you would like to transfer ' .. moneyTo[cid] .. ' gold to "' .. transfer[cid] .. '" ?', cid)
        talkState[cid] = 13
    else
        selfSay("Sorry, "..transfer[cid].." cannot receive that much money at the moment", cid)
        talkState[cid] = 0
    end
else
    selfSay('Player with name "' .. transfer[cid] .. '" doesnt exist.', cid)
    talkState[cid] = 0
end
 
Upvote 0 Downvote

Similar threads

J
  • Question
Npc Problem Help Please
Replies
2
Views
331
Mateus Robeerto
Mateus Robeerto
potinho
  • Question
TFS 0.X Buy things on NPC with Bank Balance
Replies
2
Views
266
potinho
potinho
F
  • Question
script npc modification
Replies
5
Views
348
Mateus Robeerto
Mateus Robeerto
Back
Top