• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Programmer Tfs 1.2 (player die in arena( PvP Zone) by monster and drop level) pay for job $$

R

roriscrave

Advanced OT User
Joined
Dec 7, 2011
Messages
1,188
Solutions
34
Reaction score
200
I am using tfs 1.2 downgraded 8.6.
When a player dies by a monster in the arena (PVP Zone Tool), the player loses level (as if in a normal zone).
I tried to use this fix:
github.com

Fix an issue with deaths by monsters in PVP Zones (#1883) · otland/forgottenserver@da1db22

A free and open-source MMORPG server emulator written in C++ - Fix an issue with deaths by monsters in PVP Zones (#1883) · otland/forgottenserver@da1db22
github.com github.com

But not solved, the bug still occurs.
I am looking for someone who knows how to solve and we will combine the value of the service!
Thankful!

here is the original code of tfs 1.2 (with bug), that need to be fixed up
C++: 
bool Player::dropCorpse(Creature* _lastHitCreature, Creature* mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified)
{
    if (getZone() == ZONE_PVP) {
        setDropLoot(true);
        return false;
    }
    return Creature::dropCorpse(_lastHitCreature, mostDamageCreature, lastHitUnjustified, mostDamageUnjustified);
}

Item* Player::getCorpse(Creature* _lastHitCreature, Creature* mostDamageCreature)
{
    Item* corpse = Creature::getCorpse(_lastHitCreature, mostDamageCreature);
    if (corpse && corpse->getContainer()) {
        std::ostringstream ss;
        if (_lastHitCreature) {
            ss << "You recognize " << getNameDescription() << ". " << (getSex() == PLAYERSEX_FEMALE ? "She" : "He") << " was killed by " << _lastHitCreature->getNameDescription() << '.';
        } else {
            ss << "You recognize " << getNameDescription() << '.';
        }

        corpse->setSpecialDescription(ss.str());
    }
    return corpse;
}
 
Last edited:
C++: 
bool Player::dropCorpse(Creature* lastHitCreature, Creature* mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified)
{
    if (getZone() != ZONE_PVP || !Player::lastHitIsPlayer(lastHitCreature)) {
        return Creature::dropCorpse(lastHitCreature, mostDamageCreature, lastHitUnjustified, mostDamageUnjustified);
    }

    setDropLoot(true);
    return false;
}
 
Qbazzz said:
C++: 
bool Player::dropCorpse(Creature* lastHitCreature, Creature* mostDamageCreature, bool lastHitUnjustified, bool mostDamageUnjustified)
{
    if (getZone() != ZONE_PVP || !Player::lastHitIsPlayer(lastHitCreature)) {
        return Creature::dropCorpse(lastHitCreature, mostDamageCreature, lastHitUnjustified, mostDamageUnjustified);
    }

    setDropLoot(true);
    return false;
}
Click to expand...
i tried it, but i get some error during compilation, someone now how can i solve?:1565308826432.png
 
Last edited:
C++: 
bool Player::lastHitIsPlayer(Creature* lastHitCreature)
{
    if (!lastHitCreature) {
        return false;
    }

    if (lastHitCreature->getPlayer()) {
        return true;
    }

    Creature* lastHitMaster = lastHitCreature->getMaster();
    return lastHitMaster && lastHitMaster->getPlayer();
}
 
Qbazzz said:
C++: 
bool Player::lastHitIsPlayer(Creature* lastHitCreature)
{
    if (!lastHitCreature) {
        return false;
    }

    if (lastHitCreature->getPlayer()) {
        return true;
    }

    Creature* lastHitMaster = lastHitCreature->getMaster();
    return lastHitMaster && lastHitMaster->getPlayer();
}
Click to expand...

compiled fine, but dont works. In arena PvP player die by a player (ok, dont drop level).
In area player die by a monster (player drop level)
 
Do you give your players blessings when they log in?
 
Back
Top