Lua Function [TFS 1.3] Item abilities via Lua

Infernum said:

If I were to ever work on this again, it'd be a complete rewrite to revscripts utilizing CustomAttributes to avoid writing direct serialization and open up infinite possibilities for abilities to be added instead of being limited to 64 bit flags.
You're welcome to share your improvements to the rest of the people here, I'm sure they'd be glad to have them.

Click to expand...

ralke said:

Engine: OTX 3.8 protocol 8.6

@Infernum Hi! I did everything, also added this

Compiling - How to show health and mana(healing numbers)

Hello team, Could anyone help me with a code for 10.98 TFS-1.2 server? After using HP and MP potions show the heal numbers. I need the code to compile (Visual Studio program) . Ex: Thnx :)

otland.net

And this fixes (i had missing items.cpp lines same as that thread)

TFS 1.3 abilities

hi i was using a compiled of this repo: Vulcanx/forgottenserver (https://github.com/Vulcanx/forgottenserver/tree/abilities-remove) and i was trying to add new abilities that are here: extra item abilities, core itemabilities fixes · stigmatic/engine@14aaddb...

otland.net

Also the two commits mentioned for 1.2

Adding "boosts" introduced in protocol 10.94 (#2395) · otland/forgottenserver@0d2c287

Items now have 6 new attributes, which are by default 0: criticalhitchance, criticalhitamount, hitpointsleechchance, hitpointsleechamount, manapointsleechchance and manapointsleechamount. Criti...

github.com

Boosts name changes and 2 new functions (#2485) · otland/forgottenserver@c7bef15

Lua functions added: luaPlayerGetSpecialSkill luaPlayerAddSpecialSkill

github.com

To OTX 3.8 (guess it is based on TFS 1.2), but having this errors on compile

First attempt
View attachment 57134
Second attempt
View attachment 57135

Code:

1>..\src\items.cpp(640): error C2039: 'forceSerialize': is not a member of 'ItemType'
1>  d:\users\usuario\desktop\greed380\src\items.h(211): note: see declaration of 'ItemType'

Code:

1>..\src\game.cpp(3711): error C2660: 'Game::combatChangeMana': function does not take 3 arguments
1>..\src\game.cpp(3717): error C2065: 'CONST_ME_CRITICAL_DAMAGE': undeclared identifier

If I missed something, please help!

Click to expand...

[TFS 1.3] Item Abilities via Lua V2

Utilizes revscripts and custom attributes unlike my last one, way less source code involved. Somewhat tested. https://github.com/otland/forgottenserver/compare/master...infernumx:item-abilities-updated Functions: item:setAbility(key, value) item:getAbility(key) item:getAbilities()...

otland.net

Infernum said:

this thread is old

[TFS 1.3] Item Abilities via Lua V2

Utilizes revscripts and custom attributes unlike my last one, way less source code involved. Somewhat tested. https://github.com/otland/forgottenserver/compare/master...infernumx:item-abilities-updated Functions: item:setAbility(key, value) item:getAbility(key) item:getAbilities()...

otland.net

Click to expand...

data/scripts/ItemAbilities/3_tempconditions.lua

Infernum said:

For now, this only works with TFS 1.3. If you use 1.2 and still want to use this code you can apply this commit to your sources for critical and leech skills, this commit as well since it was pushed later

Click to expand...

Infernum said:

Don't have the time to completely finish this, but here's a skeleton on how you could do this (read every comment as well):

C++:

// Abilities reference here, this is what you need to access inside of getAbilityInt

struct Abilities {
    uint32_t healthGain = 0;
    uint32_t healthTicks = 0;
    uint32_t manaGain = 0;
    uint32_t manaTicks = 0;

    uint32_t conditionImmunities = 0;
    uint32_t conditionSuppressions = 0;

    //stats modifiers
    int32_t stats[STAT_LAST + 1] = { 0 };
    int32_t statsPercent[STAT_LAST + 1] = { 0 };

    //extra skill modifiers
    int32_t skills[SKILL_LAST + 1] = { 0 };
    int32_t specialSkills[SPECIALSKILL_LAST + 1] = { 0 };

    int32_t speed = 0;

    // field damage abilities modifiers
    int16_t fieldAbsorbPercent[COMBAT_COUNT] = { 0 };

    //damage abilities modifiers
    int16_t absorbPercent[COMBAT_COUNT] = { 0 };

    //elemental damage
    uint16_t elementDamage = 0;
    CombatType_t elementType = COMBAT_NONE;

    bool manaShield = false;
    bool invisible = false;
    bool regeneration = false;
};

// items.h underneath public:
int getAbilityInt(itemAbilityTypes ability);

// items.cpp above Items::Items()
int getAbilityInt(itemAbilityTypes ability)
{
    Abilities& abilities = getAbilities();
    switch (ability) {
        case ITEM_ABILITY_NONE:
            return 0;

        case ITEM_ABILITY_ABSORBENERGY:
            return abilities.absorbPercent[COMBAT_ENERGYDAMAGE];

        // add the rest of the abliities here

        default:
            return 0;

    }
    return 0;
}

// luascript.h
static int luaItemTypeGetAbility(lua_State* L); // place underneath another itemType forward declaration

// luascript.cpp

registerMethod("ItemType", "getAbility", LuaScriptInterface::luaItemTypeGetAbility); // place where the rest of the itemType registerMethods are

int LuaScriptInterface::luaItemTypeGetAbility(lua_State* L) // place underneath any other itemType function definition
{
    // itemType:getAbility(ability)
    const ItemType* itemType = getUserdata<const ItemType>(L, 1);
    itemAbilityTypes ability;
    if (isNumber(L, 2)) {
        ability = getNumber<itemAbilityTypes>(L, 2);
    } else {
        ability = ITEM_ABILITY_NONE;
    }

    if (itemType) {
        lua_pushnumber(L, itemType->getAbilityInt(ability));
    } else {
        lua_pushnil(L);
    }

    return 1;
}

This would implement a function for the itemType class where you can use itemType:getAbility(ability enum) to return the default value loaded from items.xml. All you should need to do is add a case for every single enum available and access the Abilities struct (the struct i provided for reference at the top of the code).
I provided an example on how to get absorbPercent for energy damage inside. Follow that example for every other enum and there will be no problem.
If you don't want to bother I'll do this eventually since I forgot it, but if you do add all the cases I can review it and merge it so others could use it as well.

Click to expand...

/home/jroma/forgottenserver-otclientv8/src/items.cpp: In function ‘int getAbilityInt(itemAbilityTypes)’:
/home/jroma/forgottenserver-otclientv8/src/items.cpp:1383:28: error: ‘getAbilities’ was not declared in this scope; did you mean ‘ItemAbilities’?
 1383 |     Abilities& abilities = getAbilities();
          |                                     ^~~~~~~~~~~~
          |                                     ItemAbilities

// items.h underneath public:
int getAbilityInt(itemAbilityTypes ability);

    public:
        int getAbilityInt(itemAbilityTypes ability);