C++ Boss Reward System BlackTek-Server

3alola1 said:

I got a weird but using it whenever the loot has stackable items those items cant be stacked again with another items having same id

for example the looted crystal coins cant be stacked with another crystal coins.
has any one faced this problem?

Click to expand...

3alola1 said:

I got a weird but using it whenever the loot has stackable items those items cant be stacked again with another items having same id

for example the looted crystal coins cant be stacked with another crystal coins.
has any one faced this problem?

Click to expand...

Codinablack said:

This problem is due to the fact that there were custom attributes assigned to the items during their creation to be used for removing them after the 7 days was up... Stackables with custom attributes can't stack with other stackables, so if you want to resolve this problem, you sacrifice the "automatic deletion" for the stackables, but is worth IMO. You have to find the piece of code which assigns the items the date with a custom attribute and don't assign it if the item is a stackable, ez pz fix.

Click to expand...

local FIX_ITEM_ID = 8919
local COOLDOWN_STORAGE = 50001
local COOLDOWN_SECONDS = 4

local fixTool = Action()

function fixTool.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    if not target or not target:isItem() then
        player:sendCancelMessage("You must use this on an item or container.")
        return true
    end

    -- Cooldown check
    local lastUse = player:getStorageValue(COOLDOWN_STORAGE)
    local now = os.time()
    if lastUse ~= -1 and now - lastUse < COOLDOWN_SECONDS then
        local remaining = COOLDOWN_SECONDS - (now - lastUse)
        player:sendCancelMessage("You must wait " .. remaining .. " more seconds to use this again.")
        return true
    end
    player:setStorageValue(COOLDOWN_STORAGE, now)

    local fixedCount = 0

    if target:isContainer() then
        for i = 0, target:getSize() - 1 do
            local subItem = target:getItem(i)
            if subItem then
                subItem:removeAttribute(ITEM_ATTRIBUTE_DATE)
                subItem:removeAttribute(ITEM_ATTRIBUTE_REWARDID)
                subItem:removeAttribute(ITEM_ATTRIBUTE_OWNER)
                fixedCount = fixedCount + 1
            end
        end
    else
        target:removeAttribute(ITEM_ATTRIBUTE_DATE)
        target:removeAttribute(ITEM_ATTRIBUTE_REWARDID)
        target:removeAttribute(ITEM_ATTRIBUTE_OWNER)
        fixedCount = 1
    end

    player:sendTextMessage(MESSAGE_STATUS_CONSOLE_ORANGE, "Fixed " .. fixedCount .. " item(s).")
    player:getPosition():sendMagicEffect(CONST_ME_MAGIC_RED)
    return true
end

fixTool:id(FIX_ITEM_ID)
fixTool:register()

Codinablack said:

Could do the same with a lua movement script, if it's stackables coming from reward chest, clear the custom attribute

I like your solution though, show's dedication

Click to expand...

function Player:onMoveItem(item, count, fromPosition, toPosition, fromContainer, toContainer)

    -- Check if item is moved from container ID 21518
    if fromContainer and fromContainer:isContainer() then
        if fromContainer:getId() == 21518 then
            if item:isItem() then
                item:removeAttribute(ITEM_ATTRIBUTE_REWARDID)
                item:removeAttribute(ITEM_ATTRIBUTE_OWNER)
                item:removeAttribute(ITEM_ATTRIBUTE_DATE)
            end
        end
    end

    return true
end

Mattzon194 said:

had this issue for a moment, but it was gone after a while? :O u did on a clean source?

Click to expand...

3alola1 said:

As blacked said the items has attributes and it should be removed.
uss my method up there the onmoveitem or the action script

Click to expand...

Fix loot stacking: ensure stackable items are created cleanly in cont… · Mateuzkl/TFS-1.4.2-1098-GESIOR@6acd07a

…ainer, monster, and rewardchest logic

github.com

Mateus Robeerto said:

I hadn’t noticed this bug before, but after seeing the report, I tested it using the reward container system and confirmed the issue: stackable items like coins weren’t stacking properly due to hidden attributes.

Personally, I prefer handling things directly in the C++ source rather than Lua whenever possible, so I went ahead and fixed it there.

If you’re interested, feel free to take a look at the commit I made with the fix.

Fix loot stacking: ensure stackable items are created cleanly in cont… · Mateuzkl/TFS-1.4.2-1098-GESIOR@6acd07a

…ainer, monster, and rewardchest logic

github.com

Click to expand...

Mateus Robeerto said:

I hadn’t noticed this bug before, but after seeing the report, I tested it using the reward container system and confirmed the issue: stackable items like coins weren’t stacking properly due to hidden attributes.

Personally, I prefer handling things directly in the C++ source rather than Lua whenever possible, so I went ahead and fixed it there.

If you’re interested, feel free to take a look at the commit I made with the fix.

Fix loot stacking: ensure stackable items are created cleanly in cont… · Mateuzkl/TFS-1.4.2-1098-GESIOR@6acd07a

…ainer, monster, and rewardchest logic

github.com

Click to expand...

Sunnad said:

This solution you posted is working but it has an error when the player doesn't grab the loot and logs out or dies, all items that are Stackable are eliminated, only the players need to do boss and grab the loot at once to avoid being eliminated if they die or log out

Click to expand...

Enable date on reward stackables · Black-Tek/BlackTek-Server@9f92668

A 2D Top Down (MMORPG) Game Server, with the goal of becoming a rapid development game engine someday - Enable date on reward stackables · Black-Tek/BlackTek-Server@9f92668

github.com