Solved [8.54] POTIONS .v2

[deviant motive]

Hello again my dear friends!​

Someone told me that i won't do potions with charges, but i already did them ​

But there is a 1 problem. They don't lose charges!​

Here is the screen to prove it:
​

And there is the script:
(potions.lua)

local config = {
	removeOnUse = "no",
	usableOnTarget = "no", -- can be used on target? (fe. healing friend)
	splashable = "no",
	realAnimation = "no", -- make text effect visible only for players in range 1x1
	healthMultiplier = 1.0,
	manaMultiplier = 1.0
}

config.removeOnUse = getBooleanFromString(config.removeOnUse)
config.usableOnTarget = getBooleanFromString(config.usableOnTarget)
config.splashable = getBooleanFromString(config.splashable)
config.realAnimation = getBooleanFromString(config.realAnimation)

local POTIONS = {
	[2269] = {empty = 7636, splash = 2, health = {50, 50}}, -- health potion
	[2270] = {empty = 7634, splash = 2, health = {200, 200}}, -- strong health potion
	[2271] = {empty = 7635, splash = 2, health = {500, 500}}, -- great health potion

	[2272] = {empty = 7636, splash = 7, mana = {50, 50}}, -- mana potion
	[2273] = {empty = 7634, splash = 7, mana = {200, 200}}, -- strong mana potion
	[2274] = {empty = 7635, splash = 7, mana = {500, 500}}, -- great mana potion

}

local exhaust = createConditionObject(CONDITION_EXHAUST)
setConditionParam(exhaust, CONDITION_PARAM_TICKS, (getConfigInfo('timeBetweenExActions') - 100))

function onUse(cid, item, fromPosition, itemEx, toPosition)
	local potion = POTIONS[item.itemid]
	if(not potion) then
		return false
	end

	if(not isPlayer(itemEx.uid) or (not config.usableOnTarget and cid ~= itemEx.uid)) then
		if(not config.splashable) then
			return false
		end

		if(toPosition.x == CONTAINER_POSITION) then
			toPosition = getThingPos(item.uid)
		end

		doDecayItem(doCreateItem(2016, potion.splash, toPosition))
		return true
	end

	if(hasCondition(cid, CONDITION_EXHAUST_HEAL)) then
		doPlayerSendDefaultCancel(cid, RETURNVALUE_YOUAREEXHAUSTED)
		return true
	end

	if(((potion.level and getPlayerLevel(cid) < potion.level) or (potion.vocations and not isInArray(potion.vocations, getPlayerVocation(cid)))) and
		not getPlayerCustomFlagValue(cid, PLAYERCUSTOMFLAG_GAMEMASTERPRIVILEGES))
	then
		doCreatureSay(itemEx.uid, "Only " .. potion.vocStr .. (potion.level and (" of level " .. potion.level) or "") .. " or above may drink this fluid.", TALKTYPE_ORANGE_1)
		return true
	end

	local health = potion.health
	if(health and not doCreatureAddHealth(itemEx.uid, math.ceil(math.random(health[1], health[2]) * config.healthMultiplier))) then
		return false
	end

	local mana = potion.mana
	if(mana and not doPlayerAddMana(itemEx.uid, math.ceil(math.random(mana[1], mana[2]) * config.manaMultiplier))) then
		return false
	end

	doSendMagicEffect(getThingPos(itemEx.uid), CONST_ME_MAGIC_BLUE)
	if(not realAnimation) then
		doCreatureSay(itemEx.uid, "+HEALTH+", TALKTYPE_ORANGE_1)
	else
		for i, tid in ipairs(getSpectators(getCreaturePosition(cid), 1, 1)) do
			if(isPlayer(tid)) then
				doCreatureSay(itemEx.uid, "+MANA+", TALKTYPE_ORANGE_1, false, tid)
			end
		end
	end

	doAddCondition(cid, exhaust)
	if(not potion.empty or config.removeOnUse) then
		doRemoveItem(item.uid)
		return true
	end

	return true
end

(actions.xml)

<action itemid="2269-2271;2272-2274" event="script" value="liquids/potions.lua"/>

But there is a 1 problem. They don't lose charges!
***Those potions are changed runes' images***
Please can someone solve this problem?

 

[darqnies]

	if(not potion.empty or config.removeOnUse) then
		doRemoveItem(item.uid)
		return true
	end

on just:

doRemoveItem(item.uid)

potion.empty? rawr, missed somethin?

 

[deviant motive]

Huh, i don't want them do be removed after 1 use. I want them to lose charges man ;D READ CAREFULLY

 

[Gregor]

did you edit them good in item editor?

 

[deviant motive]

Yup . There is no problem in it.
It's between functions in this script.
But i don't know how to fix it .
Someone knows what is function to remove charge from rune when using? ^^

 

[deviant motive]

Maybe the​

Cykotitan​

​

Will know how to fix it ?​

:>​

 

[deviant motive]

Bump!

 

[darqnies]

doRemoveItem(item[B].uid[/B])

not

doRemoveItem(item)

It should remove one charge as i think =S.
But maybe am wrong.

 

[Cykotitan]

#deviant motive

local config = {
	usableOnTarget = "no", -- can be used on target? (fe. healing friend)
	splashable = "no",
	realAnimation = "no", -- make text effect visible only for players in range 1x1
	healthMultiplier = 1.0,
	manaMultiplier = 1.0
}

config.usableOnTarget = getBooleanFromString(config.usableOnTarget)
config.splashable = getBooleanFromString(config.splashable)
config.realAnimation = getBooleanFromString(config.realAnimation)

local POTIONS = {
	[2269] = {empty = 7636, splash = 2, health = {50, 50}}, -- health potion
	[2270] = {empty = 7634, splash = 2, health = {200, 200}}, -- strong health potion
	[2271] = {empty = 7635, splash = 2, health = {500, 500}}, -- great health potion

	[2272] = {empty = 7636, splash = 7, mana = {50, 50}}, -- mana potion
	[2273] = {empty = 7634, splash = 7, mana = {200, 200}}, -- strong mana potion
	[2274] = {empty = 7635, splash = 7, mana = {500, 500}}, -- great mana potion

}

local exhaust = createConditionObject(CONDITION_EXHAUST)
setConditionParam(exhaust, CONDITION_PARAM_TICKS, (getConfigInfo('timeBetweenExActions') - 100))

function onUse(cid, item, fromPosition, itemEx, toPosition)
	local potion = POTIONS[item.itemid]
	if(not potion) then
		return false
	end

	if(not isPlayer(itemEx.uid) or (not config.usableOnTarget and cid ~= itemEx.uid)) then
		if(not config.splashable) then
			return false
		end

		if(toPosition.x == CONTAINER_POSITION) then
			toPosition = getThingPos(item.uid)
		end

		doDecayItem(doCreateItem(2016, potion.splash, toPosition))
		return true
	end

	if(hasCondition(cid, CONDITION_EXHAUST_HEAL)) then
		doPlayerSendDefaultCancel(cid, RETURNVALUE_YOUAREEXHAUSTED)
		return true
	end

	if(((potion.level and getPlayerLevel(cid) < potion.level) or (potion.vocations and not isInArray(potion.vocations, getPlayerVocation(cid)))) and
		not getPlayerCustomFlagValue(cid, PLAYERCUSTOMFLAG_GAMEMASTERPRIVILEGES))
	then
		doCreatureSay(itemEx.uid, "Only " .. potion.vocStr .. (potion.level and (" of level " .. potion.level) or "") .. " or above may drink this fluid.", TALKTYPE_ORANGE_1)
		return true
	end

	local health = potion.health
	if(health and not doCreatureAddHealth(itemEx.uid, math.ceil(math.random(health[1], health[2]) * config.healthMultiplier))) then
		return false
	end

	local mana = potion.mana
	if(mana and not doPlayerAddMana(itemEx.uid, math.ceil(math.random(mana[1], mana[2]) * config.manaMultiplier))) then
		return false
	end

	doSendMagicEffect(getThingPos(itemEx.uid), CONST_ME_MAGIC_BLUE)
	if(not realAnimation) then
		doCreatureSay(itemEx.uid, "+HEALTH+", TALKTYPE_ORANGE_1)
	else
		for i, tid in ipairs(getSpectators(getCreaturePosition(cid), 1, 1)) do
			if(isPlayer(tid)) then
				doCreatureSay(itemEx.uid, "+MANA+", TALKTYPE_ORANGE_1, false, tid)
			end
		end
	end

	doAddCondition(cid, exhaust)
	if(not potion.empty or item.type > 1) then
		doRemoveItem(item.uid, 1)
	else
		doTransformItem(item.uid, potion.empty)
	end

	return true
end

 

[deviant motive]

Cykotitan why did you say fu2 ;(, i just wanted to be nice.
I didn't have anything bad on my mind.
Btw. there is ERROR

 

[Cykotitan]

Also you copied it wrong, the script is correct.

 

[deviant motive]

I am sorry, hope You won't feel angry.
It was my mistake, actually i copied it wrong.
But it's disappears after 1 use.
I want it to lose charges, and when it got 0 charges it disappears.

Anyway, thanks for being patient and helping.

 

[Cykotitan]

Ok 1 more attempt, this would be working fine if this was a normal stackable item in the first place.

local config = {
	usableOnTarget = "no", -- can be used on target? (fe. healing friend)
	splashable = "no",
	realAnimation = "no", -- make text effect visible only for players in range 1x1
	healthMultiplier = 1.0,
	manaMultiplier = 1.0
}

config.usableOnTarget = getBooleanFromString(config.usableOnTarget)
config.splashable = getBooleanFromString(config.splashable)
config.realAnimation = getBooleanFromString(config.realAnimation)

local POTIONS = {
	[2269] = {empty = 7636, splash = 2, health = {50, 50}}, -- health potion
	[2270] = {empty = 7634, splash = 2, health = {200, 200}}, -- strong health potion
	[2271] = {empty = 7635, splash = 2, health = {500, 500}}, -- great health potion

	[2272] = {empty = 7636, splash = 7, mana = {50, 50}}, -- mana potion
	[2273] = {empty = 7634, splash = 7, mana = {200, 200}}, -- strong mana potion
	[2274] = {empty = 7635, splash = 7, mana = {500, 500}}, -- great mana potion

}

local exhaust = createConditionObject(CONDITION_EXHAUST)
setConditionParam(exhaust, CONDITION_PARAM_TICKS, (getConfigInfo('timeBetweenExActions') - 100))

function onUse(cid, item, fromPosition, itemEx, toPosition)
	local potion = POTIONS[item.itemid]
	if(not potion) then
		return false
	end

	if(not isPlayer(itemEx.uid) or (not config.usableOnTarget and cid ~= itemEx.uid)) then
		if(not config.splashable) then
			return false
		end

		if(toPosition.x == CONTAINER_POSITION) then
			toPosition = getThingPos(item.uid)
		end

		doDecayItem(doCreateItem(2016, potion.splash, toPosition))
		return true
	end

	if(hasCondition(cid, CONDITION_EXHAUST_HEAL)) then
		doPlayerSendDefaultCancel(cid, RETURNVALUE_YOUAREEXHAUSTED)
		return true
	end

	if(((potion.level and getPlayerLevel(cid) < potion.level) or (potion.vocations and not isInArray(potion.vocations, getPlayerVocation(cid)))) and
		not getPlayerCustomFlagValue(cid, PLAYERCUSTOMFLAG_GAMEMASTERPRIVILEGES))
	then
		doCreatureSay(itemEx.uid, "Only " .. potion.vocStr .. (potion.level and (" of level " .. potion.level) or "") .. " or above may drink this fluid.", TALKTYPE_ORANGE_1)
		return true
	end

	local health = potion.health
	if(health and not doCreatureAddHealth(itemEx.uid, math.ceil(math.random(health[1], health[2]) * config.healthMultiplier))) then
		return false
	end

	local mana = potion.mana
	if(mana and not doPlayerAddMana(itemEx.uid, math.ceil(math.random(mana[1], mana[2]) * config.manaMultiplier))) then
		return false
	end

	doSendMagicEffect(getThingPos(itemEx.uid), CONST_ME_MAGIC_BLUE)
	if(not realAnimation) then
		doCreatureSay(itemEx.uid, "+HEALTH+", TALKTYPE_ORANGE_1)
	else
		for i, tid in ipairs(getSpectators(getCreaturePosition(cid), 1, 1)) do
			if(isPlayer(tid)) then
				doCreatureSay(itemEx.uid, "+MANA+", TALKTYPE_ORANGE_1, false, tid)
			end
		end
	end

	doAddCondition(cid, exhaust)
	
	if(item.type > 1) then
		doChangeTypeItem(item.uid, item.type - 1)
	else
		doTransformItem(item.uid, potion.empty)
	end

	return true
end

 

[deviant motive]

Thanks a lot! You're really good scripter ;D

Maybe You'll think about being a scripter in my ot project?
I am working on website now. You can see it there

 

[Cykotitan]

Sorry, I don't have time

 

[deviant motive]

I understand. Thanks. Problem solved.