Feature Anti raibow Outfit!

[slaw]

Working with TAGS/0.2 and TRUNK

player.cpp
After:

	nextAction = 0;

Add:

	lastOutfitChange = 0;

player.h
After:

		int64_t nextAction;

Add:

		#ifdef __SLAW_ANTI_RAINBOW__
		int64_t lastOutfitChange;
		#endif

After:

		uint32_t getNextActionTime() const;

Add:

		#ifdef __SLAW_ANTI_RAINBOW__
		void setNextOutfitChange(uint64_t time) {if(time > lastOutfitChange) {lastOutfitChange = time;}}
		bool canChangeOutfit() const {return lastOutfitChange <= OTSYS_TIME();}
		#endif

game.cpp
In function:

bool Game::playerChangeOutfit(uint32_t playerId, Outfit_t outfit)

After:

	Player* player = getPlayerByID(playerId);
	if(!player || player->isRemoved())
		return false;

Add:

	#ifdef __SLAW_ANTI_RAINBOW__
	if(!player->canChangeOutfit())
		return false;
	#endif

And after:

		internalCreatureChangeOutfit(player, outfit);

Add:

		#ifdef __SLAW_ANTI_RAINBOW__
		player->setNextOutfitChange(OTSYS_TIME() + 2000);
		#endif

Where, 2000 = delay betweew changing outfits.

Well, now you are protected !

 

[Sizaro]

Lol, halp! RAINBOW OUTFITTERS!

 

[Mark]

There's already some minor protection code in TFS against this, you have to request the change outfit window before you can set a new outfit.

 

[KaczooH]

pr0 code!

 

[slaw]

@Tala

But maybe some bots can first send request, and next set? ; o

[Update]
Added player.cpp part ;!

 

[Mark]

@Tala

But maybe some bots can first send request, and next set? ; o

[Update]
Added player.cpp part ;!

The thing is that majority of bot developers doesn't think about that since it works fine on CipSoft's server without requesting, so you can even use the code in TFS to find out who cheat (checking who tried to set outfit without requesting outfit window first).

 

[zniC]

Add ban to it instead :s

 

[koitsalu]

Slawkens always working to block cheaters

 

[ScorpiOOn93]

Nice error yeah? ...

But when i deleted this line, its all fine. Wtf?

 

[slaw]

You forgot this part in player.h?

        #ifdef __SLAW_ANTI_RAINBOW__
        int64_t lastOutfitChange;
        #endif

 

[ScorpiOOn93]

@Up
Nope, i didnt forgot about anything ;|

 

[slaw]

Yes you forgot ; |

player.h

int64_t lastOutfitChange;

You havent this, or missspelled. Or forgot to remove __SLAW_ANTI_RAWINBOW__

 

[ScorpiOOn93]

@Up
I have this in player.h but i didnt remove "__SLAW_ANTI_RAWINBOW__ " ?
In player.h i have:

#ifdef __SLAW_ANTI_RAINBOW__
int64_t lastOutfitChange;
#endif

I must remove it? :>

 

[7881374]

it's sucker error

When you work Work "ok or no Work better" -.-