TFS 1.X+ Attackspeed change milliseconds to percent

[Allan Silva]

-TFS 1.3

Hi

I added the attackspeed system on the server following this reference

TFS 1.X+ - [C++] item attack speed (attr key not recognized)

Hello, so I'm trying to have attack speed on each weapon. No errors on compiling, only this error in console: [Warning - Items::parseItemNode] Unknown key value: attackspeed It also doesn't work if it's attackSpeed. Here's what I've done: items.cpp } else if (tmpStrValue == "attack")...

otland.net

The script only run when I put this cod

Player.h

uint32_t getAttackSpeed() const {
            Item* weapon = getWeapon(false);

            if (weapon && weapon->getAttackSpeed() > 0)
                return weapon->getAttackSpeed();
            return vocation->getAttackSpeed();
        }

​

Now script are working, but attackspeed attribute is based on milliseconds and I would like to change it to a percentage. Any ideas what can be changed to do this?
Thanks!

 

[Snavy]

The following line should give you +%

(weapon->getAttackSpeed() * 100) / vocation->getAttackSpeed()

e.g:

player atk speed = 2000
weapon atk speed = 1000

(weaponAtkSpeed * 100) / playerAtkSpeed = 50(%)

 

[Allan Silva]

The following line should give you +%

(weapon->getAttackSpeed() * 100) / vocation->getAttackSpeed()

e.g:

player atk speed = 2000
weapon atk speed = 1000

(weaponAtkSpeed * 100) / playerAtkSpeed = 50(%)

I put your code like this

uint32_t getAttackSpeed() const {
      Item* weapon = getWeapon(false);

      if (weapon && weapon->getAttackSpeed() > 0)
        return (weapon->getAttackSpeed() * 100) / vocation->getAttackSpeed();
      return vocation->getAttackSpeed();
        }

Independent of the value, the attack was very fast.

 

[Snavy]

I put your code like this

uint32_t getAttackSpeed() const {
      Item* weapon = getWeapon(false);

      if (weapon && weapon->getAttackSpeed() > 0)
        return (weapon->getAttackSpeed() * 100) / vocation->getAttackSpeed();
      return vocation->getAttackSpeed();
        }

Independent of the value, the attack was very fast.

I probably misunderstood you.

Is your goal to, inside the description, display the extra percentage added to the player atk speed ?
In that case, you could write the amount of % directly in the xml attribute & change description part to;
s << "AtkSpd: +" << attackSpeed << "%";

And modify getAttackSpeed() like this

uint32_t getAttackSpeed() const {
    Item* weapon = getWeapon(false);

    if (weapon && weapon->getAttackSpeed() > 0) {
        return (1 + (weapon->getAttackSpeed() / 100)) * vocation->getAttackSpeed();
    }

    return vocation->getAttackSpeed();
}

 

[Allan Silva]

This cod works fine

s << "AtkSpd: +" << attackSpeed << "%";

But attackspeed dont. When I put 100% atkspd time takes double that normal attack, when I put 1%, nothing happens (normal atk basic)

 

[Snavy]

When I put 100% atkspd time takes double that normal attack

EDIT:

I was thinking wrong the whole time
( higher atk speed value => higher attack delay )

return vocation->getAttackSpeed() * (1 - (weapon->getAttackSpeed() / 100));

 

[Allan Silva]

If you have 2000 base speed
and add 100% (+2000) you will end up with 4000 speed.


1% might not be enough to notice.

(1+(1 / 100)) * 2000 = 2020 ATK Speed

Lower attack speed to be fast (1000 milisecond = 1 second to do attack basic) and higher to be slow (4000 milisecond = 4 second to do attack basic). This show how attacks you do in miliseconds, I believe you got confused.

 

[Snavy]

Lower attack speed to be fast (1000 milisecond = 1 second to do attack basic) and higher to be slow (4000 milisecond = 4 second to do attack basic). This show how attacks you do in miliseconds, I believe you got confused.

Edited. Try new one

 

[Allan Silva]

Edited. Try new one

The formula now appears to be correct. but attackspeed does not appear to follow the item's value. I changed values from 1 to 99% and nothing has changed (attackspeed normal). When I set the value to 100%, the attack worked very fast (very very fast)

Post automatically merged: Mar 28, 2021

The formula now appears to be correct. but attackspeed does not appear to follow the item's value. I changed values from 1 to 99% and nothing has changed (attackspeed normal). When I set the value to 100%, the attack worked very fast (very very fast).


What you think about this cod, I found researching the solution to the problem, but I couldn't compile it

uint32_t getAttackSpeed() const {
            int64_t bonusPercent = getEffectiveAbility(ITEM_ABILITY_ATTACKSPEED);
            int64_t as = (attackSpeed > 0) ? attackSpeed : vocation->getAttackSpeed();
            as -= as * (bonusPercent / 100.);
            return as;
        }

 

[Snavy]

attackspeed does not appear to follow the item's value. I changed values from 1 to 99% and nothing has changed (attackspeed normal).

That sounds odd.

>>> 2000 * (1 - (1/100))
1980.0

>>> 2000 * (1 - (2/100))
1960.0

>>> 2000 * (1 - (4/100))
1920.0

>>> 2000 * (1 - (99/100))
20.0

>>> 2000 * (1 - (100/100))
0.0

but I couldn't compile it

your method getAttackSpeed has uint32_t as return type.
That code is trying to return int64_t value

 

[Allan Silva]

You cod is nice now

return vocation->getAttackSpeed() * (1 - (weapon->getAttackSpeed() / 100));

The question, why dont work?

 

[Snavy]

You cod is nice now

return vocation->getAttackSpeed() * (1 - (weapon->getAttackSpeed() / 100));

The question, why dont work?

I will test it soon & reply

Post automatically merged: Mar 28, 2021

@Allan Silva

Just tested and noticed that division is converted to int.
so try this

return vocation->getAttackSpeed() * (1 - (weapon->getAttackSpeed() / 100.0));

 

[Allan Silva]

@Snavy

Thanks a lot for help me. Now script's working perfectly!