• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!
  • New resources must be posted under Resources tab. A discussion thread will be created automatically, you can't open threads manually anymore.

Feature Attributes MOD

Gover said:
Hello, i know that this is old topic, but maybe someone have the same issue as I have :)
First of all great job with the scripts and modifications, it really works great atm.

I'm facing the last issue with speed bonus on items.

I had add "!" before the "item->getAttribute(CONVERSION::SPEED).empty()" to the ability to take effect. Before when I was wearing the bonus item it would not give me any speed boost. After this change it is working fine with EquipItem, but something is wrong with the DeEquipItem.

C++: 
 if(it.abilities.speed  || !item->getAttribute(CONVERSION::SPEED).empty())
    {
        boost::any attr;
        attr = item->getAttribute(CONVERSION::SPEED);
        int32_t val = 0;
                if (it.abilities.speed)
                val += it.abilities.speed;
            if (!attr.empty() && ((attr.type() == typeid(float)) || (attr.type() == typeid(int32_t))))
                val += boost::any_cast<int32_t>(attr);
        g_game.changeSpeed(player, val);
};

It looks like this as you suggest, but it doesn't remove the additional speed. If I deequip the item equip it again and repeat it, I will get additional speed each time I wear an item.

C++: 
    if(it.abilities.speed || item->getAttribute(CONVERSION::SPEED).empty())
        g_game.changeSpeed(player, -it.abilities.speed);

Do you have any ideas why the above is not working?

Many thanks in advance for help !
Click to expand...
This might be because i don't see anywhere else that would do anything on deEquip. The second code checks if ITEM that is being equipped have ability so only if swapping helmet this would work
 
Hello Sorky,
Thanks for your answer.
This code:
C++: 
    if(it.abilities.speed || item->getAttribute(CONVERSION::SPEED).empty())
        g_game.changeSpeed(player, -it.abilities.speed);

Is in the section of DeEquipItem in movements.cpp.
It should substract the value "it.abilities->speed" from the player, but it not works.
From your message I can guess that problem is with "if" condition? I believe with this line: "item->getAttribute(CONVERSION::SPEED).empty())"
I have similar codes for regeneration (healthgain, healthticks etc) and it works really well, but from some reason it is not working for speed.
I also have tried to make an MANASHIELD parametr available on item, and it works the same way as speed. It creates a MANASHIELD condition on player every time, but it is not getting removed when removing the item.

I have tried to do swapping item (i use armor), and it is not removing the condition also.

Thanks in advance for further help :)
 
Last edited:
Back
Top