TFS 1.X+ bad argument #2 to 'random' (interval is empty)

[Svira]

Hello, I have the following problem:

Lua Script Error: [CreatureScript Interface]
data/creaturescripts/scripts/stats.lua:onHealthChange
data/stats.lua:1573: bad argument #2 to 'random' (interval is empty)

I paste the script below, maybe you can see the solution. (from 1573)

local hp_d = math.random(1, math.floor(math.random(0, tonumber(cur_slots[i][2]))))
if hp_d > 0 then
doTargetCombatHealth(aid, cid, COMBAT_LIFEDRAIN, -hp_d, -hp_d, CONST_ME_MAGIC_RED)
attacker:addHealth(hp_d)
end

its TFS 1.2

 

[zuber966]

which random causes error?

 

[Svira]

hp_d

for this reason this part is not transferred

doTargetCombatHealth(aid, cid, COMBAT_LIFEDRAIN, -hp_d, -hp_d, CONST_ME_MAGIC_RED)
attacker:addHealth(hp_d)

 

[oen432]

math.floor(math.random(0, tonumber(cur_slots[i][2]))) returns 0

 

[zuber966]

hp_d

for this reason this part is not transferred

doTargetCombatHealth(aid, cid, COMBAT_LIFEDRAIN, -hp_d, -hp_d, CONST_ME_MAGIC_RED)
attacker:addHealth(hp_d)

Try to print random arguments to the console so you can see what cause error

 

[oen432]

Try to print random arguments to the console so you can see what cause error

math.random(1, 0) returns this error.

 

[zuber966]

math.random(1, 0) returns this error.

Good to know, thank you

 

[Svira]

local maxDrain = tonumber(cur_slots[i][2])
                                                if maxDrain ~= nil then
                                                    local hp_d = math.random(1, math.floor(math.random(0, maxDrain)))
                                                
                                                    if hp_d > 0 then
                                                        doTargetCombatHealth(aid, cid, COMBAT_LIFEDRAIN, -hp_d, -hp_d, CONST_ME_MAGIC_RED)
                                                        attacker:addHealth(hp_d)

solved

 

[oen432]

local maxDrain = tonumber(cur_slots[i][2])
                                                if maxDrain ~= nil then
                                                    local hp_d = math.random(1, math.floor(math.random(0, maxDrain)))
                                             
                                                    if hp_d > 0 then
                                                        doTargetCombatHealth(aid, cid, COMBAT_LIFEDRAIN, -hp_d, -hp_d, CONST_ME_MAGIC_RED)
                                                        attacker:addHealth(hp_d)

solved

No, not solved. You didn't get error because math.random(0, maxDrain) returned number higher than 0 however this is still possible to return 0 and you will get same error again.

 

[Svira]

No, not solved. You didn't get error because math.random(0, maxDrain) returned number higher than 0 however this is still possible to return 0 and you will get same error again.

24h without error and works correctly.
is a function that takes% off of damage and grants it to the hp player, may be zero and have the value specified above.

 

[oen432]

Doesn't change anything, you can run this for 1000h, matter of randomness.

 

[zuber966]

@oen432 is right. At some point second random will generate number < 1 and you will get error again. Better change your code