Feature Conjure runes on your backpadck

Stellow · May 12, 2015

Look for this function on spells.cpp:

Code:

ReturnValue ConjureSpell::internalConjureItem(Player* player, uint32_t conjureId,
    uint32_t conjureCount, uint32_t reagentId, slots_t slot, bool test /*= false*/)

On line:

Code:

        Item* item = player->getInventoryItem(slot);

Change to:

Code:

Item* item = player->getFirstItemById(reagentId);

It will look for the first blank rune on your character, and the conjured rune will be placed where the blank rune was. For example, if you have it on your hand, the rune will be conjured on your hand. Same as arrow, and inventory.

Enjoy.

hanzoha · May 9, 2016

It's not working, in TFS 0.4.0 gives me this error.

src\spells.cpp 'class Player' has no member named 'getFirstItemById'

How can I fix it? Thanks in advance!

StreamSide · May 9, 2016

hanzoha said:
It's not working, in TFS 0.4.0 gives me this error.

src\spells.cpp 'class Player' has no member named 'getFirstItemById'

How can I fix it? Thanks in advance!

show us your sources

hanzoha · May 9, 2016

Here's the github link from where I downloaded my sources.

https://github.com/Fir3element/tfs04full/blob/master/src/spells.cpp

StreamSide · May 9, 2016

hanzoha said:
Here's the github link from where I downloaded my sources.

https://github.com/Fir3element/tfs04full/blob/master/src/spells.cpp

ur server do not have that function, you can always add it https://github.com/TwistedScorpio/O...d3317c13bf8d86485/source/player.cpp#L345-L378
also you need to add it to players.h

Elgenady · May 20, 2016

for 0.4
in player.cpp

under

Item* Player::getEquippedItem(slots_t slot) const
{
Item* item = getInventoryItem(slot);
if(!item)
return NULL;

switch(slot)
{
case SLOT_LEFT:
case SLOT_RIGHT:
return item->getWieldPosition() == SLOT_HAND ? item : NULL;

default:
break;
}

return item->getWieldPosition() == slot ? item : NULL;
}

-----------------------------ADD----------------------

Item* Player::getFirstItemById(uint32_t id) const
{
Item* tmpItem = NULL;
Container* tmpContainer = NULL;
std::list<Container*> listContainer;
for(int32_t slot = SLOT_FIRST; slot <= SLOT_LAST; slot++){
if((tmpItem = getInventoryItem((slots_t)slot))){
if(tmpItem->getID() == id){
return tmpItem;
}
else if((tmpContainer = tmpItem->getContainer())){
listContainer.push_back(tmpContainer);
}
}
}

ItemList::const_iterator it;
while(!listContainer.empty()){
Container* container = listContainer.front();
listContainer.pop_front();
for(it = container->getItems(); it != container->getEnd(); ++it){
if((tmpItem = *it)){
if(tmpItem->getID() == id){
return tmpItem;
}
else if((tmpContainer = tmpItem->getContainer())){
listContainer.push_back(tmpContainer);
}
}
}
}

return NULL;
}

_________________________________________________________________________

IN SPELLS.CPP CHAGE

if(!(item = player->getInventoryItem((slots_t)i)))

--------------TO-------------

if(!(item = player->getFirstItemById((uint32_t)i)))
_________________________________________________________________________

IN PLAYER.H

under

Item* getInventoryItem(slots_t slot) const;

----------------add--------------

Item* Player::getFirstItemById(uint32_t id) const;

Stellow · May 29, 2016

Sorry, I should have specify that this tutorial is to otserv based servers.

hanzoha · Jun 4, 2016

@heba Thanks man. I haven't seen the post till now.

I got this error

player.h extra qualification 'Player::' on member 'getFirstItemById'
player.h *** [obj//player.o] Error 1

I'm using TFS 0.4 rev. 3884

Stellow · Jun 4, 2016

hanzoha said:
@heba Thanks man. I haven't seen the post till now.

I got this error

player.h extra qualification 'Player::' on member 'getFirstItemById'
player.h *** [obj//player.o] Error 1

I'm using TFS 0.4 rev. 3884

You don't need to use its class scope on a function declaration. Instead of Player::... Remove Player::

hanzoha · Jun 4, 2016

Can you give me a more elaborate example? Where should I edit that? Thanks!

hanzoha · Jun 4, 2016

Should I change this line in player.h

Code:

Item* Player::getFirstItemById(uint32_t id) const;

To this?

Code:

Item* getFirstItemById(uint32_t id) const;

Is that the only change I need to make? Thanks!

hanzoha · Jun 4, 2016

I did that already.
Now I'm getting this error.

64-bit mode not compiled in
*** [obj/player.o] Error 1

Do you know how can I fix it?

Thanks and sorry for the inconveniences

marcos16 · Nov 14, 2016

Stellow said:
Look for this function on spells.cpp:

Code:

ReturnValue ConjureSpell::internalConjureItem(Player* player, uint32_t conjureId, uint32_t conjureCount, uint32_t reagentId, slots_t slot, bool test /*= false*/)

On line:

Code:

Item* item = player->getInventoryItem(slot);

Change to:

Code:

Item* item = player->getFirstItemById(reagentId);

It will look for the first blank rune on your character, and the conjured rune will be placed where the blank rune was. For example, if you have it on your hand, the rune will be conjured on your hand. Same as arrow, and inventory.

Enjoy.

StreamSide said:
ur server do not have that function, you can always add it https://github.com/TwistedScorpio/O...d3317c13bf8d86485/source/player.cpp#L345-L378
also you need to add it to players.h

How do you not check the amount of blank rune that is in the backpack? Ex: If you have 30 or 100 blank rune works out to conjure ...

Stellow · Nov 16, 2016

marcos16 said:
How do you not check the amount of blank rune that is in the backpack? Ex: If you have 30 or 100 blank rune works out to conjure ...

Conditions are not check on this core.

marcos16 · Nov 16, 2016

Stellow said:
Conditions are not check on this core.

Can not leave rev mode 3884?

Blasphemy · Apr 17, 2020

How to add it here?

I'm using tfs 1.2

C++:

bool ConjureSpell::conjureItem(Creature* creature) const
{
    Player* player = creature->getPlayer();
    if (!player) {
        return false;
    }

    int32_t value;
    if (player->getStorageValue(666, value) || player->getStorageValue(777, value)) {
        if (value > 0) {
            player->sendCancelMessage("You cannot conjure items inside the arena.");
            return false;
        }
    }

    const uint32_t conjureCost = getManaCost(creature->getPlayer());
    const uint32_t soulCost = getSoulCost();

    if (reagentId != 0) {
        bool foundReagent = false;

        Item* item = player->getInventoryItem(CONST_SLOT_LEFT);
        if (item && item->getID() == reagentId) {
            foundReagent = true;

            // left arm conjure
            Cylinder* parent = item->getParent();
            g_game.internalRemoveItem(item);

            Item* newItem = Item::CreateItem(conjureId, conjureCount);
            if (!newItem) {
                return false;
            }

            ReturnValue ret = g_game.internalAddItem(parent, newItem);
            if (ret != RETURNVALUE_NOERROR) {
                delete newItem;
                return false;
            }

            g_game.startDecay(newItem);

            Spell::postCastSpell(player, conjureCost, soulCost);
        }

        item = player->getInventoryItem(CONST_SLOT_RIGHT);
        if (item && item->getID() == reagentId && player->getMana() >= conjureCost) {
            foundReagent = true;

            // right arm conjure
            Cylinder* parent = item->getParent();
            g_game.internalRemoveItem(item);

            Item* newItem = Item::CreateItem(conjureId, conjureCount);
            if (!newItem) {
                return false;
            }

            ReturnValue ret = g_game.internalAddItem(parent, newItem);
            if (ret != RETURNVALUE_NOERROR) {
                delete newItem;
                return false;
            }

            g_game.startDecay(newItem);

            Spell::postCastSpell(player, conjureCost, soulCost);
        }

        item = player->getInventoryItem(CONST_SLOT_AMMO);
        if (item && item->getID() == reagentId && player->getMana() >= conjureCost) {
            foundReagent = true;

            // right arm conjure
            Cylinder* parent = item->getParent();
            g_game.internalRemoveItem(item);

            Item* newItem = Item::CreateItem(conjureId, conjureCount);
            if (!newItem) {
                return false;
            }

            ReturnValue ret = g_game.internalAddItem(parent, newItem);
            if (ret != RETURNVALUE_NOERROR) {
                delete newItem;
                return false;
            }

            g_game.startDecay(newItem);

            Spell::postCastSpell(player, conjureCost, soulCost);
        }


        if (!foundReagent) {
            player->sendCancelMessage(RETURNVALUE_YOUNEEDAMAGICITEMTOCASTSPELL);
            g_game.addMagicEffect(player->getPosition(), CONST_ME_POFF);
            return false;
        }
    }
    else {
        Item* newItem = Item::CreateItem(conjureId, conjureCount);
        if (!newItem) {
            return false;
        }

        ReturnValue ret = g_game.internalPlayerAddItem(player, newItem);
        if (ret != RETURNVALUE_NOERROR) {
            delete newItem;
            return false;
        }

        g_game.startDecay(newItem);
        Spell::postCastSpell(player, conjureCost, soulCost);
    }

    postCastSpell(player, true, false);
    g_game.addMagicEffect(player->getPosition(), CONST_ME_MAGIC_RED);
    return true;
}

Olddies · Apr 17, 2020

Blasphemy said:

How to add it here?

I'm using tfs 1.2

C++:

bool ConjureSpell::conjureItem(Creature* creature) const
{
    Player* player = creature->getPlayer();
    if (!player) {
        return false;
    }

    int32_t value;
    if (player->getStorageValue(666, value) || player->getStorageValue(777, value)) {
        if (value > 0) {
            player->sendCancelMessage("You cannot conjure items inside the arena.");
            return false;
        }
    }

    const uint32_t conjureCost = getManaCost(creature->getPlayer());
    const uint32_t soulCost = getSoulCost();

    if (reagentId != 0) {
        bool foundReagent = false;

        Item* item = player->getInventoryItem(CONST_SLOT_LEFT);
        if (item && item->getID() == reagentId) {
            foundReagent = true;

            // left arm conjure
            Cylinder* parent = item->getParent();
            g_game.internalRemoveItem(item);

            Item* newItem = Item::CreateItem(conjureId, conjureCount);
            if (!newItem) {
                return false;
            }

            ReturnValue ret = g_game.internalAddItem(parent, newItem);
            if (ret != RETURNVALUE_NOERROR) {
                delete newItem;
                return false;
            }

            g_game.startDecay(newItem);

            Spell::postCastSpell(player, conjureCost, soulCost);
        }

        item = player->getInventoryItem(CONST_SLOT_RIGHT);
        if (item && item->getID() == reagentId && player->getMana() >= conjureCost) {
            foundReagent = true;

            // right arm conjure
            Cylinder* parent = item->getParent();
            g_game.internalRemoveItem(item);

            Item* newItem = Item::CreateItem(conjureId, conjureCount);
            if (!newItem) {
                return false;
            }

            ReturnValue ret = g_game.internalAddItem(parent, newItem);
            if (ret != RETURNVALUE_NOERROR) {
                delete newItem;
                return false;
            }

            g_game.startDecay(newItem);

            Spell::postCastSpell(player, conjureCost, soulCost);
        }

        item = player->getInventoryItem(CONST_SLOT_AMMO);
        if (item && item->getID() == reagentId && player->getMana() >= conjureCost) {
            foundReagent = true;

            // right arm conjure
            Cylinder* parent = item->getParent();
            g_game.internalRemoveItem(item);

            Item* newItem = Item::CreateItem(conjureId, conjureCount);
            if (!newItem) {
                return false;
            }

            ReturnValue ret = g_game.internalAddItem(parent, newItem);
            if (ret != RETURNVALUE_NOERROR) {
                delete newItem;
                return false;
            }

            g_game.startDecay(newItem);

            Spell::postCastSpell(player, conjureCost, soulCost);
        }


        if (!foundReagent) {
            player->sendCancelMessage(RETURNVALUE_YOUNEEDAMAGICITEMTOCASTSPELL);
            g_game.addMagicEffect(player->getPosition(), CONST_ME_POFF);
            return false;
        }
    }
    else {
        Item* newItem = Item::CreateItem(conjureId, conjureCount);
        if (!newItem) {
            return false;
        }

        ReturnValue ret = g_game.internalPlayerAddItem(player, newItem);
        if (ret != RETURNVALUE_NOERROR) {
            delete newItem;
            return false;
        }

        g_game.startDecay(newItem);
        Spell::postCastSpell(player, conjureCost, soulCost);
    }

    postCastSpell(player, true, false);
    g_game.addMagicEffect(player->getPosition(), CONST_ME_MAGIC_RED);
    return true;
}

forgottenserver/src/spells.cpp at 1.2 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Blasphemy · Apr 17, 2020

Olddies said:
forgottenserver/src/spells.cpp at 1.2 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Thanks, I'll test it now!

solved

Blasphemy · May 21, 2020

StreamSide said:
ur server do not have that function, you can always add it TwistedScorpio/OTHire (https://github.com/TwistedScorpio/OTHire/blob/7fd3f37293752f60109b8cad3317c13bf8d86485/source/player.cpp#L345-L378)
also you need to add it to players.h

how to add it???

Feature Conjure runes on your backpadck

C++/C#/PHP/LUA

New Member

Joseluis Gonzalez

New Member

Joseluis Gonzalez

Veteran OT User

C++/C#/PHP/LUA

New Member

C++/C#/PHP/LUA

New Member

New Member

New Member

Falkhonn

C++/C#/PHP/LUA

Falkhonn

Well-Known Member

Classicot.com

Well-Known Member

Well-Known Member

Similar threads