TFS 0.X Critical script problem

[mRefaat]

Hello

i am using this script to make a critical hit system.

local config = {
    storage = PlayerStorageKeys.critical_chance_storage,
    damage = 1.5
}

function onStatsChange(cid, attacker, type, combat, value)
    if isPlayer(attacker) and (not (attacker == cid)) and (type == STATSCHANGE_HEALTHLOSS or type == STATSCHANGE_MANALOSS) then
        local chance = getPlayerStorageValue(attacker, config.storage)
        if math.random(1, 100) <= chance then
            local new_value = math.ceil(value * config.damage)
            local new_value2 = math.ceil(value * config.damage * 2)
            if isPlayer(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value2, -new_value2, 255)
            end
            if isMonster(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value, -new_value, 255)
            end
            doSendAnimatedText(getCreaturePos(attacker), "CRITICAL!", COLOR_DARKRED)
            return false
        end
    end
    return true
end

Everything is working but i figured a problem happens sometimes.
Check the image (sometimes script(dmg) doubled or 3x critical same time)


Any help?

 

[Xikini]

Hello

i am using this script to make a critical hit system.

local config = {
    storage = PlayerStorageKeys.critical_chance_storage,
    damage = 1.5
}

function onStatsChange(cid, attacker, type, combat, value)
    if isPlayer(attacker) and (not (attacker == cid)) and (type == STATSCHANGE_HEALTHLOSS or type == STATSCHANGE_MANALOSS) then
        local chance = getPlayerStorageValue(attacker, config.storage)
        if math.random(1, 100) <= chance then
            local new_value = math.ceil(value * config.damage)
            local new_value2 = math.ceil(value * config.damage * 2)
            if isPlayer(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value2, -new_value2, 255)
            end
            if isMonster(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value, -new_value, 255)
            end
            doSendAnimatedText(getCreaturePos(attacker), "CRITICAL!", COLOR_DARKRED)
            return false
        end
    end
    return true
end

Everything is working but i figured a problem happens sometimes.
Check the image (sometimes script(dmg) doubled or 3x critical same time)
View attachment 57361

Any help?

Adding the toggle state, will tell the script to apply the damage, after it's been changed, without worrying about checking for the critical stuff a 2nd/3rd/4th time, since we already know it's been modified, and about to come through again.

local config = {
    storage = PlayerStorageKeys.critical_chance_storage,
    damage = 1.5
}

local toggle = 0

function onStatsChange(cid, attacker, type, combat, value)
    if toggle ~= 0 then
        toggle = 0
        return true
    end
    if isPlayer(attacker) and (not (attacker == cid)) and (type == STATSCHANGE_HEALTHLOSS or type == STATSCHANGE_MANALOSS) then
        local chance = getPlayerStorageValue(attacker, config.storage)
        if math.random(1, 100) <= chance then
            local new_value = math.ceil(value * config.damage)
            local new_value2 = math.ceil(value * config.damage * 2)
            if isPlayer(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value2, -new_value2, 255)
            end
            if isMonster(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value, -new_value, 255)
            end
            doSendAnimatedText(getCreaturePos(attacker), "CRITICAL!", COLOR_DARKRED)
            toggle = 1
            return false
        end
    end
    return true
end

 

[mRefaat]

Adding the toggle state, will tell the script to apply the damage, after it's been changed, without worrying about checking for the critical stuff a 2nd/3rd/4th time, since we already know it's been modified, and about to come through again.

local config = {
    storage = PlayerStorageKeys.critical_chance_storage,
    damage = 1.5
}

local toggle = 0

function onStatsChange(cid, attacker, type, combat, value)
    if toggle ~= 0 then
        toggle = 0
        return true
    end
    if isPlayer(attacker) and (not (attacker == cid)) and (type == STATSCHANGE_HEALTHLOSS or type == STATSCHANGE_MANALOSS) then
        local chance = getPlayerStorageValue(attacker, config.storage)
        if math.random(1, 100) <= chance then
            local new_value = math.ceil(value * config.damage)
            local new_value2 = math.ceil(value * config.damage * 2)
            if isPlayer(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value2, -new_value2, 255)
            end
            if isMonster(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value, -new_value, 255)
            end
            doSendAnimatedText(getCreaturePos(attacker), "CRITICAL!", COLOR_DARKRED)
            toggle = 1
            return false
        end
    end
    return true
end

Thanks for answering, but i tried it and the problem still there.

I was looking here in the forum and i found a change you did before to someone and it worked for me.
link

TFS 0.X - Why is this statsChange calling stack overflow?

I'm using tfs 0.4, rev 3777 I'm trying to use this script to increase damage by each player reset and it also has a chance to crit but it always returns a lot of errors in console even tho the values are fine here's the script function onStatsChange(cid, attacker, type, combat, value) if...

otland.net

script after change and it worked.

local config = {
    storage = PlayerStorageKeys.critical_chance_storage,
    damage = 1.5
}
local creatures = {}

function onStatsChange(cid, attacker, type, combat, value)
    if isPlayer(attacker) and (not (attacker == cid)) and (type == STATSCHANGE_HEALTHLOSS or type == STATSCHANGE_MANALOSS) then
        if creatures[cid] and creatures[cid] == 1 then
            creatures[cid] = 0
            return true
        end
        creatures[cid] = 1
        local chance = getPlayerStorageValue(attacker, config.storage)
        if math.random(1, 100) <= chance then
            local new_value = math.ceil(value * config.damage)
            local new_value2 = math.ceil(value * config.damage * 2)
            if isPlayer(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value2, -new_value2, 255)
            end
            if isMonster(cid) then
                doTargetCombatHealth(attacker, cid, combat, -new_value, -new_value, 255)
            end
            doSendAnimatedText(getCreaturePos(attacker), "CRITICAL!", COLOR_DARKRED)
            return false
        end
    end
    return true
end