Ddos attack ? no! is nukers -.- End of the nukers!!!

Rafaell_br · Jun 21, 2017

It is certain that the forms of nukar otserver are several.
One of them and put a macro to be buying things with the capacity ignored.
Let's settle.

Tested in Tfs 1.3

Download Libs of npcs
lib.rar

Scan

HTML:

https://www.virustotal.com/pt/file/88ee4c01687aa5b5997716060544901c9080e39d6eaa49dcc7fa55e04bba50e2/analysis/1498083109/

Go on data/npc/lib/npcsystem/modules.lua

Search for

Lua:

function ShopModule:callbackOnBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks)

Swap for

Lua:

function ShopModule:callbackOnBuy(cid, itemid, subType, amount, inBackpacks)

Search for

Lua:

        local a, b = doNpcSellItem(cid, itemid, amount, subType, ignoreCap, inBackpacks, backpack)

Swap for

Lua:

        local a, b = doNpcSellItem(cid, itemid, amount, subType, inBackpacks, backpack)

Search for

Lua:

            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)

Swap for

Lua:

            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, inBackpacks) end,
            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, inBackpacks) end)

Search for

Lua:

            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)

Swap for

Lua:

            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, inBackpacks) end,
            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, inBackpacks) end)

Search for

Lua:

    function ShopModule:callbackOnBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks)

Swap for

Lua:

    function ShopModule:callbackOnBuy(cid, itemid, subType, amount, inBackpacks)

Search for

Lua:

        local a, b = doNpcSellItem(cid, itemid, amount, subType, ignoreCap, inBackpacks, backpack)

Swap for

Lua:

        local a, b = doNpcSellItem(cid, itemid, amount, subType, inBackpacks, backpack)

Go on data/npc/lib/npcsystem/npchandler

Search for

Lua:

    function NpcHandler:onBuy(creature, itemid, subType, amount, ignoreCap, inBackpacks)

Swap for

Lua:

    function NpcHandler:onBuy(creature, itemid, subType, amount, inBackpacks)

Search for

Lua:

        if callback == nil or callback(cid, itemid, subType, amount, ignoreCap, inBackpacks) then
            if self:processModuleCallback(CALLBACK_ONBUY, cid, itemid, subType, amount, ignoreCap, inBackpacks) then

Swap for

Lua:

        if callback == nil or callback(cid, itemid, subType, amount, inBackpacks) then
            if self:processModuleCallback(CALLBACK_ONBUY, cid, itemid, subType, amount, inBackpacks) then

Search for

Lua:

    function NpcHandler:onSell(creature, itemid, subType, amount, ignoreCap, inBackpacks)
        local cid = creature.uid
        local callback = self:getCallback(CALLBACK_ONSELL)
        if callback == nil or callback(cid, itemid, subType, amount, ignoreCap, inBackpacks) then
            if self:processModuleCallback(CALLBACK_ONSELL, cid, itemid, subType, amount, ignoreCap, inBackpacks) then

Swap for

Lua:

    function NpcHandler:onSell(creature, itemid, subType, amount, inBackpacks)
        local cid = creature.uid
        local callback = self:getCallback(CALLBACK_ONSELL)
        if callback == nil or callback(cid, itemid, subType, amount, inBackpacks) then
            if self:processModuleCallback(CALLBACK_ONSELL, cid, itemid, subType, amount, inBackpacks) then

Go on data/npc/lib/npc.lua
Search for

Lua:

function doNpcSellItem(cid, itemId, amount, subType, ignoreCap, inBackpacks, backpack)

Swap for

Lua:

function doNpcSellItem(cid, itemId, amount, subType, inBackpacks, backpack)

Search for

Lua:

        return player:addItemEx(stuff, ignoreCap) ~= RETURNVALUE_NOERROR and 0 or amount, 0

Swap for

Lua:

        return player:addItemEx(stuff) ~= RETURNVALUE_NOERROR and 0 or amount, 0

Search for

Lua:

                if player:addItemEx(container, ignoreCap) ~= RETURNVALUE_NOERROR then

Swap for

Lua:

                if player:addItemEx(container) ~= RETURNVALUE_NOERROR then

Search for

Lua:

        if player:addItemEx(item, ignoreCap) ~= RETURNVALUE_NOERROR then

Swap for

Lua:

        if player:addItemEx(item) ~= RETURNVALUE_NOERROR then

That way even the player who puts capacity to ignore will come the message that he has no capacity and will no longer fall to the ground.

kito2 · Jun 23, 2017

Basically is remove all ignoreCap parameter?

Rafaell_br · Jun 24, 2017

kito2 said:
Basically is remove all ignoreCap parameter?

Yes

kito2 · Jun 24, 2017

Thank you so much for this, I am adding this to my data files.

armyman · Jun 24, 2017

work in avesta?

Rafaell_br · Jun 25, 2017

kito2 said:
Thank you so much for this, I am adding this to my data files.

No problem, you need to test with the normal player. account of God npc sells even without capacity.

armyman said:
work in avesta?

No

darkjav · Jun 27, 2017

@Rafaell_br

In you post, said that:

Search for

Lua:

            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)

Swap for

Lua:

            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)

I think the correct is:

Swap for

Lua:

            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, inBackpacks) end,
            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, inBackpacks) end)

Maybe you missing remove:

Lua:

ignoreCap,

True? Or not necessary?
Thanks!

Rafaell_br · Jun 27, 2017

darkjav said:

@Rafaell_br

In you post, said that:

Search for

Lua:

            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)

Swap for

Lua:

            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)

I think the correct is:

Swap for

Lua:

            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, inBackpacks) end,
            function(cid, itemid, subType, amount, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, inBackpacks) end)

Maybe you missing remove:

Lua:

ignoreCap,

True? Or not necessary?
Thanks!

Is necessary, I made the correction.

Thanks.

kito2 · Jun 29, 2017

I have implemented this solution, but lot of players try to purchase and they get backpack with items... How to disable that function and just sell normally?

Nekiro · Jul 14, 2017

This "tutorial" is breaking the npc "buy in backpack" system.

If you want to restrict people from spamming, you can just put exhaust instead of removing code.

kito2 · Jul 14, 2017

Thexamx said:
This "tutorial" is breaking the npc "buy in backpack" system.

If you want to restrict people from spamming, you can just put exhaust instead of removing code.

Where do you add the exhaust?

Nekiro · Jul 14, 2017

kito2 said:
Where do you add the exhaust?

server/npc.lua at master · orts/server · GitHub
In this function probably.

kito2 · Jul 26, 2017

Thexamx said:
server/npc.lua at master · orts/server · GitHub
In this function probably.

Otxserver-New/npchandler.lua at master · malucooo/Otxserver-New · GitHub

This would solve it, right?

Nekiro · Jul 27, 2017

Code:

-- Handles onBuy events. If you wish to handle this yourself, use the CALLBACK_ONBUY callback.
    function NpcHandler:onBuy(creature, itemid, subType, amount, ignoreCap, inBackpacks)
        local cid = creature.uid
        local player = Player(cid)
      
        if player:getStorageValue(Storage.ShopDelay) >= os.time() then
            return false
        end
      
        local callback = self:getCallback(CALLBACK_ONBUY)
        if callback == nil or callback(cid, itemid, subType, amount, ignoreCap, inBackpacks) then
            if self:processModuleCallback(CALLBACK_ONBUY, cid, itemid, subType, amount, ignoreCap, inBackpacks) then
                player:setStorageValue(Storage.ShopDelay, os.time() + 0.1)
            end
        end
    end

Infernum · Jul 27, 2017

Thexamx said:

Code:

-- Handles onBuy events. If you wish to handle this yourself, use the CALLBACK_ONBUY callback.
    function NpcHandler:onBuy(creature, itemid, subType, amount, ignoreCap, inBackpacks)
        local cid = creature.uid
        local player = Player(cid)
    
        if player:getStorageValue(Storage.ShopDelay) >= os.time() then
            return false
        end
    
        local callback = self:getCallback(CALLBACK_ONBUY)
        if callback == nil or callback(cid, itemid, subType, amount, ignoreCap, inBackpacks) then
            if self:processModuleCallback(CALLBACK_ONBUY, cid, itemid, subType, amount, ignoreCap, inBackpacks) then
                player:setStorageValue(Storage.ShopDelay, os.time() + 0.1)
            end
        end
    end

use os.mtime() + 100 instead and os.mtime() for checking too
0.1 does nothing when os.time() is second precision

Nekiro · Jul 27, 2017

Static_ said:
use os.mtime() + 100 instead and os.mtime() for checking too
0.1 does nothing when os.time() is second precision

I don't really know how it is in general, because I'm not as much experienced, but in this case, it does not nothing. You are exhausted, you can check how fast you can buy with and without this code.

kito2 · Jul 27, 2017

Tested the update of @Thexamx, with the comments of @Static_ and worked, thanks both.

@Rafaell_br should update the main post with the solution.

Ddos attack ? no! is nukers -.- End of the nukers!!!

Rafaell_br

New Member

kito2

www.masteria.net

Rafaell_br

New Member

kito2

www.masteria.net

armyman

Member

Rafaell_br

New Member

darkjav

Senior Developer

Rafaell_br

New Member

kito2

www.masteria.net

Nekiro

Legendary OT User

kito2

www.masteria.net

Nekiro

Legendary OT User

kito2

www.masteria.net

Nekiro

Legendary OT User

Infernum

︈

Nekiro

Legendary OT User

kito2

www.masteria.net

Similar threads