Lua Errors with creaturescript

[adrenysny]

hello, help me with this error in console please

on <...pts/creaturescripts/quests/liquid_black/jaul_storage.lua:6>

Lua Script Error: [Scripts Interface]
/home/forgottenserver/data/scripts/creaturescripts/quests/liquid_black/obujos_storage.lua:callback
...s/creaturescripts/quests/liquid_black/obujos_storage.lua:9: attempt to index local 'player' (a nil value)
stack traceback:
        [C]: in function '__index'
        ...s/creaturescripts/quests/liquid_black/obujos_storage.lua:9: in function <...s/creaturescripts/quests/liquid_black/obujos_storage.lua:6>

Lua Script Error: [Scripts Interface]
/home/forgottenserver/data/scripts/creaturescripts/quests/liquid_black/tanjis_storage.lua:callback
...s/creaturescripts/quests/liquid_black/tanjis_storage.lua:9: attempt to index local 'player' (a nil value)
stack traceback:
        [C]: in function '__index'
        ...s/creaturescripts/quests/liquid_black/tanjis_storage.lua:9: in function <...s/creaturescripts/quests/liquid_black/tanjis_storage.lua:6>

jaul_storage:

local config = {    timeStorage = 50070,
    timeDelay   = 05 * 60 * 60 -- 24h
}

local cEvent = CreatureEvent("killJaul")
function cEvent.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    for cid, _ in pairs(creature:getDamageMap()) do
        local player = Player(cid)
        if player:isPlayer() then
            player:setStorageValue(config.timeStorage, config.timeDelay + os.time())
        end
    end
  
  
    return true
end

cEvent:register()

tanjis_storage:

local config = {    timeStorage = 50071,
    timeDelay   = 05 * 60 * 60 -- 24h
}

local cEvent = CreatureEvent("killTanjis")
function cEvent.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    for cid, _ in pairs(creature:getDamageMap()) do
        local player = Player(cid)
        if player:isPlayer() then
            player:setStorageValue(config.timeStorage, config.timeDelay + os.time())
        end
    end
  
  
    return true
end

cEvent:register()

obujos_storage:

local config = {    timeStorage = 50072,
    timeDelay   = 05 * 60 * 60 -- 24h
}

local cEvent = CreatureEvent("killObujos")
function cEvent.onDeath(creature, corpse, killer, mostDamageKiller, lastHitUnjustified, mostDamageUnjustified)
    for cid, _ in pairs(creature:getDamageMap()) do
        local player = Player(cid)
        if player:isPlayer() then
            player:setStorageValue(config.timeStorage, config.timeDelay + os.time())
        end
    end
  
  
    return true
end

cEvent:register()

 

[Sarah Wesker]

change:

local player = Player(cid)
        if player:isPlayer() then

X

local player = Player(cid)
        if player then

Why do you want to check if a player is a player? xd

 

[adrenysny]

change:

local player = Player(cid)
        if player:isPlayer() then

X

local player = Player(cid)
        if player then

Why do you want to check if a player is a player? xd

now he only gives the storage to the person who gives him the last attack

 

[Sarah Wesker]

Is possible that you are hitting it in very long intervals, try to attack the monster with 2 players at the same time and check it

 

[adrenysny]

@Sarah Wesker Test

 

[Sarah Wesker]

@Sarah Wesker Test

apparently if it works on the GIF, or do you have any other problem?

 

[adrenysny]

apparently if it works on the GIF, or do you have any other problem?

Yes it worked thank you very much

 

[Xikini]

change:

local player = Player(cid)
        if player:isPlayer() then

X

local player = Player(cid)
        if player then

Why do you want to check if a player is a player? xd

Was my fault.

Figured damage map could get creatures and players, so did a redundant check to see if the creature data I used to create a player actually made a player or not. xD
(also to ensure the players who attacked the creature were still online.. )

Why does it error there, tho?

 

[Sarah Wesker]

the function/constructor Player() returns a player if it finds it, this means that it is online