Few issues migrating from OTX3 (BGASED ON TFS 1.2) TO TFS 1.3 772

[Diarreamental]

Hello otland

i have an issue migrating from datapack
with the clean datapack + sources i have no errors in console ( tfs 1.3 protocol 7.72)

The Forgotten Server - Version 1.3
Compiled with Microsoft Visual C++ version 14.2
Compiled on Mar  7 2020 20:27:29 for platform x64

A server developed by Mark Samman
Visit our forum for updates, support, and resources: http://otland.net/.

>> Loading config
>> Establishing database connection... MySQL 10.3.6
>> Running database manager
>> Loading vocations
>> Loading items
>> Loading script systems
>> Loading lua libs
> create_functions.lua [loaded]
> defaults_move_event.lua [loaded]
> helper_constructors.lua [loaded]
> register_monster_type.lua [loaded]
>> Loading lua scripts
> #example.lua [disabled]
> #example.lua [disabled]
>> ["actions"]
> carpets.lua [loaded]
> ferumbras_amulet.lua [loaded]
> ferumbras_mana_keg.lua [loaded]
> ferumbras_staff.lua [loaded]
> gold_converter.lua [loaded]
> scroll_of_ascension.lua [loaded]
> spellbook.lua [loaded]
>> ["talkactions"]
> position.lua [loaded]
>> Loading monsters
>> Loading lua monsters
>> Loading outfits
>> Checking world type... PVP
>> Loading map
> Map size: 2048x2048.
> Map loading time: 0.002 seconds.
> Loaded house items in: 0.005 s
>> Initializing gamestate
>> Loaded all modules, server starting up...
>> Forgotten Server Online!

but when i change world + npcs i only get 1 error with one npc which is maria.

THE WEIRD PART IS that i also get error with the monster spells, i don't know why, i don't see relation between these folders( world + npc)

Lua Script Error: [Npc interface]
data/npc/scripts/Maria.lua
data/npc/lib/npcsystem/modules.lua:931: attempt to index a nil value
stack traceback:
        [C]: in function '__index'
        data/npc/lib/npcsystem/modules.lua:931: in function 'getShopItem'
        data/npc/lib/npcsystem/modules.lua:895: in function 'addBuyableItem'
        data/npc/scripts/Maria.lua:27: in main chunk
[Warning - NpcScript::NpcScript] Can not load script: Maria.lua

If i remove the npc from spawn.xml the error with the npc maria dissapear.
But im still getting errors with the monsters spells (clean files (monster and spells folder )

[Error - Monsters::deserializeSpell] - marid - Unknown spell name: paralyze_marid
[Warning - Monsters::loadMonster] Cant load spell. data/monster/marid.xml
[Error - Monsters::deserializeSpell] - marid - Unknown spell name: djinn electrify area
[Warning - Monsters::loadMonster] Cant load spell. data/monster/marid.xml
[Error - Monsters::deserializeSpell] - blue djinn - Unknown spell name: djinn electrify
[Warning - Monsters::loadMonster] Cant load spell. data/monster/blue djinn.xml
[Error - Monsters::deserializeSpell] - efreet - Unknown spell name: paralyze_efreet
[Warning - Monsters::loadMonster] Cant load spell. data/monster/efreet.xml
[Error - Monsters::deserializeSpell] - efreet - Unknown spell name: djinn electrify area
[Warning - Monsters::loadMonster] Cant load spell. data/monster/efreet.xml
[Error - Monsters::deserializeSpell] - mummy - Unknown spell name: paralyze_mummy
[Warning - Monsters::loadMonster] Cant load spell. data/monster/mummy.xml
[Error - Monsters::deserializeSpell] - orc rider - Unknown spell name: haste_orcrider
[Warning - Monsters::loadMonster] Cant load spell. data/monster/orc rider.xml
[Error - Monsters::deserializeSpell] - orc berserker - Unknown spell name: haste_orcberserker
[Warning - Monsters::loadMonster] Cant load spell. data/monster/orc berserker.xml
[Error - Monsters::deserializeSpell] - monk - Unknown spell name: haste_monk

if i change back the folders npc / and clean world the error with the monsters dissapear


please help me, since i don't see anything related in here

 

[Leo32]

The monster spell issue is because you're using custom spells in the monsters xml, that doesn't exist here:

forgottenserver/data/spells/scripts/monster at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

forgottenserver/data/spells/spells.xml at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

You should be able to pull them from your old OTX datapack.

Alternatively, replace the affected monsters with stock TFS ones from here:

forgottenserver/data/monster at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Because the spells that are missing don't actually need to be there.

For example:

[Error - Monsters::deserializeSpell] - orc berserker - Unknown spell name: haste_orcberserker
[Warning - Monsters::loadMonster] Cant load spell. data/monster/orc berserker.xml

You don't need a dedicated haste spell for orc berserkers when you can define it in the monster xml file like so:

forgottenserver/data/monster/Orcs/orc_berserker.xml at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[Diarreamental]

The monster spell issue is because you're using custom spells in the monsters xml, that doesn't exist here:

forgottenserver/data/spells/scripts/monster at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

forgottenserver/data/spells/spells.xml at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

You should be able to pull them from your old OTX datapack.

Alternatively, replace the affected monsters with stock TFS ones from here:

forgottenserver/data/monster at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

Because the spells that are missing don't actually need to be there.

For example:

[Error - Monsters::deserializeSpell] - orc berserker - Unknown spell name: haste_orcberserker
[Warning - Monsters::loadMonster] Cant load spell. data/monster/orc berserker.xml

You don't need a dedicated haste spell for orc berserkers when you can define it in the monster xml file like so:

forgottenserver/data/monster/Orcs/orc_berserker.xml at 7eb5d3a975b2e76c61fe5add259bd2c3c8351559 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

that's the weird part. I haven't changed the monster .. in the clean datapack got no errors but if in there i change the map + npcs the errors with the monster begins to appear and i see no relation



if i set back the world + npc that comes with the nekiro datapack the error dissapears , maybe because the map haven't those monster in there.

 

[Leo32]

i see no relation

Solution is still this.
The cause is irrelevant.

I ain't doing no crystal ball shit to figure out what file you moved and forgot about - that fked it all up.

 

[Diarreamental]

edit: seems to be an error with the datapack itself. thanks
the errors does not appear on the clean datapack because those monsters are not being loaded. or aren't on the map