Fix mana potion / paladin attack delay + remove weapon missing

[Itutorial]

This is make it so paladins do not stop attacking while using mana potions.

open player.cpp

find

if (weapon) {
            if (!weapon->interruptSwing()) {
                result = weapon->useWeapon(this, tool, attackedCreature);
            } else if (!classicSpeed && !canDoAction()) {
                delay = getNextActionTime();
            } else {
                result = weapon->useWeapon(this, tool, attackedCreature);
            }
        } else {
            result = Weapon::useFist(this, attackedCreature);
        }

replace with

if (weapon) {
            result = weapon->useWeapon(this, tool, attackedCreature);
        } else {
            result = Weapon::useFist(this, attackedCreature);
        }

REMOVE MISS TARGET

open weapons.cpp
replace whole function

bool WeaponDistance::useWeapon(Player* player, Item* item, Creature* target) const

with this

bool WeaponDistance::useWeapon(Player* player, Item* item, Creature* target) const
{
    int32_t damageModifier;
    const ItemType& it = Item::items[id];
    if (it.weaponType == WEAPON_AMMO) {
        Item* mainWeaponItem = player->getWeapon(true);
        const Weapon* mainWeapon = g_weapons->getWeapon(mainWeaponItem);
        if (mainWeapon) {
            damageModifier = mainWeapon->playerWeaponCheck(player, target, mainWeaponItem->getShootRange());
        } else {
            damageModifier = playerWeaponCheck(player, target, mainWeaponItem->getShootRange());
        }
    } else {
        damageModifier = playerWeaponCheck(player, target, item->getShootRange());
    }

    if (damageModifier == 0) {
        return false;
    }
   
    Weapon::internalUseWeapon(player, item, destTile);
    return true;
}

DONE

 

[Gabe120]

Works nice!
Thanks

 

[Itutorial]

TFS 1.3 btw

 

[Lessaire]

I can't quite put my finger on it, but something tells me this is a bad idea...

Yes, looking at the code, this is a very very bad idea.
bool WeaponDistance::useWeapon(Player* player, Item* item, Creature* target) const
is utterly butchered by this. It's a massive function that can't be replicated in so few lines, and is now missing features.

If this is about the pally potion thing that Nugo posted on recently, it would be better to track down the actual cause. I'm pretty sure it's because distance weapons are either triggering or checking the item exhaust instead of the combat exhaust. I just haven't had time to dig in. All I know is this is not it chief.

 

[Gabe120]

I can't quite put my finger on it, but something tells me this is a bad idea...

Yes, looking at the code, this is a very very bad idea.
bool WeaponDistance::useWeapon(Player* player, Item* item, Creature* target) const
is utterly butchered by this. It's a massive function that can't be replicated in so few lines, and is now missing features.

If this is about the pally potion thing that Nugo posted on recently, it would be better to track down the actual cause. I'm pretty sure it's because distance weapons are either triggering or checking the item exhaust instead of the combat exhaust. I just haven't had time to dig in. All I know is this is not it chief.

Hey bro,
your suggestion is not a good idea.

-- Item Usage
-- Do not touch here
-- Avoid use of WIPE program to crash the distro

change the - Item Usage
timeBetweenActions = 0
timeBetweenExActions = 0

It can open loopholes to crash the server..
-

And it doesn't work in tfs 1.3

Fix #1319 (#2109) · otland/forgottenserver@24a27e1

* Fix #1319 This should fix the issues with attackspeed under 1000. * Ops... * Adding classic attack speed When this config is true, all the attacks are going to have constant speed no...

github.com

 

[Itutorial]

I can't quite put my finger on it, but something tells me this is a bad idea...

Yes, looking at the code, this is a very very bad idea.
bool WeaponDistance::useWeapon(Player* player, Item* item, Creature* target) const
is utterly butchered by this. It's a massive function that can't be replicated in so few lines, and is now missing features.

If this is about the pally potion thing that Nugo posted on recently, it would be better to track down the actual cause. I'm pretty sure it's because distance weapons are either triggering or checking the item exhaust instead of the combat exhaust. I just haven't had time to dig in. All I know is this is not it chief.

The first code change removes the delay in manapot...

The second code block only removes missing chance. There is nothing taken out but that. It should be fine.

 

[Lessaire]

your suggestion is not a good idea.

My what? I don't recall advising any course of action in that post. Only stating that OP is gutting massive chunks of a function which has nothing to do with stated intention of the thread title. The thread I linked was merely an example of the targeted "problem"

I guess I missed the part where OP did in fact specify the 2nd part accomplished something else, so my bad on that.

 

[Gabe120]

My what? I don't recall advising any course of action in that post. Only stating that OP is gutting massive chunks of a function which has nothing to do with stated intention of the thread title. The thread I linked was merely an example of the targeted "problem"

I guess I missed the part where OP did in fact specify the 2nd part accomplished something else, so my bad on that.

Sorry for my confusion bro ... I just changed the first part in player.cpp to fix the pally exhaust, and it worked. I did not apply the second part.

 

[Itutorial]

The second part is for Paladins missing with their spear/bows.

 

[SlayingWorld]

I can't quite put my finger on it, but something tells me this is a bad idea...

Yes, looking at the code, this is a very very bad idea.
bool WeaponDistance::useWeapon(Player* player, Item* item, Creature* target) const
is utterly butchered by this. It's a massive function that can't be replicated in so few lines, and is now missing features.

If this is about the pally potion thing that Nugo posted on recently, it would be better to track down the actual cause. I'm pretty sure it's because distance weapons are either triggering or checking the item exhaust instead of the combat exhaust. I just haven't had time to dig in. All I know is this is not it chief.

Any update on this bro?

 

[Codinablack]

fixed stopped walking onuseitem/itemex by Codinablack · Pull Request #3474 · otland/forgottenserver

Pull Request Prelude [x ] I have followed proper The Forgotten Server code styling. [ x] I have read and understood the contribution guidelines before making this PR. [ x] I am aware that this P...

github.com

That should fix the problem, if anyone here tests and it works good for you, please say so on the PR at github, posted above