getMonsterInfo(name)

[dchampag]

Hey everyone,

I am returning from a long time ago and I am trying to stabilize my current project and balance the server before migrating to the latest TFS, until then I need to make this lua function pull the value of experience and not return true or false and I am using TFS 0.4

I'm not sure what values to change in luascript.cpp and monster.cpp to make this return a value when using getMonsterInfo(name).experience
the only values that return other than true and false are the values classed as strValue using std::string

luascript.cpp

    lua_newtable(L);
    setField(L, "name", mType->name.c_str());
    setField(L, "description", mType->nameDescription.c_str());
    setField(L, "experience", mType->experience);
    setField(L, "health", mType->health);
    setField(L, "healthMax", mType->healthMax);
    setField(L, "manaCost", mType->manaCost);
    setField(L, "defense", mType->defense);
    setField(L, "armor", mType->armor);
    setField(L, "baseSpeed", mType->baseSpeed);
    setField(L, "lookCorpse", mType->lookCorpse);
    setField(L, "race", mType->race);
    setField(L, "skull", mType->skull);
    setField(L, "partyShield", mType->partyShield);
    setField(L, "guildEmblem", mType->guildEmblem);
    setFieldBool(L, "summonable", mType->isSummonable);
    setFieldBool(L, "illusionable", mType->isIllusionable);
    setFieldBool(L, "convinceable", mType->isConvinceable);
    setFieldBool(L, "attackable", mType->isAttackable);
    setFieldBool(L, "hostile", mType->isHostile);

monster.cpp

int32_t intValue;
    std::string strValue;
    if(readXMLString(root, "name", strValue))
        mType->name = strValue;
    else
        monsterLoad = false;

    if(readXMLString(root, "nameDescription", strValue))
        mType->nameDescription = strValue;
    else
    {
        mType->nameDescription = "a " + mType->name;
        toLowerCaseString(mType->nameDescription);
    }

    if(readXMLString(root, "race", strValue))
    {
        std::string tmpStrValue = asLowerCaseString(strValue);
        if(tmpStrValue == "venom" || atoi(strValue.c_str()) == 1)
            mType->race = RACE_VENOM;
        else if(tmpStrValue == "blood" || atoi(strValue.c_str()) == 2)
            mType->race = RACE_BLOOD;
        else if(tmpStrValue == "undead" || atoi(strValue.c_str()) == 3)
            mType->race = RACE_UNDEAD;
        else if(tmpStrValue == "fire" || atoi(strValue.c_str()) == 4)
            mType->race = RACE_FIRE;
        else if(tmpStrValue == "energy" || atoi(strValue.c_str()) == 5)
            mType->race = RACE_ENERGY;
        else
            SHOW_XML_WARNING("Unknown race type " << strValue);
    }

    if(readXMLInteger(root, "experience", intValue))
        mType->experience = intValue;

    if(readXMLInteger(root, "speed", intValue))
        mType->baseSpeed = intValue;

    if(readXMLInteger(root, "manacost", intValue))
        mType->manaCost = intValue;

    if(readXMLString(root, "skull", strValue))
        mType->skull = getSkulls(strValue);

    if(readXMLString(root, "shield", strValue))
        mType->partyShield = getShields(strValue);

    if(readXMLString(root, "emblem", strValue))
        mType->guildEmblem = getEmblems(strValue);

I was going to change the values like skull, but I was not sure if that would create an issue for the server retrieving the experience value for the equation used to give players experience. if this is the case, would it be okay for me to add another line for reading the xmlstring and adding something else for experience value returned in lua?

Thank you,

 

[pelek2002]

look at my script

function onSay(cid, words, param, channel)
pexp = getPlayerExperience(cid)
lexp = getExperienceForLevel(getPlayerLevel(cid)+1)
needexp = (lexp - pexp)
mons = getMonsterInfo(param).experience   
mat =  math.floor(needexp / mons)
doPlayerSendTextMessage(cid, 20, "you have to kill about "..mat.." "..param.." to get level up.")
return true
end

 

[dchampag]

look at my script

function onSay(cid, words, param, channel)
pexp = getPlayerExperience(cid)
lexp = getExperienceForLevel(getPlayerLevel(cid)+1)
needexp = (lexp - pexp)
mons = getMonsterInfo(param).experience  
mat =  math.floor(needexp / mons)
doPlayerSendTextMessage(cid, 20, "you have to kill about "..mat.." "..param.." to get level up.")
return true
end

My script serves a different purpose, but it does look like according to your script I was using it the same way, the issue I’m having is, getMonsterInfo(param).experience is returning 0 if 0 or 1 if 10,000, 25, 400000, no matter what I place in the script, it returns a 1

 

[dchampag]

BUMP

 

[Acubens]

But what you trying to do on your script? you need share more info or show part of the LUA code.

 

[dchampag]

But what you trying to do on your script? you need share more info or show part of the LUA code.

I deleted the script and made something else because it wasn’t working. I made something else temporarily for now to substitute.

But example

if (getPlayerLevel(cid)/10) >= getMonsterInfo(target).experience then
   print(getMonsterInfo(target).experience
   doPlayerSetExperienceRate(cid, 0)
else
   doPlayerSetExperienceRate(cid, getCreatureStorage(cid, rateStoredExp))
end

That will go right to the else statement. Even though the monsters exp is 100 and the players level is 100

if (getPlayerLevel(cid)/10) >= getMonsterInfo(target).experience then
   doPlayerSetExperienceRate(cid, 0)
else
   print(getMonsterInfo(target).experience
   doPlayerSetExperienceRate(cid, getCreatureStorage(cid, rateStoredExp))
end

If I move print to else statement it just prints the value 1

 

[Acubens]

You need pass monster name (string) to the function getMonsterInfo.

Example:

local targetName = getCreatureName(target)

if (getPlayerLevel(cid) / 10) >= getMonsterInfo(targetName).experience then
    print(getMonsterInfo(targetName).experience)
    doPlayerSetExperienceRate(cid, 0)
else
    doPlayerSetExperienceRate(cid, getCreatureStorage(cid, rateStoredExp))
end

 

[pelek2002]

u have missing ")" here
print(getMonsterInfo(target).experience)

 

[dchampag]

u have missing ")" here
print(getMonsterInfo(target).experience)

thank you, that was an accident, I just typed it up on my phone, I promise that isn’t the issue, that would give an error, there is no error, the script executes, it’s just not retrieving the value of the experience.

 

[pelek2002]

try print info about Rat
print(getMonsterInfo("Rat").experience)

 

[dchampag]

try print info about Rat
print(getMonsterInfo("Rat").experience)

local monExp = getMonsterInfo(getCreatureName(target)).experience

print(getCreatureName(target))
print(monExp)

Rat
1

 

[dchampag]

This was a source issue, in luascript.cpp

If anyone runs into this check the luascript function for getMonsterInfo and ensure that it’s set to retrieve the value and not true or false