• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!
  • New resources must be posted under Resources tab. A discussion thread will be created automatically, you can't open threads manually anymore.

Guild system problem

W

Wodzzu

New Member
Joined
Sep 10, 2012
Messages
6
Reaction score
0
Hi guys. i have little problem. I use Caste War Event from :
http://otland.net/f82/talkactions-globalevents-lib-monsters-castle-war-system-maps-111115/

But i have a lot of problems. I change a lot of functions, and now, while castle event is started, it will end in one sec and its effect:
Code: 
21:54 [ Castle Event Fight! ]
Event has been started. Kill Castle King !!!
21:54 [ Castle Event End! ]
> Statistics 
Support:0 dmg
WINNER:-1

And next problem is: king dont resp...

102-castle.lua
Code: 
local castleConfig = {
	days = {0,1,2,3,4,5,6},
	time_1 = 10*60*1000, -- time from start event to fight
	time_2 = 30*60*1000, -- time from fight to end event
	guildOwnStorage = 17000,
	attackersStorage = 17002,
	enabledStorage = 17006,
	endedStorage = 17007,
	leaderLevel = 200,
	membersNeeded = 0,
	monster = "Castle King",
	monsterSpawn = {x = 58, y = 44, z = 10},
	startAttackers = {
		[1] = {x = 33, y = 58, z = 13},
		[2] = {x = 80, y = 71, z = 13},
		[3] = {x = 78, y = 33, z = 13}
	},
	gates = {
		[1] = {pos = {x = 40, y = 48, z = 13}, itemid = 9533},
		[2] = {pos = {x = 40, y = 49, z = 13}, itemid = 9533},
		
		[3] = {pos = {x = 73, y = 66, z = 13}, itemid = 9485},
		[4] = {pos = {x = 74, y = 66, z = 13}, itemid = 9485},
		
		[5] = {pos = {x = 75, y = 66, z = 13}, itemid = 9485},
		[6] = {pos = {x = 86, y = 69, z = 13}, itemid = 9533},
		[7] = {pos = {x = 86, y = 70, z = 13}, itemid = 9533},
		
		-- new 
		[8] = {pos = {x = 86, y = 71, z = 13}, itemid = 9533},
		[9] = {pos = {x = 44, y = 55, z = 13}, itemid = 9533},
		[10] = {pos = {x = 44, y = 56, z = 13}, itemid = 9533},
		
		[11] = {pos = {x = 78, y = 39, z = 13}, itemid = 9486},	
		
		[12] = {pos = {x = 79, y = 39, z = 13}, itemid = 9486},
		[13] = {pos = {x = 80, y = 39, z = 13}, itemid = 9486},
		
		[14] = {pos = {x = 73, y = 36, z = 13}, itemid = 9486},
		[15] = {pos = {x = 74, y = 36, z = 13}, itemid = 9486},
		[16] = {pos = {x = 75, y = 36, z = 13}, itemid = 9486},
	

		
	},
}
CASTLE_DAYS = {0,1,2,3,4,5,6}

function getCastleConfig(value)
	if (value ~= nil) then
		return castleConfig[value] or false 
	else
		return false
	end
end

function removeNotKilledKing(cid)
	if isMonster(cid) and getCreatureName(cid) == castleConfig.monster then
		doRemoveCreature(cid)
	end
	return true
end


-- it sux but don`t have idea how to make it better, attackers Index
function Castle_getGuildPos(guildId)
	local attackers = Castle_getAttackers()
	for i,value in ipairs(attackers) do
		if (tonumber(guildId) == tonumber(value)) then
			ret = i
		end
	end
	return ret
end

function Castle_enableSaving()
	doBroadcastMessage("[ Castle Event Enabled! ]\n\nIf you're a guild leader and you have at least ".. castleConfig.membersNeeded .." members you can sign in your guild by saying !castle in default channel.", MESSAGE_INFO_DESCR)
	setGlobalStorageValue(castleConfig.enabledStorage, 1)
	--setGlobalStorageValue(castleConfig.endedStorage, 0)
	Castle_cleanUp()
	addEvent(Castle_startEvent, castleConfig.time_1)
	return true
end

function Castle_getAttackers()
	local ret = {}
	local query = string.explode(getGlobalStorageValue(castleConfig.attackersStorage), ",")
	for _,value in ipairs(query) do
		if isNumber(value) then
			table.insert(ret, value)
		end
	end
	return ret
end

function Castle_startEvent()
	setGlobalStorageValue(castleConfig.enabledStorage, 0)
	setGlobalStorageValue(castleConfig.endedStorage, 0)
	if(#Castle_getAttackers() == 0) then
		doBroadcastMessage("[ Castle Event Failed! ]\n\nWe have not attackers!", MESSAGE_INFO_DESCR)
		return true
	end
	doBroadcastMessage("[ Castle Event Fight! ]\n\nEvent has been started. Kill Castle King !!!", MESSAGE_INFO_DESCR)
	local monster = doSummonCreature(castleConfig.monster, castleConfig.monsterSpawn)
	for _, gate in pairs(castleConfig.gates) do
		doRemoveItem(getTileItemById(gate.pos, gate.itemid).uid)
	end
	addEvent(Castle_endEvent, castleConfig.time_2, false)
	addEvent(removeNotKilledKing, castleConfig.time_2, monster)
	return true
end

function Castle_endEvent(killed, damages)
	local playersOnline = getPlayersOnline()
	local dmgCount = 0
	local message = ""
	local winner = 0
	
	if (getGlobalStorageValue(castleConfig.endedStorage) ~= 1) then
		if (killed) then
			for _,value in ipairs(Castle_getAttackers()) do
				message = message.."\n"..getGuildName(value)..":"..damages[Castle_getGuildPos(value)].." dmg"
				if damages[Castle_getGuildPos(value)] > dmgCount then
					winner = value
					dmgCount = damages[Castle_getGuildPos(value)]
				end
			end
			doBroadcastMessage("[ Castle Event End! ]\n\n> Statistics " .. message .."\nWINNER:"..getGuildName(winner), MESSAGE_INFO_DESCR)
			
			local attackers = Castle_getAttackers()
			table.insert(attackers, getGlobalStorageValue(castleConfig.guildOwnStorage))
			for _, pid in ipairs(playersOnline) do
				if ((isInArray(attackers, getPlayerGuildId(pid)) or getGlobalStorageValue(castleConfig.guildOwnStorage) == getPlayerGuildId(pid)) and not(tonumber(getPlayerGuildId(pid)) == tonumber(winner))) then
					doRemoveCondition(pid, CONDITION_INFIGHT)
					doTeleportThing(pid, getTownTemplePosition(getPlayerTown(pid)))
				end
			end
			setGlobalStorageValue(castleConfig.guildOwnStorage, winner)
		else
			doBroadcastMessage("[ Castle Event End! ]\n\n> Castle has been saved by owner.", MESSAGE_INFO_DESCR)
		end
		setGlobalStorageValue(castleConfig.endedStorage, 1)
	end
	Castle_cleanUp()
	return true
end


function Castle_cleanUp()
	setGlobalStorageValue(castleConfig.attackersStorage, ",")
	return true
end

function Castle_getGuildMembers(guildId)
	local playersOnline = getPlayersOnline()
	local members = {}
	for _, pid in ipairs(playersOnline) do
		if (getPlayerGuildId(pid) == guildId) then
			table.insert(members, pid)
		end
	end
	return members
end


function Castle_trySave(cid)
	if not(getPlayerGuildLevel(cid) == GUILDLEVEL_LEADER) then
		doPlayerSendCancel(cid, "Sorry, but you have to be a leader of guild.")
		return true
	end

	if (getGlobalStorageValue(castleConfig.enabledStorage) ~= 1) then
		doPlayerSendCancel(cid, "Sorry, but it's not time yet.")
		return true
	end

	if (getPlayerLevel(cid) < castleConfig.leaderLevel) then
		doPlayerSendCancel(cid, "Sorry, but your level is too low.")
		return true
	end

	local players = Castle_getGuildMembers(getPlayerGuildId(cid))
	if (#players == 1) then
		doPlayerSendCancel(cid, "Sorry, but you haven't any online members in guild.")
		return true
	end

	if (#players < castleConfig.membersNeeded) then
		doPlayerSendCancel(cid, "Sorry, but you need at least ".. castleConfig.membersNeeded .." guild members online.")
		return true
	end
	if (tonumber(getGlobalStorageValue(castleConfig.guildOwnStorage)) == tonumber(getPlayerGuildId(cid))) then
		doPlayerSendCancel(cid, "Your guild should protect Castle, not attack.")
		return true
	end

	if (#Castle_getAttackers() == 3) then
		doPlayerSendCancel(cid, "Sorry, we have already 3 attacking guilds.")
		return true
	end
	if (isInArray(Castle_getAttackers(), getPlayerGuildId(cid))) then
		doPlayerSendCancel(cid, "Be patient, war will start in a few minutes.")
		return true
	end

	setGlobalStorageValue(castleConfig.attackersStorage, getGlobalStorageValue(castleConfig.attackersStorage)..getPlayerGuildId(cid)..",")
	doBroadcastMessage("[ Castle Event Info ]\n\nGuild ".. getPlayerGuildName(cid) .." will fight for Castle.\nAttackers: ".. #Castle_getAttackers() .." / 3", MESSAGE_INFO_DESCR)

	for i, pid in ipairs(getPlayersOnline()) do
		if (isInArray(getPlayerGuildId(cid), getPlayerGuildId(pid))) then
			doTeleportThing(pid, castleConfig.startAttackers[#Castle_getAttackers()])
		end
	end
	return true
end

function getGuildName(id)
local Info = db.getResult("SELECT `name` FROM `guilds` WHERE `id` = " .. id .. "")
if Info:getID() ~= -1 then
local Name = Info:getDataString("name")
Info:free()
return Name
end
return -1
end

castle_kill.lua
Code: 
function onDeath(cid, corpse, killer)
	if (getCreatureName(cid) == getCastleConfig("monster")) then
		Castle_endEvent(true, damages)
	end
	-- cleanup
	damages = {0,0,0}
	return true
end

No errors in console.

Please help me with it <3

P.S. Sorry for my bad english.
 
Lua: 
function getGuildName(id)
local Info = db.getResult("SELECT `name` FROM `guilds` WHERE `id` = "..id)
return Info:getID() ~= -1 and Info:getDataString("name") or false
end
 
Last edited:
Yeah i need it. But i have now a bit problem. while event started, king doesn't resp, and i have this error:
Code: 
[03/10/2012 19:47:40] Event has been started. Kill Tiberia King !!!".

[03/10/2012 19:47:40] [Error - CreatureScript Interface] 
[03/10/2012 19:47:40] data/creaturescripts/scripts/castle_kill.lua:onDeath
[03/10/2012 19:47:40] Description: 
[03/10/2012 19:47:40] data/lib/102-castle.lua:130: attempt to concatenate a boolean value
[03/10/2012 19:47:40] stack traceback:
[03/10/2012 19:47:40] 	data/lib/102-castle.lua:130: in function 'Castle_endEvent'
[03/10/2012 19:47:40] 	data/creaturescripts/scripts/castle_kill.lua:3: in function <data/creaturescripts/scripts/castle_kill.lua:1>

- - - Updated - - -

@refresh

Can anyone help me>?
 

Similar threads

Marko999x
[TFS 1.x] Avoid people lagging your server by buying alot of items from NPC that drops it on ground
Replies
0
Views
235
Marko999x
Marko999x
Liikuid
[TFS 1.X][Canary/OTBR] 'Fix' books without text on Quest System
Replies
0
Views
501
Liikuid
Liikuid
A
  • Question
Lua Convert Script TFS 0.4 to TFS 1.5 downgrade
Replies
7
Views
638
stevanmayan
S
thokito
  • Question
real castle error
Replies
0
Views
152
thokito
thokito
E
Uncover Map Talkaction
Replies
2
Views
289
Unknown Soldier
Unknown Soldier
J
  • Question
FireStorm Event
Replies
0
Views
381
jareczekjsp
J
darcioantonio
  • Question
Create random item on the map
Replies
2
Views
290
darcioantonio
darcioantonio
J
  • Question
Autoloot problem
Replies
4
Views
408
jareczekjsp
J
T
  • Question
RevScripts event problem revscript castlewar
Replies
0
Views
520
Thiagobs
T
G
  • Question
RevScripts Update Battle Event Script
Replies
5
Views
715
Gaber Zen
G
Back
Top