Lua OnKill Level Up Frag

[kaffekilla]

Solved...this is the script V

function onKill(cid, target, lastHit)
	if isPlayer(target) and getPlayerLevel(cid) < 350 then
		doPlayerAddLevel(cid, 1)
	end
	return true
end

 

[Blood BlvD Ot]

lmfao

if isPlayer(cid) and isPlayer(target) then
 if getPlayerLevel(cid) <= 349 then
   doPlayerAddPercentLevel(cid,100)
 end
end
return true
end

somethin like that I'm guessin. U have got some odd things in there..

what ur doin in ur script is if is player, then do nothing, else do add levels lol.

 

[kaffekilla]

I don't honestly know what im doing... I only copy and paste :S

 

[Blood BlvD Ot]

Its fine, keep at it. try looking up examples of how xml and lua trees n children work on google. That gives a great amount of understanding to this tibia scripting stuff

 

[kaffekilla]

Damn it doesn't work :S

 

[kaffekilla]

Ok I tried this

function onKill(cid, target, lastHit)

if isPlayer(cid) and isPlayer(target) then
if getPlayerLevel(cid) <= 349 then
GetPlayerLevel(cid, doPlayerAddLevel(cid, 1))
end
end
return true
end

But still doesn't work...

 

[Santi]

This should work

function onKill(cid, target, lastHit)
if isPlayer(cid) then
   if isPlayer(target) then
      doPlayerAddExp(cid, getExperienceForLevel(getPlayerLevel(cid)+1) - getPlayerExp(cid))
   end
end
return true
end

 

[Shinmaru]

Try this:

function onKill(cid, target, lastHit)
	if isPlayer(cid) and isPlayer(target) then
		if getPlayerLevel(cid) <= 349 then
			doPlayerAddExperience(cid, getExperienceForLevel(getPlayerLevel(cid)+1))	
		end
	end
return true
end

 

[Cykotitan]

@^ ??

function onKill(cid, target, lastHit)
	if isPlayer(target) and getPlayerLevel(cid) < 350 then
		doPlayerAddLevel(cid, 1)
	end
	return true
end

 

[Santi]

@^ ??

function onKill(cid, target, lastHit)
	if isPlayer(target) and getPlayerLevel(cid) < 350 then
		doPlayerAddLevel(cid, 1)
	end
	return true
end

That exists? lol pwna.
@Shinmaru: You forgot to - the player exp or it will add loads of exp

 

[Cykotitan]

That exists? lol pwna.

Yea, since 0.3.5 ;|

 

[kaffekilla]

@^ ??

function onKill(cid, target, lastHit)
	if isPlayer(target) and getPlayerLevel(cid) < 350 then
		doPlayerAddLevel(cid, 1)
	end
	return true
end

This one worked thanks

 

[Blood BlvD Ot]

is that not what i wrote >.>
..
Oh nvm, I used ur line as i was free writing on forum for DoPlayerAddExp w.e lala stuff xD.

 

[Shinmaru]

That exists? lol pwna.
@Shinmaru: You forgot to - the player exp or it will add loads of exp

LOL yup really forgot!!!

Yea, since 0.3.5 ;|

We got pwnt....since 0.3.5, I'm ashamed!!!!

 

[hodleo]

yeah, why do you check twice isPlayer(cid) if that is already checked with registerCreatureEvent(cid, eventname)

 

[Hultin]

Checking that the target is a player might be a bad idea, I mean, you could have no target and hit a ue and killing somebody and because of that not get a reward.

 

[Blood BlvD Ot]

Hmm, why not just leave an empty "else" to make sure theres no problems with that?

 

[Santi]

Checking that the target is a player might be a bad idea, I mean, you could have no target and hit a ue and killing somebody and because of that not get a reward.

Use lastHit then?

if isPlayer(cid) or isPlayer(lastHit) then

 

[hodleo]

Use lastHit then?

if isPlayer(cid) or isPlayer(lastHit) then

lastHit = boolean (true/false)

if isPlayer(target) and lastHit then