onKill tfs 1.2

[president vankk]

Hi folks! Actually I'm having some problems with the script below, it just does not works, the main idea of this script is if you kill a Morgaroth or Ghazbaran then you'll get a achievement.

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if not targetMonster then
        return true
    end
  
    if targetMonster:getName():lower() ~= "morgaroth" or targetMonster:getName():lower() ~= "ghazbaran" then
        return true
    end
  
    local player = creature:getPlayer()
    player:addAchievement('Slayer')
    return true
end

It is already registred in login.lua/monsters files/creaturescripts.xml. What is the problem in here?
Already tried to print everything but just does not works.

Thanks.

 

[silveralol]

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if not targetMonster then
        return true
    end
    if targetMonster:getName():lower() ~= "morgaroth" or targetMonster:getName():lower() ~= "ghazbaran" then
        return true
    end
    for pid, _ in pairs(targetMonster:getDamageMap()) do
        local attackerPlayer = Player(pid)
        if attackerPlayer then
            attackerPlayer:addAchievement('Slayer')
        end
    end
    return true
end

the problem is: you don't declare the player as killer, or that he did damage in the monster

 

[Codex NG]

-- so you can add more monsters to the list
local monsters = {"morgaroth", "ghazbaran"}

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if not targetMonster then
        return true
    end
    -- so you don't need a bunch of or's
    if not isInArray( monsters, targetMonster:getName():lower()) then
        return true
    end
   
    for pid, _ in pairs(targetMonster:getDamageMap()) do
        local attackerPlayer = Player(pid)
        if attackerPlayer then
            attackerPlayer:addAchievement('Slayer')
        end
    end
    return true
end