Lua onKill tfs 1.2

[Lais Prad]

How to put for all players win the storage when monster die?
The script give storage for only one player:

function onKill(cid, target, damage, flags, corpse)
    local player = Player(cid)
  
    if(isMonster(target)) then
        if(string.lower(getCreatureName(target)) == "rat") then
            if player:getStorageValue(2204171609) < 1 then
            player:setStorageValue(2204171609, 1)
            end
        end
    end
    return true
end

 

[Frija]

function onDeath(creature, corpse, killer, mostDamageKiller, unjustified, mostDamageUnjustified)
 
    for attackerUid, damage in pairs(creature:getDamageMap()) do
        local player = Player(attackerUid)
        if player then
            if creature:getName():lower() == "rat" and player:getStorageValue(2204171609) < 1 then
                player:setStorageValue(2204171609, 1)
            end
        end
    end
 
    return true
end

or this if you want to keep it onKill event:

function onKill(cid, target, damage, flags, corpse)
    if(isMonster(target)) then
        if(string.lower(getCreatureName(target)) == "rat") then
            for attackerUid, damage in pairs(target:getDamageMap()) do
                local player = Player(attackerUid)
                if player and player:getStorageValue(2204171609) < 1 then
                    player:setStorageValue(2204171609, 1)
                end
            end
        end
    end
    return true
end

 

[Lais Prad]

function onDeath(creature, corpse, killer, mostDamageKiller, unjustified, mostDamageUnjustified)
  
    for attackerUid, damage in pairs(creature:getDamageMap()) do
        local player = Player(attackerUid)
        if player then
            if player:getStorageValue(2204171609) < 1 then
                player:setStorageValue(2204171609, 1)
            end
        end
    end
  
    return true
end

Hello, but how verify the monster name, and attackerUid is tfs 1.2? thanks

 

[Frija]

edited the post above

damageMap exists in 1.2 and attackerUid has nothing to do with TFS version, just how I named the key

 

[demon088]

function onDeath(creature, corpse, killer, mostDamageKiller, unjustified, mostDamageUnjustified)

    for attackerUid, damage in pairs(creature:getDamageMap()) do
        local player = Player(attackerUid)
        if player then
            if creature:getName():lower() == "rat" and player:getStorageValue(2204171609) < 1 then
                player:setStorageValue(2204171609, 1)
            end
        end
    end

    return true
end

or this if you want to keep it onKill event:

function onKill(cid, target, damage, flags, corpse)
    if(isMonster(target)) then
        if(string.lower(getCreatureName(target)) == "rat") then
            for attackerUid, damage in pairs(target:getDamageMap()) do
                local player = Player(attackerUid)
                if player and player:getStorageValue(2204171609) < 1 then
                    player:setStorageValue(2204171609, 1)
                end
            end
        end
    end
    return true
end

-I'm having errors, I was trying to add a meesage showing the ammount of creatures that you have killed-
EDIT: I fixed the script and it is working!

function onDeath(creature, corpse, killer, mostDamageKiller, unjustified, mostDamageUnjustified)

    for attackerUid, damage in pairs(creature:getDamageMap()) do
        local player = Player(attackerUid)
        if player then
            if creature:getName():lower() == "rat" and player:getStorageValue(2204171609) < 1 then
                player:setStorageValue(2204171609, 1)
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You have slain your first rat.")
        else
                player:setStorageValue(2204171609, player:getStorageValue(2204171609) + 1)
        player:sendTextMessage(MESSAGE_INFO_DESCR, "You have slain " .. player:getStorageValue(2204171609) .. " rats.")
            end
        end
    end

    return true
end

This script is showing the next messages whenever you kill such creature:
16:58 You have slain your first rat.
16:58 You have slain 4 rats.

 

[kubernik]

local kills = player:getStorageValue(2204171609)
        if player then

Legit. xD

 

[demon088]

local kills = player:getStorageValue(2204171609)
        if player then

Legit. xD

I have already fixed it. Sorry for posting such dumb script xd