onThink problems

[bomba]

Why sometimes works and sometimes does not?

function onThink(cid, interval)
    if last_interval == nil then
      last_interval = os.clock()
    end
    if (os.clock() - last_interval) > 2 then        --        execute every 2 sec
        if getPlayerStorageValue(cid, eSkill.charm) >= 1 then
          doCreatureAddHealth(cid, getPlayerStorageValue(cid, eSkill.charm))
          doCreatureAddMana(cid, getPlayerStorageValue(cid, eSkill.charm))
        end       
      last_interval= os.clock()
          return true
    end
  return false
end

I want to to work every 2 seconds.

 

[bybbzan]

This should be moved to support board.

 

[bomba]

up

 

[LegerianOT]

Try this:

function onThink(cid, interval)
    if time_check <= 0 then
        time_check = os.time()
    end
    if time_check <= os.time() then
        if getPlayerStorageValue(cid, eSkill.charm) >= 1 then
          doCreatureAddHealth(cid, getPlayerStorageValue(cid, eSkill.charm))
          doCreatureAddMana(cid, getPlayerStorageValue(cid, eSkill.charm))
        end     
        time_check = os.time()+2
    end
return true
end

 

[Colors]

Can I ask why do you use/need internal time checks instead of the interval on the xml?

 

[LegerianOT]

Can I ask why do you use/need internal time checks instead of the interval on the xml?

it's an onThink function, so it's most likely in an npc script..

and this "doCreatureAddHealth(cid, getPlayerStorageValue(cid, eSkill.charm))" tells me something might happen with your life while chatting with an npc or something..
What do we know.. we should embrace custom stuffs.

Beside, if this would be something like a globalevent.. I can tell you not all servers have globalevents, and not everyone is skilled enough to know how to add that.
NPC's have for a long time been the easy way of making globalevents

I think we should give the support on what they ask for, not question their way of handling it.
The day this guy ask how to add globalevents or similar on C++ level, I'd be happy to help him as well

or do you disagree on what I had to say?

 

[Colors]

Yeah I know but with more info is easier to help...

 

[bomba]

interval in .xml? how?

 

[LegerianOT]

Yeah I know but with more info is easier to help...

I agree, but sometimes they are so new to the stuffs, they they themselves can't say what's the problem.. they have no clue what to say..

But I must say people who want help, and try to hide something at same time are very annoying.
etc modifying the scripts they post here they want help with, just to hide something.
and they give an error.. that's invalid because the error in the script switch line because something was removed

 

[LegerianOT]

interval in .xml? how?

you probably have an globalevent in YOUR_OT/data/globalevents/globalevent.xml
but yeah, if you told us what this script is meant to do, we'll be able to help you better =)

 

[Colors]

interval in .xml? how?

Globalevents.xml
<globalevent name="name" interval="2000" script="scriptname.lua"/> (1.0)
<globalevent name="name" interval="2000" event="script" value="scriptname.lua"/> (0.3.x)

 

[bomba]

this is a creaturescript
onThink creaturescript...

Look the .xml file:

    <event type="think" name="Charm" event="script" value="charm.lua"/>

 

[LegerianOT]

this is a creaturescript
onThink creaturescript...

What's the point with the script?
could you give us a scenario where and why the script is read?

 

[Colors]

The script itself just add X health every 2 seconds, so you should use as globalevent (is incomplete tho).

 

[bomba]

function onThink(cid, interval)
    if time_check <= 0 then
        time_check = os.time()
    end
    if time_check <= os.time() then
        if getPlayerStorageValue(cid, eSkill.charm) >= 1 then
          doCreatureAddHealth(cid, getPlayerStorageValue(cid, eSkill.charm))
          doCreatureAddMana(cid, getPlayerStorageValue(cid, eSkill.charm))
        end   
        time_check = os.time()+2
    end
return true
end

 

[Colors]

Use it as a globalevent, is going to execute every 2 seconds (configurable on the xml)

Charm.lua

function onThink(cid, interval)
for _, cid in pairs(getPlayersOnline()) do
  if getPlayerStorageValue(cid, eSkill.charm) >= 1 then
    doCreatureAddHealth(cid, getPlayerStorageValue(cid, eSkill.charm))
    doCreatureAddMana(cid, getPlayerStorageValue(cid, eSkill.charm))
  end
end
return true
end

Globalevents.xml

<globalevent name="Charm" interval="2000" event="script" value="charm.lua"/>

Anyway, do you have the eSkill tables on the libs? Otherwise is gonna print a lot of errors.

 

[bomba]

Thx Colors, but I edited to:

function charmOn(cid)
    if isPlayer(cid) == true then
        if getPlayerStorageValue(cid, eSkill.charm) >= 1 then
          doCreatureAddHealth(cid, getPlayerStorageValue(cid, eSkill.charm))
          doCreatureAddMana(cid, getPlayerStorageValue(cid, eSkill.charm))
          addEvent(charmOn, 2*1000, cid)
        end
    end
  return true
end

function onLogin(cid)
    if getPlayerStorageValue(cid, eSkill.charm) >= 1 then
      addEvent(charmOn, 2*1000, cid)
        end  
  return true
end

 

[Colors]

I don't really know why are you still using creatureevents instead of globalevents, but anyway, is up to you