OTClient player:getVocation() return always 0

[roriscrave]

Hello, im using this code in otclient in modules/client/client.lua:

function onGameStart()
  local player = g_game.getLocalPlayer()
  if not player then return end
  g_window.setTitle(g_app.getName() .. " - " .. player:getName()) 
  print(player:getName(), player:getVocation())
end

and it print:
Roris 0
Player Test 0

It return 0, for all vocations, how can i correct it? In tfs getVocation() works fine, but in OTclient dont work.

 

[Fjorda]

you need to reference localPlayer, and you should make sure the module has connected and has called online first.

 

[roriscrave]

you need to reference localPlayer, and you should make sure the module has connected and has called online first.

edited the code, local player are referenced. the problem is when get vocation in client side

 

[Fjorda]

OTCv8 Github search for "getVocation()"

Should be fine. Are you sure the test players have a vocation? xDD

 

[roriscrave]

OTCv8 Github search for "getVocation()"

Should be fine. Are you sure the test players have a vocation? xDD

all my codes are equal that codes you sended.
Yes player have vocation, because if i put in server game (data/creaturescripts/login.lua)
print(player:getVocation()) -- its ok
the problem is in OTClient

Post automatically merged: Dec 15, 2023

HOW can i send player:getVocation in protocol?

 

[slaw]

The vocation is sent in protocolgameparse.cpp

void ProtocolGame::parsePlayerInfo(const InputMessagePtr& msg)
{
    bool premium = msg->getU8(); // premium
    if(g_game.getFeature(Otc::GamePremiumExpiration))
        msg->getU32(); // premium expiration used for premium advertisement
    int vocation = msg->getU8(); // vocation

    int spellCount = msg->getU16();
    std::vector<int> spells;
    for(int i=0;i<spellCount;++i)
        spells.push_back(msg->getU8()); // spell id

    m_localPlayer->setPremium(premium);
    m_localPlayer->setVocation(vocation); // here
    m_localPlayer->setSpells(spells);
}

So there may be some code missing in your sources that's responsible for that.

The other idea, might be, that you are checking to early. Maybe the vocation is not sent yet at the time you check it in function onGameStart()?

Try putting log in other functions, like in scripts, that executes later after the player has logged into game.

 

[oen432]

Its client id, not server id, check your vocations.xml, its not id but clientid that is sent.

 

[roriscrave]

Its client id, not server id, check your vocations.xml, its not id but clientid that is sent.

No problem with my vocations.xml, in tfs funcion getVocation() works fine. The problem is in cliente side.

<vocation id="1" name="Attacker" description="a attacker" needpremium="0" gaincap="10" gainhp="100" gainmana="50" gainhpticks="1" gainhpamount="20" gainmanaticks="1" gainmanaamount="10" manamultiplier="1.1" attackspeed="1200" basespeed="250" soulmax="200" gainsoulticks="60" corpseId="2813" fromvoc="1">
        <formula meleeDamage="1.0" distDamage="1.0" defense="1.0" armor="1.0"/>
        <skill id="0" multiplier="1.1" />
        <skill id="1" multiplier="1.1" />
        <skill id="2" multiplier="1.2" />
        <skill id="3" multiplier="1.2" />
        <skill id="4" multiplier="1.2" />
        <skill id="5" multiplier="1.1" />
        <skill id="6" multiplier="1.1" />
    </vocation>

 

[oen432]

No problem with my vocations.xml, in tfs funcion getVocation() works fine. The problem is in cliente side.

<vocation id="1" name="Attacker" description="a attacker" needpremium="0" gaincap="10" gainhp="100" gainmana="50" gainhpticks="1" gainhpamount="20" gainmanaticks="1" gainmanaamount="10" manamultiplier="1.1" attackspeed="1200" basespeed="250" soulmax="200" gainsoulticks="60" corpseId="2813" fromvoc="1">
        <formula meleeDamage="1.0" distDamage="1.0" defense="1.0" armor="1.0"/>
        <skill id="0" multiplier="1.1" />
        <skill id="1" multiplier="1.1" />
        <skill id="2" multiplier="1.2" />
        <skill id="3" multiplier="1.2" />
        <skill id="4" multiplier="1.2" />
        <skill id="5" multiplier="1.1" />
        <skill id="6" multiplier="1.1" />
    </vocation>

No... read my post again. Its not fine. You are missing clientId which defaults to 0.

 

[roriscrave]

No... read my post again. Its not fine. You are missing clientId which defaults to 0.

ahhh i want to add client ID, and what cliendid means?
i saw here each vocation have one id and one clientID, what is clientID?

forgottenserver/data/XML/vocations.xml at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[oen432]

what is clientID

Exactly what you want. It's the vocation id that is passed to the client, it's its only use.

 

[roriscrave]

so i can put clientid = id?

 

[oen432]

clientId="1", you have to put the number.

 

[roriscrave]

Changed to:

<vocation id="1" clientid="1"

and tried change to:

<vocation id="1" clientId="1"

And used this code in client side (OTClient):

    local player = g_game.getLocalPlayer()
    print(player:getName(), player:getVocation())

And it printed:
Roris 0
Player Test 0

Either player are in vocation ID = 1. How can i know it? I put in tfs (data/creaturescripts/login.lua)

print(player:getVocation():getId())

And it print 1.

The error persist

 

[oen432]

Idk what you did wrong but it is what it is. It takes client id and sends to the client, clientId in xml should work.

forgottenserver/src/protocolgame.cpp at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[roriscrave]

hmmm my source dont have this code, have only

void ProtocolGame::sendStats()

, maybe the problem are there.
you recommend add this two functions or only sendBasicData

sendClientFeatures
sendBasicData