Problem with custom items

[DonHagman]

Hello!

I am trying to make some custom rings, and I got some problems with it.

I've made Paladin Ring, Knight Ring and Mage ring, and the problem is that All vocations can use each ring (Knight can get magic level 16 etc).

This is my items.xml ->

Paladin Ring:

<item id="7697" article="a" name="Paladin Ring">
    <attribute key="description" value="+7 in Distance Fighting." />
    <attribute key="weight" value="80" />
    <attribute key="skillDist" value="7" />
    <attribute key="slotType" value="ring" />
  </item>

Knight Ring:

<item id="10510" article="a" name="Knight Ring">
    <attribute key="description" value="+7 in Sword, Axe, Club Fighting." />
    <attribute key="weight" value="40" />
    <attribute key="skillSword" value="7" />
    <attribute key="skillAxe" value="7" />
    <attribute key="skillClub" value="7" />
    <attribute key="slotType" value="ring" />
  </item>

Mage Ring:

<item id="10502" article="a" name="Mage Ring">
    <attribute key="description" value="+5 in Magic Level." />
    <attribute key="weight" value="3500" />
    <attribute key="magiclevelpoints" value="5" />
    <attribute key="slotType" value="ring" />
  </item>

Here is my movements.xml ->

Paladin Ring:

       <movevent type="Equip" itemid="7697" slot="ring" event="function" value="onEquipItem"/>
		<vocation id="3"/>
		<vocation id="7" showInDescription="0"/>

Knight Ring:

       <movevent type="Equip" itemid="10510" slot="ring" event="function" value="onEquipItem"/>
		<vocation id="4"/>
		<vocation id="8" showInDescription="0"/>

Mage Ring:

       <movevent type="Equip" itemid="10502" slot="ring" event="function" value="onEquipItem"/>
		<vocation id="1"/>
		<vocation id="5" showInDescription="0"/>
		<vocation id="2"/>
		<vocation id="6" showInDescription="0"/>

The vocation ID's is correct.

If anyone Please could help me out, I would really need that.


Ofc Rep++!
Your's
Hagman :ninja:

 

[Elaney]

if ur using 0.2 try do

<vocation name="Knight"/>
<vocation name="Elite Knight" showInDescription="0"/>

 

[DonHagman]

If you mean TFS, I use 0.4.

I though about that too, change it to the names.. But all the rest in my movements got ID's

 

[Elaney]

which rev are you using then?

 

[DonHagman]

BUMP, really need help with this!

Might be a really stupid question, but how do I see what rev I'm using?

 

[tosuxo]

in case you've missed it:
don't forget to do a deEquip too

 

[DonHagman]

I've done that, here is my Paladin Ring for example:

	<movevent type="Equip" itemid="7697" slot="ring" event="function" value="onEquipItem"/>
		<vocation id="3"/>
		<vocation id="7" showInDescription="0"/>
	<movevent type="DeEquip" itemid="7697" slot="ring" event="function" value="onDeEquipItem"/>

 

[tosuxo]

I've done that, here is my Paladin Ring for example:

	<movevent type="Equip" itemid="7697" slot="ring" event="function" value="onEquipItem"/>
		<vocation id="3"/>
		<vocation id="7" showInDescription="0"/>
	<movevent type="DeEquip" itemid="7697" slot="ring" event="function" value="onDeEquipItem"/>

ahhh cool, just making sure :3

have you tried without the "showInDescription" part? it may be that messing it up, i know it works for necklaces but not seen used in rings :S

 

[DonHagman]

Oh, no I havn't.. I will try that within an hour and give you the result

However, what is the ShowInDescription for?

 

[tosuxo]

Oh, no I havn't.. I will try that within an hour and give you the result

However, what is the ShowInDescription for?

in all honesty:
not a clue xD

I've always thought it was just for the item in items.xml

 

[Icy]

in all honesty:
not a clue xD

I've always thought it was just for the item in items.xml

It means that it wont say that it is usable by paladins & royal paladins.

 

[tosuxo]

It means that it wont say that it is usable by paladins & royal paladins.

ahhh cheers, dammit that means i learnt something new today xD

 

[DonHagman]

Alright, tested without it.. And still the same, A knight can use the Mage Ring to get ex. magic level 16..

Somebody Please, help me!

 

[tosuxo]

maybe instead of having the thing it does in items.xml make it a script for that ring?

if getVocation(cid) == 4 or 8 or w.e. then return False else add mag lvl (then if removing ring, remove the extra stuff)

 

[DonHagman]

Oh.. You mean an own script for each custom ring?

Can you tell me a little more how that script should look like?

 

[tosuxo]

Oh.. You mean an own script for each custom ring?

Can you tell me a little more how that script should look like?

something along the lines of doAddPlayerSkill(cid,magic,4) etc, way too tired to write it all out sorry xD
(obviously the remove/deEquipItem function is -4 lol)