Problem with "db.executeQuery"

[Icy]

function onAdvance(cid, skill, oldLevel, newLevel)
		if skill == SKILL__LEVEL then
			doSendMagicEffect(getCreaturePosition(cid), 45)
			db.executeQuery("UPDATE players SET skill_points = skill_points + 1 WHERE name = "..getPlayerName(cid)..";")
		end

	return true
end

Any idea why my script is not working? It calls everything correctly, I put the magic effect in for debugging purposes, so I know that the script executes for sure...

However, the database query seems to not be working. If I change it to

db.executeQuery("UPDATE players SET skill_points = skill_points + 1 WHERE online = 1")

it works; what am I doing wrong with the last segment of my code?



EDIT: Fixed code for any individual who feels like using or modifying my script for their own needs:

function onAdvance(cid, skill, oldLevel, newLevel)
		if skill == SKILL__LEVEL then
			db.executeQuery("UPDATE players SET skill_points = skill_points + 1 WHERE id = "..getPlayerGUID(cid)..";")
		end

	return true
end

 

[Fallen]

try with getPlayerGUID(cid)

 

[Icy]

try with getPlayerGUID(cid)

Well that worked, thanks mate.

Any idea why getPlayerName doesn't work though?

 

[Cykotitan]

Well that worked, thanks mate.

Any idea why getPlayerName doesn't work though?

You have to put it inside quotes for SQL to treat it as a string.

WHERE name = [B][COLOR="Red"]'[/COLOR][/B]"..getPlayerName(cid).."[B][COLOR="Red"]'[/COLOR][/B];")

 

[Icy]

You have to put it inside quotes for SQL to treat it as a string.

WHERE name = [B][COLOR="Red"]'[/COLOR][/B]"..getPlayerName(cid).."[B][COLOR="Red"]'[/COLOR][/B];")

Ah okay, thank you very much!

 

[Darkhaos]

WHERE name = " .. db.escapeString(getPlayerName(cid)) .. ";")