• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

TFS 1.X+ PZ TFS 1.5

Mateus Robeerto

Mateus Robeerto

Excellent OT User
Joined
Jun 5, 2016
Messages
1,337
Solutions
71
Reaction score
697
Location
ლ(ಠ益ಠლ)
Does anyone know how to solve this PZ issue? For example, when I try to enable experience sharing anywhere, it doesn't work. Only works in PZ. How do I remove this PZ restriction and allow experience sharing? Can someone help me?
I don't want to be in PZ to enable experience sharing.



I removed that part of PZ and tested it. However, you still need to be in PZ to enable experience sharing. I want to completely remove this restriction.

party.cpp
C++: 
SharedExpStatus_t Party::getMemberSharedExperienceStatus(const Player * player) const
{
    if (memberList.empty()) {
        return SHAREDEXP_EMPTYPARTY;
    }

    uint32_t highestLevel = leader->getLevel();
    for (Player* member : memberList) {
        if (member->getLevel() > highestLevel) {
            highestLevel = member->getLevel();
        }
    }

    uint32_t minLevel = static_cast<uint32_t>(std::ceil((static_cast<float>(highestLevel) * 2) / 3));
    if (player->getLevel() < minLevel) {
        return SHAREDEXP_LEVELDIFFTOOLARGE;
    }

    if (!Position::areInRange<30, 30, 1>(leader->getPosition(), player->getPosition())) {
        return SHAREDEXP_TOOFARAWAY;
    }

    if (!player->hasFlag(PlayerFlag_NotGainInFight)) {
        //check if the player has healed/attacked anything recently
        auto it = ticksMap.find(player->getID());
        if (it == ticksMap.end()) {
            return SHAREDEXP_MEMBERINACTIVE;
        }

        uint64_t timeDiff = OTSYS_TIME() - it->second;
        if (timeDiff > static_cast<uint64_t>(g_config.getNumber(ConfigManager::PZ_LOCKED))) {
            return SHAREDEXP_MEMBERINACTIVE;
        }
    }
    return SHAREDEXP_OK;
}
 
Last edited:
Sort by date Sort by votes
Mateus Robeerto said:
Does anyone know how to solve this PZ issue? For example, when I try to enable experience sharing anywhere, it doesn't work. Only works in PZ. How do I remove this PZ restriction and allow experience sharing? Can someone help me?
I don't want to be in PZ to enable experience sharing.



I removed that part of PZ and tested it. However, you still need to be in PZ to enable experience sharing. I want to completely remove this restriction.

C++: 
SharedExpStatus_t Party::getMemberSharedExperienceStatus(const Player * player) const
{
    if (memberList.empty()) {
        return SHAREDEXP_EMPTYPARTY;
    }

    uint32_t highestLevel = leader->getLevel();
    for (Player* member : memberList) {
        if (member->getLevel() > highestLevel) {
            highestLevel = member->getLevel();
        }
    }

    uint32_t minLevel = static_cast<uint32_t>(std::ceil((static_cast<float>(highestLevel) * 2) / 3));
    if (player->getLevel() < minLevel) {
        return SHAREDEXP_LEVELDIFFTOOLARGE;
    }

    if (!Position::areInRange<30, 30, 1>(leader->getPosition(), player->getPosition())) {
        return SHAREDEXP_TOOFARAWAY;
    }

    if (!player->hasFlag(PlayerFlag_NotGainInFight)) {
        //check if the player has healed/attacked anything recently
        auto it = ticksMap.find(player->getID());
        if (it == ticksMap.end()) {
            return SHAREDEXP_MEMBERINACTIVE;
        }

        uint64_t timeDiff = OTSYS_TIME() - it->second;
        if (timeDiff > static_cast<uint64_t>(g_config.getNumber(ConfigManager::PZ_LOCKED))) {
            return SHAREDEXP_MEMBERINACTIVE;
        }
    }
    return SHAREDEXP_OK;
}
Click to expand...
show the right function
 
Upvote 0 Downvote
Experience sharing is working, yes. When I invite another player to the party, everything is fine. However, when I try to activate the "Enable Share Exp", it doesn't want to activate. I had to go down to the temple or be in a PZ area to activate it. I went back to the same place where I was hunting, you know? I don't want to be in PZ to activate experience sharing. I want it to work with or without PZ, and also with PK or without PK, you know?
 
Upvote 0 Downvote
Mateus Robeerto said:
Experience sharing is working, yes. When I invite another player to the party, everything is fine. However, when I try to activate the "Enable Share Exp", it doesn't want to activate. I had to go down to the temple or be in a PZ area to activate it. I went back to the same place where I was hunting, you know? I don't want to be in PZ to activate experience sharing. I want it to work with or without PZ, and also with PK or without PK, you know?
Click to expand...
oh my....

post this function:
playerEnableSharedPartyExperience
 
Upvote 0 Downvote
Solved. It was just removing that line and I tested it without being in PZ. Works well. This was done in the games.cpp file.
XML: 
if (!party || (player->hasCondition(CONDITION_INFIGHT) && player->getZone() != ZONE_PROTECTION)) {
 
Last edited:
Upvote 0 Downvote
You have removed this part !party where it checks if player isn't in a party and return? Then players might set shared experience without being in a party using a bot script or something if I am not mistaken.

(C++ isn't my thing), so I'm just guessing.
 
Upvote 0 Downvote
pips said:
oh my....

post this function:
playerEnableSharedPartyExperience
Click to expand...

hey pips, taking advantage of your goodwill, I know it's possible, I didn't even touch it, but if you can give me a little idea, where I need to modify to have shared exp always active without having to activate anything, entered the pt, it has the required level.. already done sharing
 
Upvote 0 Downvote
Addams said:
You have removed this part !party where it checks if player isn't in a party and return? Then players might set shared experience without being in a party using a bot script or something if I am not mistaken.

(C++ isn't my thing), so I'm just guessing.
Click to expand...
I removed that line and tested it with a player who wasn't in a group. Experience sharing didn't work for the other player who wasn't in a group, it only works when both are in a group.

When I invited another player to the group and activated the "Enable Share Exp" option, I realized that the leader, who is active and attacking monsters, however, the other player, who is inactive, does not receive the shared experience. It seems to require both players to be active for experience sharing to work. I also put a player in the training area while the leader was hunting, but sharing experience didn't work. It seems that the proximity between the leader and the other player is crucial, and both must attack the same monsters for sharing to work properly. Although the issue appears to be resolved, I'm still not entirely sure.
Post automatically merged:

Can you test to make sure or not and then let me know here please? However, I would like to clarify that I can activate "Enable Share Exp" anywhere, not necessarily in protection zone (PZ) areas, you know what I mean?
Post automatically merged:

Take a look at the video, please.
https://imgur.com/nyyMymu
 
Last edited:
Upvote 0 Downvote
mano368 said:
hey pips, taking advantage of your goodwill, I know it's possible, I didn't even touch it, but if you can give me a little idea, where I need to modify to have shared exp always active without having to activate anything, entered the pt, it has the required level.. already done sharing
Click to expand...
try just change the default value of
bool sharedExpActive = false;

in party.h
Post automatically merged:

Mateus Robeerto said:
I removed that line and tested it with a player who wasn't in a group. Experience sharing didn't work for the other player who wasn't in a group, it only works when both are in a group.

When I invited another player to the group and activated the "Enable Share Exp" option, I realized that the leader, who is active and attacking monsters, however, the other player, who is inactive, does not receive the shared experience. It seems to require both players to be active for experience sharing to work. I also put a player in the training area while the leader was hunting, but sharing experience didn't work. It seems that the proximity between the leader and the other player is crucial, and both must attack the same monsters for sharing to work properly. Although the issue appears to be resolved, I'm still not entirely sure.
Post automatically merged:

Can you test to make sure or not and then let me know here please? However, I would like to clarify that I can activate "Enable Share Exp" anywhere, not necessarily in protection zone (PZ) areas, you know what I mean?
Post automatically merged:

Take a look at the video, please.
https://imgur.com/nyyMymu
Click to expand...

now you have to change the first function you've sent before.

there are the conditions to split exp or not.

if you want no distance limitations, remove:

C++: 
    if (!Position::areInRange<30, 30, 1>(leader->getPosition(), player->getPosition())) {
        return SHAREDEXP_TOOFARAWAY;
    }

if you want to remove the 'inactive' limitations, remove:

C++: 
    if (!player->hasFlag(PlayerFlag_NotGainInFight)) {
        //check if the player has healed/attacked anything recently
        auto it = ticksMap.find(player->getID());
        if (it == ticksMap.end()) {
            return SHAREDEXP_MEMBERINACTIVE;
        }

        uint64_t timeDiff = OTSYS_TIME() - it->second;
        if (timeDiff > static_cast<uint64_t>(g_config.getNumber(ConfigManager::PZ_LOCKED))) {
            return SHAREDEXP_MEMBERINACTIVE;
        }
    }
 
Last edited:
Upvote 0 Downvote
pips said:
if (!Position::areInRange<30, 30, 1>(leader->getPosition(), player->getPosition())) { return SHAREDEXP_TOOFARAWAY; }
Click to expand...
I already removed that part, everything is ok.
pips said:
if (!player->hasFlag(PlayerFlag_NotGainInFight)) { //check if the player has healed/attacked anything recently auto it = ticksMap.find(player->getID()); if (it == ticksMap.end()) { return SHAREDEXP_MEMBERINACTIVE; } uint64_t timeDiff = OTSYS_TIME() - it->second; if (timeDiff > static_cast<uint64_t>(g_config.getNumber(ConfigManager::pZ_LOCKED))) { return SHAREDEXP_MEMBERINACTIVE; } }
Click to expand...
Here, I wouldn't remove that part. Do you know why? The player can go AFK and still receive shared experience. I prefer the player not to go AFK and go hunting, receiving shared experience normally. I think this is perfectly normal. I didn't notice anything about what Addams said, no group and still sharing experience. I've tested it and found nothing like that.
 
Upvote 0 Downvote
Jeyci said:
so which would be the requeried changes in order to fix this?
Click to expand...
in order to allow players activate shared experience, without checking if they are in fight:
change in game.cpp
from
C++: 
void Game::playerEnableSharedPartyExperience(uint32_t playerId, bool sharedExpActive)
{
    Player* player = getPlayerByID(playerId);
    if (!player) {
        return;
    }

    Party* party = player->getParty();
    if (!party || (player->hasCondition(CONDITION_INFIGHT) && player->getZone() != ZONE_PROTECTION)) {
        return;
    }

    party->setSharedExperience(player, sharedExpActive);
}

to:

C++: 
void Game::playerEnableSharedPartyExperience(uint32_t playerId, bool sharedExpActive)
{
    Player* player = getPlayerByID(playerId);
    if (!player) {
        return;
    }

    Party* party = player->getParty();
    if (!party) {
        return;
    }

    party->setSharedExperience(player, sharedExpActive);
}
 
Upvote 0 Downvote
pips said:
try just change the default value of
bool sharedExpActive = false;

in party.h
Post automatically merged:



now you have to change the first function you've sent before.

there are the conditions to split exp or not.

if you want no distance limitations, remove:

C++: 
    if (!Position::areInRange<30, 30, 1>(leader->getPosition(), player->getPosition())) {
        return SHAREDEXP_TOOFARAWAY;
    }

if you want to remove the 'inactive' limitations, remove:

C++: 
    if (!player->hasFlag(PlayerFlag_NotGainInFight)) {
        //check if the player has healed/attacked anything recently
        auto it = ticksMap.find(player->getID());
        if (it == ticksMap.end()) {
            return SHAREDEXP_MEMBERINACTIVE;
        }

        uint64_t timeDiff = OTSYS_TIME() - it->second;
        if (timeDiff > static_cast<uint64_t>(g_config.getNumber(ConfigManager::PZ_LOCKED))) {
            return SHAREDEXP_MEMBERINACTIVE;
        }
    }
Click to expand...
this does not work
 
Upvote 0 Downvote

Similar threads

R
  • Question
C++ Party shared experience issue
2
Replies
37
Views
3K
Rodrigo Tolomeo
R
H
  • Question
Lua Pokedash Pota Party System
Replies
1
Views
465
Xikini
Xikini
R
  • Locked
  • Question
[TFS] 1.5 Source edit to prevent skill lose when player dies (SOLVED)
Replies
3
Views
569
Redz
R
M
  • Question
Lua Pokedash Pota Party System
Replies
1
Views
367
Rodrigo Tolomeo
R
Murilo35
  • Solved
C++ TFS 1.0 - v8.6 Remove Player Respawn Block
Replies
2
Views
309
Murilo35
Murilo35
D
  • Solved
Lua [TFS 0.3.6]Script Party Exp
Replies
7
Views
554
Douglita
D
Piifafa
  • Solved
TFS 1.X+ Help, protocolstatus.cpp
Replies
2
Views
414
Piifafa
Piifafa
J
  • Question
TFS 1.X+ [TFS-1.4 - 8.6]Cast system screen problem
Replies
4
Views
256
johnsamir
J
Back
Top