Random item box tfs 1.4

[vexler222]

Hi, i found this script for random item from box, but i don't know how to fix it, problem is when from box we got item with X count, i got error nil value count
For items with count 1, not more, it working normally

local presentbox = Action()
local presents = {
    [10503] = { -- item id of the item that will give u random items
        {2687, 10}, {6394, 3}, 6280, 6574, 6578, 6575, 6577, 6569, 6576, 6572, 2114 --Setup the rewards here
    }
}

function presentbox.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local count = 1
    local targetItem = presents[item.itemid]
    if not targetItem then
        return true
    end

    local gift = targetItem[math.random(#targetItem)]
    if type(gift) == "table" then
        gift = gift[1]
        count = gift[2]
    end

    player:addItem(gift, count)
    player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You got ".. ItemType(gift):getName() ..".")

    item:remove(1)
    fromPosition:sendMagicEffect(CONST_ME_GIFT_WRAPS)
    return true
end

presentbox:id(10503)
presentbox:register()

 

[Marco Oliveira]

Try this model:

forgottenserver/data/scripts/actions/others/mysterious_remains.lua at master · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[Xikini]

Hi, i found this script for random item from box, but i don't know how to fix it, problem is when from box we got item with X count, i got error nil value count
For items with count 1, not more, it working normally

local presentbox = Action()
local presents = {
    [10503] = { -- item id of the item that will give u random items
        {2687, 10}, {6394, 3}, 6280, 6574, 6578, 6575, 6577, 6569, 6576, 6572, 2114 --Setup the rewards here
    }
}

function presentbox.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local count = 1
    local targetItem = presents[item.itemid]
    if not targetItem then
        return true
    end

    local gift = targetItem[math.random(#targetItem)]
    if type(gift) == "table" then
        gift = gift[1]
        count = gift[2]
    end

    player:addItem(gift, count)
    player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You got ".. ItemType(gift):getName() ..".")

    item:remove(1)
    fromPosition:sendMagicEffect(CONST_ME_GIFT_WRAPS)
    return true
end

presentbox:id(10503)
presentbox:register()

gift is being over-written, and then trying to be assigned as count afterwords.
This causes a nil value, because the table position is wrong.

        gift = gift[1]
        count = gift[2]

the solution is to just swap their position, so that the table position is correct for count, and then over-written for gift.

        count = gift[2]
        gift = gift[1]

Here is the script with the changes.

local presentbox = Action()
local presents = {
    [10503] = { -- item id of the item that will give u random items
        {2687, 10}, {6394, 3}, 6280, 6574, 6578, 6575, 6577, 6569, 6576, 6572, 2114 --Setup the rewards here
    }
}

function presentbox.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local targetItem = presents[item.itemid]
    if not targetItem then
        return true
    end
    
    local count = 1
    local gift = targetItem[math.random(#targetItem)]
    if type(gift) == "table" then
        count = gift[2]
        gift = gift[1]
    end
    
    player:addItem(gift, count)
    player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You got ".. ItemType(gift):getName() ..".")
    
    item:remove(1)
    fromPosition:sendMagicEffect(CONST_ME_GIFT_WRAPS)
    return true
end

presentbox:id(10503)
presentbox:register()

 

[delikerem]

Is it possible to add Mounts, outfits exp etc?

 

[Evil Puncker]

Is it possible to add Mounts, outfits exp etc?

yes, anything is possible with coding, if you have a request feel free to open a request thread and specify your request and server engine