Lua script help

[neji75]

hi. i was working on my first item lua, it work in the begging but not it wont work. can anyone help me out plz?

local firstItems = {2489, 2647, 2457, 2525}

function onLogin(cid)
	if getPlayerStorageValue(cid, 30001) == -1 then
		for i = 1, table.maxn(firstItems) do
			doPlayerAddItem(cid, firstItems[i], 1)
		end
		doPlayerAddItem(cid, getPlayerSex(cid) == 0 and )
		local bag = doPlayerAddItem(cid, 1988, 1)
		doAddContainerItem(bag, 2674, 25)
		doAddContainerItem(bag, 2417, 1)
		doAddContainerItem(bag, 2428, 1)
		doAddContainerItem(bag, 2383, 1)
		doAddContainerItem(bag, 2190, 1)
		doAddContainerItem(bag, 2182, 1)
		doAddContainerItem(bag, 2456, 1)
		setPlayerStorageValue(cid, 30001, 1)
	end
	return TRUE
end

 

[sn3ejk]

Here is official first item, from mods (TFS 0.3.6pl1)​

<?xml version="1.0" encoding="UTF-8"?>
<mod name="First Items" version="1.0" author="The Forgotten Server" contact="otland.net" enabled="yes">
	<config name="firstitems_config"><![CDATA[
		config = {
			storage = 30001,
			items = {2050, 2382}
		}
	]]></config>
	<event type="login" name="FirstItems" event="script"><![CDATA[
		domodlib('firstitems_config')

		function onLogin(cid)
			if(getPlayerStorageValue(cid, config.storage) > 0) then
				return true
			end

			for _, id in ipairs(config.items) do
				doPlayerAddItem(cid, id, 1)
			end

			if(getPlayerSex(cid) == PLAYERSEX_FEMALE) then
				doPlayerAddItem(cid, 2651, 1)
			else
				doPlayerAddItem(cid, 2650, 1)
			end

			doAddContainerItem(doPlayerAddItem(cid, 1987, 1), 2674, 1)
			setPlayerStorageValue(cid, config.storage, 1)
			return true
		end
	]]></event>
</mod>

Compare this script with your.​

 

[Dexftw]

his isn't a mod it doesn't look like.

 

[andypsylon]

it will be helpful to you:
http://otland.net/f132/first-login-143639/#post1393474