separateNumber(number)

[AGS]

This function separates numbers with commas, for example:
separateNumber(123456) returns "123,456".
This makes numbers easier to read, and can be used in bank npcs, !exp commands, or anything.

Add this to function.lua

function separateNumber(number)
	if tonumber(number) ~= nil then
		local number = tostring(number)
		local newnumber = ""
		local value = {}
		local i = 1
		if #number > 3 then
			while #number > 3 do
			value[i] = string.sub(number,-3,-1)
			number = string.sub(number,1,-4)
			i=i+1
			end
			for i=#value,1,-1 do
				newnumber = ""..newnumber..","..value[i]..""
			end
			return ""..number..""..newnumber..""
		end
		return number
	end
	return false
end

There's just two bugs I couldn't fix:
1.- If you use decimals, the result gets bugged.
2.- Numbers with 15 digits or more don't work.
This happens even when printing directly a number with 15 digits, like:

print(123456789012345)
>1.2345678901235e+014

But it may be because of Brain Damage, the program I used to test it, maybe on OTs it works, I will test it tomorrow.

Hope someone can fix those bugs. And I know it can be made shorter .

 

[Nostradamus]

Why all those things?

function number.format(n)
    local left, num, right = string.match(n,'^([^%d]*%d)(%d*)(.-)$')
    return left..(num:reverse():gsub('(%d%d%d)','%1,'):reverse())..right
end

 

[AGS]

I really hate you.....

 

[Nostradamus]

I really hate you.....

Why? I tried to help you making what you've requested. This algorithm works as your wich.

 

[jo3bingham]

Why? I tried to help you making what you've requested. This algorithm works as your wich.

He was being sarcastic, lol unless you were too in which I just got pwned.

Jo3

 

[AGS]

Yeah, it was some kind of sarcasm, I even gave you rep and thanked you for making it shorter.

 

[elf]

Why? I tried to help you making what you've requested. This algorithm works as your wich.

haha, I love you Nostra, rofl!

//offtopd

 

[justin234]

I want to learn how to script like you guys...
You do it like its "Reading a book" its so easy.
You see something wrong, and bam instant fix, and it works.

Good luck to me

 

[Chris]

Justin, the best way is to experiment with it, it's basically pure English.

If you would like do something like this:
if something is equal to something else then do something
// this is what should happen
stop happening here

It would look like this:
if value == 2 then
// do something
end

Don't deny to use the functions list, it's pretty easy actually. cid means creature id, uid means unique id etc. It's pretty much English combined with some basic OT/general knowledge.

Now to become any good in scripting you shouldn't have any limitations. Go ahead, try things, start simple but pass over to more advanced scripts by time.


EDIT: Remember to look at other scripts, but don't copy it more like take a quick look at it.

 

[justin234]

Okay thanks for the tips.

Ill keep at it.

 

[Colandus]

Why all those things?

function number.format(n)
    local left, num, right = string.match(n,'^([^%d]*%d)(%d*)(.-)$')
    return left..(num:reverse():gsub('(%d%d%d)','%1,'):reverse())..right
end

You forgot:

local number = {}
number.__index = number

And some "shortening"

function number.format(n)
    local left, num, right = n:match('^(%D*%d)(%d*)(.-)$')
    return left..(num:reverse():gsub('(%d%d%d)','%1,'):reverse())..right
end

Even more "shorter" would be smaller var names xD Why? No clue just funny


Btw this remind me of TFS isNumber function I had to fix... But that one was ofcourse worse, as the solution was way easier ^^

Smart with the reverse, wouldn't have thought of that But well, you always learn new things

 

[AGS]

I was just wondering if someone knows how to make this for php?

 

[Colandus]

I was just wondering if someone knows how to make this for php?

There's already functions for it.
PHP: number_format - Manual

 

[Nostradamus]

@Topic
When I asked the reason of hating me I was beeing sarcasm too. There is an expression of that in portuguese, since I am not good with American culture, i can't reproduce that here, haha
Here will call that "cu doce".

You forgot:

local number = {}
number.__index = number

And some "shortening"

function number.format(n)
    local left, num, right = n:match('^(%D*%d)(%d*)(.-)$')
    return left..(num:reverse():gsub('(%d%d%d)','%1,'):reverse())..right
end

Even more "shorter" would be smaller var names xD Why? No clue just funny


Btw this remind me of TFS isNumber function I had to fix... But that one was ofcourse worse, as the solution was way easier ^^

Smart with the reverse, wouldn't have thought of that But well, you always learn new things

Well, i didn't forgot anything, the reason that i called the function like it is with a dot doesn't really makes that as a class. The best way of doing a class for that is making a inheritance into string or other generic lua lib. It was only a design purposes, haha

Well, smaller vars will not make the code more faster, the system will allocate the same space to all of then if they had the same value. I prefer auto-explicative vars, and please, do not abuse of using syntax suggars, can be bad if you have a high pleasure (haha, nice joke )

Btw, reverse is available in a lot of languages (well, i saw in Phython and Ruby only xD)

 

[AGS]

21 lines, compared with your 4 lines,makes me feel bad

At least I tried

 

[Colandus]

@Topic
When I asked the reason of hating me I was beeing sarcasm too. There is an expression of that in portuguese, since I am not good with American culture, i can't reproduce that here, haha
Here will call that "cu doce".




Well, i didn't forgot anything, the reason that i called the function like it is with a dot doesn't really makes that as a class. The best way of doing a class for that is making a inheritance into string or other generic lua lib. It was only a design purposes, haha

Well, smaller vars will not make the code more faster, the system will allocate the same space to all of then if they had the same value. I prefer auto-explicative vars, and please, do not abuse of using syntax suggars, can be bad if you have a high pleasure (haha, nice joke )

Btw, reverse is available in a lot of languages (well, i saw in Phython and Ruby only xD)

And about the class I just made it fast because otherwise it'd give him errors and well most people aren't smart enough to just change funct name to numberFormat or such x)

Making short codes with vars ppl don't understand make noobs thing it's cooler I've learnt hueahuea xD

Reverse is available in PHP too, but the way u used is was smart