TFS 0.X show list of players with same storage

[royalpala]

hello people, I was wondering if there's a way to make a function (action onUse) for a book to show a list of players with the same storage as you?
anybody got a clue?

example:
you have storage 9999 == 1 then show list of players with storage 9999 = 1



thanks in advance for your comments

 

[Xikini]

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local text = ""
    for _, pid in ipairs(getPlayersOnline()) do
        if getCreatureStorage(pid, 9999) == 1 then
            if text ~= "" then
                text = text .. "\n"
            end
            text = text .. getCreatureName(pid)
        end
    end
    doShowTextDialog(cid, 1950, text)
    return true
end

 

[royalpala]

gonna try this, thanks @Xikini , as always

 

[Xikini]

gonna try this, thanks @Xikini , as always

How'd it turn out?

 

[Alpha]

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local text = ""
    for _, pid in ipairs(getPlayersOnline()) do
        if getCreatureStorage(pid, 9999) == 1 then
            if text ~= "" then
                text = text .. "\n"
            end
            text = text .. getCreatureName(pid)
        end
    end
    doShowTextDialog(cid, 1950, text)
    return true
end

You should use pairs over ipairs when you don't care about the order that the table is traversed in, it's faster. Also table.concat is a really fast & easy way to concatenate strings.

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local players = {}
   
    for _, player in pairs(getPlayersOnline()) do
        if getCreatureStorage(player, 9999) == 1 then
            table.insert(players, getCreatureName(player))
        end
    end

    doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, ("Players with storage:\n%s"):format(table.concat(players, ", ")))
    return true
end

 

[royalpala]

How'd it turn out?

@Xikini havent tested yet beacuse Im at work right now, but I will test at night, in my country it´s 1:40 pm
@Alpha I dont know how to code properly, but DAMN, that looks neat!

 

[Infernum]

You should use pairs over ipairs when you don't care about the order that the table is traversed in, it's faster. Also table.concat is a really fast & easy way to concatenate strings.

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local players = {}
  
    for _, player in pairs(getPlayersOnline()) do
        if getCreatureStorage(player, 9999) == 1 then
            table.insert(players, getCreatureName(player))
        end
    end

    doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, ("Players with storage:\n%s"):format(table.concat(players, ", ")))
    return true
end

and t[#t+1] = val is faster than table.insert

 

[Alpha]

and t[#t+1] = val is faster than table.insert

Could also write it like this for maximum speed, but then it just looks gay, pairs & ipairs are both slower than indexing

function onUse(cid, item, fromPosition, itemEx, toPosition)
	local onlinePlayers = getPlayersOnline()
    local players = {}
   
    for i = 1, #onlinePlayers do
    	local player = onlinePlayers[i]
        if getCreatureStorage(player, 9999) == 1 then
            players[#players + 1] = getCreatureName(player)
        end
    end

    doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, ("Players with storage:\n%s"):format(table.concat(players, ", ")))
    return true
end

 

[Infernum]

can actually also keep track of index manually to make it even faster instead of using # operator each time

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local onlinePlayers = getPlayersOnline()
    local players = {}
    local index = 0
      
    for i = 1, #onlinePlayers do
        local player = onlinePlayers[i]
        if getCreatureStorage(player, 9999) == 1 then
            index = index + 1
            players[index] = getCreatureName(player)
        end
    end

    doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, ("Players with storage:\n%s"):format(table.concat(players, ", ")))
    return true
end

 

[Alpha]

can actually also keep track of index manually to make it even faster instead of using # operator each time

function onUse(cid, item, fromPosition, itemEx, toPosition)
    local onlinePlayers = getPlayersOnline()
    local players = {}
    local index = 0
     
    for i = 1, #onlinePlayers do
        local player = onlinePlayers[i]
        if getCreatureStorage(player, 9999) == 1 then
            index = index + 1
            players[index] = getCreatureName(player)
        end
    end

    doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_BLUE, ("Players with storage:\n%s"):format(table.concat(players, ", ")))
    return true
end

Can also make the storage key & value local variables so they can be reused from a CPU register (not sure about this shit tbh)