Storage for equip actionid

[sakero]

Hello,

I need: when equipping "x" sword for example with actionid "9191" obtain

self: setStorageValue (8345, 1)

I Have this: in event / script / Player function PlayernMoveItem(item, count, fromPosition, toPosition, fromCylinder, toCylinder)

 if item:getActionId() == 9191 and self:getStorageValue(8345) == -1 then
        if toPosition.y ==  6 then
            self:setStorageValue(8345, 1)
            return true
        end
    end
   
        if item:getActionId() == 9191 and self:getStorageValue(8345) == 1 then
                if toPosition.x ~= CONTAINER_POSITION or toPosition.y == CONST_SLOT_BACKPACK then
            self:setStorageValue(8345, -1)
            return true
        end
    end

The problem is:
when I move item to the floor and there is something the storage is changed, and the sword is still equipped

PD: Sry my english.

 

[Sttorm]

@sakero it's practical to use movements

local storage = 8345
local action_id = 9191

function onEquip(player, item, slot)
    if item:getActionId() == action_id then
        self:setStorageValue(storage, 1)
        return true
    end
end

function onDeEquip(player, item, slot)
    if item:getActionId() == action_id then
        self:setStorageValue(storage, 0)
        return true
    end
end

 

[sakero]

I can't test now. But i can register actionid for onequip and ondequip un movements?
I want use for different items

 

[Sttorm]

@sakero All items that have this id action will have this effect.

 

[Apollos]

@sakero it's practical to use movements

local storage = 8345
local action_id = 9191

function onEquip(player, item, slot)
    if item:getActionId() == action_id then
        self:setStorageValue(storage, 1)
        return true
    end
end

function onDeEquip(player, item, slot)
    if item:getActionId() == action_id then
        self:setStorageValue(storage, 0)
        return true
    end
end

You need to use player instead of self here. Also I'm not 100% with onEquip/onDeEquip sure but you may just be able to register the action id in movements.xml instead of the itemid so you can exclude the getActionId check within.

I can't test now. But i can register actionid for onequip and ondequip un movements?
I want use for different items

I think it may be better to just check slots of player when needed instead of setting storages every time, for example:

for i = CONST_SLOT_FIRST, CONST_SLOT_LAST do
    local slot_item = player:getSlotItem(i)
    if slot_item and slot_item.actionid == 9191 then
        -- do your stuff
        break
    end
end

Or if you only need to check one slot, like how your only checking CONST_SLOT_LEFT in your onMove attempt you can do this:

local slot_item = player:getSlotItem(CONST_SLOT_LEFT)
if slot_item and slot_item.actionid == 9191 then
    -- do your stuff
end

 

[Sttorm]

@Apollos Thank you! I do not have much experience with this version of TFS, even more that I do not speak English and use translator

@sakero

    <movevent event="Equip" actionid="9191" slot="ring" script="item.lua" />
    <movevent event="DeEquip" actionid="9191" slot="ring" script="item.lua" />

local storage = 8345
local action_id = 9191

function onEquip(player, item, slot)
    player:setStorageValue(storage, 1)
    return true
end

function onDeEquip(player, item, slot)
    player:setStorageValue(storage, 0)
    return true
end

 

[sakero]

@Apollos Thank you! I do not have much experience with this version of TFS, even more that I do not speak English and use translator

@sakero

    <movevent event="Equip" actionid="9191" slot="ring" script="item.lua" />
    <movevent event="DeEquip" actionid="9191" slot="ring" script="item.lua" />

local storage = 8345
local action_id = 9191

function onEquip(player, item, slot)
    player:setStorageValue(storage, 1)
    return true
end

function onDeEquip(player, item, slot)
    player:setStorageValue(storage, 0)
    return true
end

Its dont work, I think it does not work register actionid in movements.

You need to use player instead of self here. Also I'm not 100% with onEquip/onDeEquip sure but you may just be able to register the action id in movements.xml instead of the itemid so you can exclude the getActionId check within.


I think it may be better to just check slots of player when needed instead of setting storages every time, for example:

for i = CONST_SLOT_FIRST, CONST_SLOT_LAST do
    local slot_item = player:getSlotItem(i)
    if slot_item and slot_item.actionid == 9191 then
        -- do your stuff
        break
    end
end

Or if you only need to check one slot, like how your only checking CONST_SLOT_LEFT in your onMove attempt you can do this:

local slot_item = player:getSlotItem(CONST_SLOT_LEFT)
if slot_item and slot_item.actionid == 9191 then
    -- do your stuff
end

Nice, it worked, different but it worked

thanks to both.