[Suggestion] Items and proper UID system

[oen432]

Anyone else thinks that with OTC being more and more popular, we should start working on a real Item Unique Identification, like in any other multiplayer game?

Why? Simple, client has no way to identify one item from another if they are the same type (like two Fire Axes, where one has bonus stats like imbuements or custom attributes).
How? This is simple too, integer that increments every time it's assigned to a newly created item.

Now we can ask server for an item based on a number.

 

[Znote]

Yeah, like this?

[suggestion] Unique item reference database structure

Check link for suggested schema changes: https://gist.github.com/Znote/2508c1d50fcca318f80b3ea4bc6f10a3 CREATE TABLE IF NOT EXISTS `items` ( `item_uid` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `itemtype` smallint(6) NOT NULL, `count` smallint(5) NOT NULL, `attributes` blob NOT NULL...

otland.net

Currently, I think you can pass Item(...):Id() to OTC using extendedopcodes to be able to distinguish two fire swords from each other.
Where id is the temporarily/incremental runtime item reference by TFS. (not the itemtype id like fire sword).

 

[oen432]

Yeah, like this?

[suggestion] Unique item reference database structure

Check link for suggested schema changes: https://gist.github.com/Znote/2508c1d50fcca318f80b3ea4bc6f10a3 CREATE TABLE IF NOT EXISTS `items` ( `item_uid` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `itemtype` smallint(6) NOT NULL, `count` smallint(5) NOT NULL, `attributes` blob NOT NULL...

otland.net

Well, almost. Yours is too advanced, saving isn't necessary.

game.h

uint32_t lastItemId = 0;
uint32_t nextItemUID() {
    return ++lastItemId;
}

item.h

uint32_t realUId = 0;

void setRealUID(uint32_t uid) {
    realUId = uid;
}

uint32_t getRealUID() const {
    return realUId;
}

item.cpp

Item* Item::CreateItem(const uint16_t type, uint16_t count /*= 0*/)
{
    /* ... */
    if (it.id != 0) {
        /* ... */
        if (it.pickupable)
        {
            newItem->setRealUID(g_game.nextItemUID());
        }

        newItem->incrementReferenceCounter();
    }

    return newItem;
}

New methods to get item by UID, set item UID and it worked well. Used it with Tooltip and Upgrade System, every item is unique and I'm able to update it's data on the client using UID.