Svargrond Arena

Xarah · Nov 8, 2024

Hello, I'm having an issue with the arena, specifically with the stone that doesn't disappear when we kill a monster. I tried debugging it, and it shows that it can't find the stone. I've been struggling with this for a while now, and it's probably something minor. If you have any ideas on what might be causing this, that would be great.

lib:

LUA:

SvargrondArena = {
    -- kick time in seconds (10 minutes)
    kickTime = 600,
    kickPosition = Position(32251, 31098, 6),
    rewardPosition = Position(32222, 31080, 6),

    -- used to store event ids
    kickEvents = {},
    timerEvents = {},
    effectPositionCache = {},

    -- item ids used by the script
    itemTimer = 10288,
    itemPillar = 1354,
    itemTeleport = 1387,
    itemsNotErasable = {10288, 1543, 1544, 1545},
}

-- Script automatically derives other pit positions from this one
local firstPit = {
    fromPos = {x = 32205, y = 31094, z = 7},
    toPos = {x = 32214, y = 31103, z = 7},
    center = {x = 32210, y = 31098, z = 7},
    pillar = {x = 32204, y = 31098, z = 7},
    tp = {x = 32204, y = 31098, z = 7},
    summon = {x = 32210, y = 31100, z = 7}
}

PITS = {
    [1] = {
        fromPos = firstPit.fromPos,
        toPos = firstPit.toPos,
        center = firstPit.center,
        pillar = firstPit.pillar,
        tp = firstPit.tp,
        summon = firstPit.summon
    },
    [2] = {
        fromPos = {x = firstPit.fromPos.x - 14, y = firstPit.fromPos.y, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 14, y = firstPit.toPos.y, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 14, y = firstPit.center.y, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 14, y = firstPit.pillar.y, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 14, y = firstPit.tp.y, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 14, y = firstPit.summon.y, z = firstPit.summon.z}
    },
    [3] = {
        fromPos = {x = firstPit.fromPos.x - 28, y = firstPit.fromPos.y, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 28, y = firstPit.toPos.y, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 28, y = firstPit.center.y, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 28, y = firstPit.pillar.y, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 28, y = firstPit.tp.y, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 28, y = firstPit.summon.y, z = firstPit.summon.z}
    },
    [4] = {
        fromPos = {x = firstPit.fromPos.x - 42, y = firstPit.fromPos.y, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 42, y = firstPit.toPos.y, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 42, y = firstPit.center.y, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 42, y = firstPit.pillar.y, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 42, y = firstPit.tp.y, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 42, y = firstPit.summon.y, z = firstPit.summon.z}
    },
    [5] = {
        fromPos = {x = firstPit.fromPos.x - 35, y = firstPit.fromPos.y - 14, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 35, y = firstPit.toPos.y - 14, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 35, y = firstPit.center.y - 14, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 35, y = firstPit.pillar.y - 14, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 35, y = firstPit.tp.y - 14, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 35, y = firstPit.summon.y - 14, z = firstPit.summon.z}
    },
    [6] = {
        fromPos = {x = firstPit.fromPos.x - 21, y = firstPit.fromPos.y - 14, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 21, y = firstPit.toPos.y - 14, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 21, y = firstPit.center.y - 14, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 21, y = firstPit.pillar.y - 14, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 21, y = firstPit.tp.y - 14, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 21, y = firstPit.summon.y - 14, z = firstPit.summon.z}
    },
    [7] = {
        fromPos = {x = firstPit.fromPos.x - 7, y = firstPit.fromPos.y - 14, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 7, y = firstPit.toPos.y - 14, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 7, y = firstPit.center.y - 14, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 7, y = firstPit.pillar.y - 14, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 7, y = firstPit.tp.y - 14, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 7, y = firstPit.summon.y - 14, z = firstPit.summon.z}
    },
    [8] = {
        fromPos = {x = firstPit.fromPos.x - 14, y = firstPit.fromPos.y - 28, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 14, y = firstPit.toPos.y - 28, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 14, y = firstPit.center.y - 28, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 14, y = firstPit.pillar.y - 28, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 14, y = firstPit.tp.y - 28, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 14, y = firstPit.summon.y - 28, z = firstPit.summon.z}
    },
    [9] = {
        fromPos = {x = firstPit.fromPos.x - 28, y = firstPit.fromPos.y - 28, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 28, y = firstPit.toPos.y - 28, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 28, y = firstPit.center.y - 28, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 28, y = firstPit.pillar.y - 28, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 28, y = firstPit.tp.y - 28, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 28, y = firstPit.summon.y - 28, z = firstPit.summon.z}
    },
    [10] = {
        fromPos = {x = firstPit.fromPos.x - 21, y = firstPit.fromPos.y - 42, z = firstPit.fromPos.z},
        toPos = {x = firstPit.toPos.x - 21, y = firstPit.toPos.y - 42, z = firstPit.toPos.z},
        center = {x = firstPit.center.x - 21, y = firstPit.center.y - 41, z = firstPit.center.z},
        pillar = {x = firstPit.pillar.x - 21, y = firstPit.pillar.y - 41, z = firstPit.pillar.z},
        tp = {x = firstPit.tp.x - 21, y = firstPit.tp.y - 41, z = firstPit.tp.z},
        summon = {x = firstPit.summon.x - 21, y = firstPit.summon.y - 41, z = firstPit.summon.z}
    }
}

ARENA = {
    [1] = {
        name = 'Greenhorn',
        price = 1000,
        questLog = Storage.SvargrondArena.QuestLogGreenhorn,
        achievement = 'Greenhorn',
        creatures = {
            [1] = 'frostfur',
            [2] = 'bloodpaw',
            [3] = 'bovinus',
            [4] = 'achad',
            [5] = 'colerian the barbarian',
            [6] = 'the hairy one',
            [7] = 'axeitus headbanger',
            [8] = 'rocky',
            [9] = 'cursed gladiator',
            [10] = 'orcus the cruel'
        },
        reward = {
            trophy = 5807,
            trophyStorage = Storage.SvargrondArena.TrophyGreenhorn,
            desc = 'It is given to the courageous victor of the barbarian arena in greenhorn difficulty. Awarded to %s',
        }
    },
    [2] = {
        name = 'Scrapper',
        price = 5000,
        questLog = Storage.SvargrondArena.QuestLogScrapper,
        achievement = 'Scrapper',
        creatures = {
            [1] = 'avalanche',
            [2] = 'kreebosh the exile',
            [3] = 'the dark dancer',
            [4] = 'the hag',
            [5] = 'slim',
            [6] = 'grimgor guteater',
            [7] = 'drasilla',
            [8] = 'spirit of earth',
            [9] = 'spirit of water',
            [10] = 'spirit of fire'
        },
        reward = {
            trophy = 5806,
            trophyStorage = Storage.SvargrondArena.TrophyScrapper,
            desc = 'It is given to the courageous victor of the barbarian arena in scrapper difficulty. Awarded to %s.',
        }
    },
    [3] = {
        name = 'Warlord',
        price = 10000,
        questLog = Storage.SvargrondArena.QuestLogWarlord,
        achievement = 'Warlord of Svargrond',
        creatures = {
            [1] = 'webster',
            [2] = 'darakan the executioner',
            [3] = 'norgle glacierbeard',
            [4] = 'the pit lord',
            [5] = 'svoren the mad',
            [6] = 'the masked marauder',
            [7] = 'gnorre chyllson',
            [8] = 'fallen mooh\'tah master ghar',
            [9] = 'deathbringer',
            [10] = 'the obliverator'
        },
        reward = {
            trophy = 5805,
            trophyStorage = Storage.SvargrondArena.TrophyWarlord,
            desc = 'It is given to the courageous victor of the barbarian arena in warlord difficulty. Awarded to %s.',
        }
    }
}

function SvargrondArena.getPitCreatures(pitId)
    if not PITS[pitId] then
        return {}
    end

    local ret = {}
    local specs = Game.getSpectators(PITS[pitId].center, false, false, 5, 5, 5, 5)
    for i = 1, #specs do
        ret[#ret+1] = specs[i]
    end

    return ret
end

function SvargrondArena.resetPit(pitId)
    if not PITS[pitId] then
        return
    end

    for x = PITS[pitId].fromPos.x, PITS[pitId].toPos.x do
        for y = PITS[pitId].fromPos.y, PITS[pitId].toPos.y do
            for z = PITS[pitId].fromPos.z, PITS[pitId].toPos.z do
                local tile = Tile({x=x, y=y, z=z})
                if tile then
                    local movableItem = tile:getThing(255)
                    if movableItem and movableItem:isItem() then
                        local itemType = ItemType(movableItem:getId())
                        if itemType and itemType:isMovable() and not isInArray(SvargrondArena.itemsNotErasable, movableItem:getId()) then
                            moveableItem:remove()
                        end
                    end

                    local creature = tile:getTopCreature()
                    if creature and creature:isMonster() then
                        creature:remove()
                    end
                end
            end
        end
    end

    local pillarTile = Tile(PITS[pitId].pillar)
    if pillarTile then
        local teleportItem = pillarTile:getItemById(SvargrondArena.itemTeleport)
        if teleportItem then
            teleportItem:remove()
        end

        local pillarItem = pillarTile:getItemById(SvargrondArena.itemPillar)
        if not pillarItem then
            Game.createItem(SvargrondArena.itemPillar, 1, PITS[pitId].pillar)
        end
    end
end

function SvargrondArena.getPitOccupant(pitId, ignorePlayer)
    local creatures = SvargrondArena.getPitCreatures(pitId)
    for i = 1, #creatures do
        if creatures[i]:isPlayer() and creatures[i]:getId() ~= ignorePlayer:getId() then
            return creatures[i]
        end
    end

    return nil
end

function SvargrondArena.kickPlayer(cid, hideMessage)
    SvargrondArena.cancelEvents(cid)
    local player = Player(cid)
    if not player then
        return
    end

    if player:getStorageValue(Storage.SvargrondArena.Pit) > 0 then
        player:teleportTo(SvargrondArena.kickPosition)
        SvargrondArena.kickPosition:sendMagicEffect(CONST_ME_TELEPORT)
        player:setStorageValue(Storage.SvargrondArena.Pit, 0)
        if not hideMessage then
            player:sendTextMessage(MESSAGE_EVENT_ADVANCE, 'Your time ran out!')
        end
    end
end

function SvargrondArena.cancelEvents(cid)
    local kickEvent = SvargrondArena.kickEvents[cid]
    if kickEvent then
        SvargrondArena.removeTimer(kickEvent.pitId)
        stopEvent(kickEvent.eventId)
    end
    SvargrondArena.kickEvents[cid] = nil
end

function SvargrondArena.scheduleKickPlayer(cid, pitId)
    SvargrondArena.cancelEvents(cid)
    SvargrondArena.startTimer(pitId)
    local eventId = addEvent(SvargrondArena.kickPlayer, SvargrondArena.kickTime * 1000, cid)
    SvargrondArena.kickEvents[cid] = {eventId = eventId, pitId = pitId}
end

function SvargrondArena.startTimer(pitId)
    local tile = Tile(PITS[pitId].fromPos)
    if not tile then
        return
    end

    local timerItem = tile:getItemById(SvargrondArena.itemTimer)
    if timerItem then
        timerItem:remove()
    end

    timerItem = Game.createItem(SvargrondArena.itemTimer, 1, PITS[pitId].fromPos)
    if timerItem then
        timerItem:decay()
    end

    if SvargrondArena.timerEvents[pitId] then
        stopEvent(SvargrondArena.timerEvents[pitId])
    end
    SvargrondArena.timerEvents[pitId] = addEvent(SvargrondArena.removeTimer, SvargrondArena.kickTime * 1000, pitId)
end

function SvargrondArena.removeTimer(pitId)
    local tile = Tile(PITS[pitId].fromPos)
    if not tile then
        return
    end

    local timerItem = tile:getItemById(SvargrondArena.itemTimer)
    if timerItem then
        timerItem:remove()
    end
    SvargrondArena.timerEvents[pitId] = nil
end

function SvargrondArena.sendPillarEffect(pitId)
    local positions = SvargrondArena.effectPositionCache[pitId]
    if not positions then
        local position = PITS[pitId].pillar
        local effectPositions = {
                Position(position.x - 1, position.y,     position.z),
                Position(position.x + 1, position.y,     position.z),
                Position(position.x + 1, position.y - 1, position.z),
                Position(position.x + 1, position.y + 1, position.z),
                Position(position.x,     position.y,     position.z)
        }
        SvargrondArena.effectPositionCache[pitId] = effectPositions
        positions = effectPositions
    end

    for i = 1, #positions do
        positions[i]:sendMagicEffect(CONST_ME_MAGIC_BLUE)
    end
end

movements:

Code:

function onStepIn(creature, item, position, fromPosition)
    local player = creature:getPlayer()
    if not player then
        return true
    end

    local pitId = player:getStorageValue(Storage.SvargrondArena.Pit)
    if pitId < 1 or pitId > 10 then
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, 'You cannot enter without Halvar\'s permission.')
        player:teleportTo(fromPosition)
        return true
    end

    local arenaId = player:getStorageValue(Storage.SvargrondArena.Arena)
    if not(PITS[pitId] and ARENA[arenaId]) then
        player:teleportTo(fromPosition)
        return true
    end

    local occupant = SvargrondArena.getPitOccupant(pitId, player)
    if occupant then
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, occupant:getName() .. ' is currently in the next arena pit. Please wait until ' .. (occupant:getSex() == PLAYERSEX_FEMALE and 's' or '') .. 'he is done fighting.')
        player:teleportTo(fromPosition)
        return true
    end

    SvargrondArena.resetPit(pitId)
    SvargrondArena.scheduleKickPlayer(player.uid, pitId)
    Game.createMonster(ARENA[arenaId].creatures[pitId], PITS[pitId].summon, false, true)

    player:teleportTo(PITS[pitId].center)
    player:getPosition():sendMagicEffect(CONST_ME_MAGIC_RED)
    player:say('FIGHT!', TALKTYPE_MONSTER_SAY)
    return true
end

creaturescripts:

Code:

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if not targetMonster then
        return
    end

    local player = creature:getPlayer()
    local pit = player:getStorageValue(Storage.SvargrondArena.Pit)
    if pit < 1 or pit > 10 then
        return
    end

    local arena = player:getStorageValue(Storage.SvargrondArena.Arena)
    if arena < 1 then
        return
    end

    if not isInArray(ARENA[arena].creatures, targetMonster:getName():lower()) then
        return
    end

    -- Usuń kamień
    local pillarTile = Tile(PITS[pit].pillar)
    if pillarTile then
        local pillarItem = pillarTile:getItemById(SvargrondArena.itemPillar)
        if pillarItem then
            pillarItem:remove()
            SvargrondArena.sendPillarEffect(pit)
        end
    end

    player:setStorageValue(Storage.SvargrondArena.Pit, pit + 1)
    player:say('Victory! Head to the next room.', TALKTYPE_MONSTER_SAY)
    return true
end

czouski · Nov 8, 2024

what about the lib folder did you add the storages and functions of the arena?

I had to fix it for tfs 1.5 downgrade before
so if ur using it enjoy

Xarah · Nov 8, 2024

czouski · Nov 8, 2024

local targetMonster = target:getMonster()

to

local targetMonster = target:isMonster()

Xarah · Nov 8, 2024

after removal:

targetMonster = target:isMonster()

the error disappeared, but the stone is still in its place

any ideas?

czouski · Nov 8, 2024

you still have not mentioned what engine are you using and where you got original scripts from.

Post automatically merged: Nov 8, 2024

LUA:

-- Define a global variable for debugging
local debugEnabled = false

function onKill(creature, target)
    -- Check if debugging is enabled
    if debugEnabled then
        print("onKill event triggered")
    end

    -- Check if the target is a valid monster
    if not isMonster(target:getId()) then
        if debugEnabled then
            print("Target is not a valid monster")
            print("Target ID:", target:getId())
            print("Target Name:", target:getName())
        end
        return
    end

    -- Check if the creature is a player
    local player = creature:getPlayer()
    if not player then
        if debugEnabled then
            print("Creature is not a player")
        end
        return
    end

    -- Retrieve pit and arena values from player's storage
    local pit = player:getStorageValue(Storage.SvargrondArena.Pit)
    local arena = player:getStorageValue(Storage.SvargrondArena.Arena)

    -- Validate pit and arena values
    if pit < 1 or pit > 10 then
        if debugEnabled then
            print("Invalid pit value:", pit)
        end
        return
    end

    if arena < 1 then
        if debugEnabled then
            print("Invalid arena value:", arena)
        end
        return
    end

    -- Debug print pit and arena values
    if debugEnabled then
        print("Pit:", pit, "Arena:", arena)
    end

    -- Check if the target monster is part of the current arena
    if not isInArray(ARENA[arena].creatures, target:getName():lower()) then
        if debugEnabled then
            print("Target monster not part of current arena")
        end
        return
    end

    -- Debug print the target monster
    if debugEnabled then
        print("Target monster:", target:getName())
    end

    -- Remove pillar and create teleport
    local pillarTile = Tile(PITS[pit].pillar)
    if not pillarTile then
        if debugEnabled then
            print("Pillar tile not found")
        end
        return
    end

    local pillarItem = pillarTile:getItemById(SvargrondArena.itemPillar)
    if not pillarItem then
        if debugEnabled then
            print("Pillar item not found")
        end
        return
    end

    pillarItem:remove()

    local teleportItem = Game.createItem(SvargrondArena.itemTeleport, 1, PITS[pit].tp)
    if not teleportItem then
        if debugEnabled then
            print("Failed to create teleport item")
        end
        return
    end

    teleportItem:setActionId(25200)
    if debugEnabled then
        print("Pillar removed and teleport created successfully")
    end

    SvargrondArena.sendPillarEffect(pit)

    player:setStorageValue(Storage.SvargrondArena.Pit, pit + 1)
    player:say('Victory! Head through the new teleporter into the next room.', TALKTYPE_MONSTER_SAY)

    if debugEnabled then
        print("Player's pit value incremented successfully")
    end

    return true
end

Xarah · Nov 8, 2024

tfs 1.4.2 [10.98]
I have the arena files from: [10.98] Requested Real Map Datapack (https://otland.net/threads/10-98-requested-real-map-datapack.262491/)

Post automatically merged: Nov 8, 2024

czouski said:

you still have not mentioned what engine are you using and where you got original scripts from.

Post automatically merged: Nov 8, 2024

LUA:

-- Define a global variable for debugging
local debugEnabled = false

function onKill(creature, target)
    -- Check if debugging is enabled
    if debugEnabled then
        print("onKill event triggered")
    end

    -- Check if the target is a valid monster
    if not isMonster(target:getId()) then
        if debugEnabled then
            print("Target is not a valid monster")
            print("Target ID:", target:getId())
            print("Target Name:", target:getName())
        end
        return
    end

    -- Check if the creature is a player
    local player = creature:getPlayer()
    if not player then
        if debugEnabled then
            print("Creature is not a player")
        end
        return
    end

    -- Retrieve pit and arena values from player's storage
    local pit = player:getStorageValue(Storage.SvargrondArena.Pit)
    local arena = player:getStorageValue(Storage.SvargrondArena.Arena)

    -- Validate pit and arena values
    if pit < 1 or pit > 10 then
        if debugEnabled then
            print("Invalid pit value:", pit)
        end
        return
    end

    if arena < 1 then
        if debugEnabled then
            print("Invalid arena value:", arena)
        end
        return
    end

    -- Debug print pit and arena values
    if debugEnabled then
        print("Pit:", pit, "Arena:", arena)
    end

    -- Check if the target monster is part of the current arena
    if not isInArray(ARENA[arena].creatures, target:getName():lower()) then
        if debugEnabled then
            print("Target monster not part of current arena")
        end
        return
    end

    -- Debug print the target monster
    if debugEnabled then
        print("Target monster:", target:getName())
    end

    -- Remove pillar and create teleport
    local pillarTile = Tile(PITS[pit].pillar)
    if not pillarTile then
        if debugEnabled then
            print("Pillar tile not found")
        end
        return
    end

    local pillarItem = pillarTile:getItemById(SvargrondArena.itemPillar)
    if not pillarItem then
        if debugEnabled then
            print("Pillar item not found")
        end
        return
    end

    pillarItem:remove()

    local teleportItem = Game.createItem(SvargrondArena.itemTeleport, 1, PITS[pit].tp)
    if not teleportItem then
        if debugEnabled then
            print("Failed to create teleport item")
        end
        return
    end

    teleportItem:setActionId(25200)
    if debugEnabled then
        print("Pillar removed and teleport created successfully")
    end

    SvargrondArena.sendPillarEffect(pit)

    player:setStorageValue(Storage.SvargrondArena.Pit, pit + 1)
    player:say('Victory! Head through the new teleporter into the next room.', TALKTYPE_MONSTER_SAY)

    if debugEnabled then
        print("Player's pit value incremented successfully")
    end

    return true
end

No debug messages are showing up.

czouski · Nov 8, 2024

because debug is set to false if you look at the top of the script (●'◡'●)

Xarah · Nov 10, 2024

The problem is that it can't find the stone. I added debugging to display all items on the given tile.

Or maybe it's not reading the lib library at all?

Although it seems like everything is fine:

data\lib:

LUA:

-- Core API functions implemented in Lua
dofile('data/lib/core/core.lua')

-- Compatibility library for our old Lua API
dofile('data/lib/compat/compat.lua')

-- Debugging helper function for Lua developers
dofile('data/lib/debugging/dump.lua')
dofile('data/lib/debugging/lua_version.lua')

-- Miscellaneous library
dofile('data/lib/miscellaneous/miscellaneous.lua')

data\lib\miscellaneous:

Code:

-- load storages first
dofile('data/lib/miscellaneous/051-storages.lua')

dofile('data/lib/miscellaneous/050-functions.lua')
dofile('data/lib/miscellaneous/055-teleport_item_destinations.lua')

dofile('data/lib/miscellaneous/demonOakQuest.lua')
dofile('data/lib/miscellaneous/killingInTheNameOfQuest.lua')
dofile('data/lib/miscellaneous/svargrondArenaQuest.lua')
dofile('data/lib/miscellaneous/achievements_lib.lua')

Xikini · Nov 10, 2024

Xarah said:

The problem is that it can't find the stone. I added debugging to display all items on the given tile.

View attachment 88171

View attachment 88172

Or maybe it's not reading the lib library at all?

Although it seems like everything is fine:

data\lib:

LUA:

-- Core API functions implemented in Lua
dofile('data/lib/core/core.lua')

-- Compatibility library for our old Lua API
dofile('data/lib/compat/compat.lua')

-- Debugging helper function for Lua developers
dofile('data/lib/debugging/dump.lua')
dofile('data/lib/debugging/lua_version.lua')

-- Miscellaneous library
dofile('data/lib/miscellaneous/miscellaneous.lua')

data\lib\miscellaneous:

Code:

-- load storages first
dofile('data/lib/miscellaneous/051-storages.lua')

dofile('data/lib/miscellaneous/050-functions.lua')
dofile('data/lib/miscellaneous/055-teleport_item_destinations.lua')

dofile('data/lib/miscellaneous/demonOakQuest.lua')
dofile('data/lib/miscellaneous/killingInTheNameOfQuest.lua')
dofile('data/lib/miscellaneous/svargrondArenaQuest.lua')
dofile('data/lib/miscellaneous/achievements_lib.lua')

Test the theory directly.
print(SvargrondArena.itemPillar)

Xarah · Nov 10, 2024

Xikini said:
Test the theory directly.
print(SvargrondArena.itemPillar)

czouski · Nov 10, 2024

LUA:

local pillarItem = pillarTile:getItemById(1354)

try to do that instead of

LUA:

local pillarItem = pillarTile:getItemById(SvargrondArena.itemPillar)

also idk why but u already have teleport on the tile which should not be there 1387 i believe and if it should then the function for

LUA:

 local teleportItem = Game.createItem(SvargrondArena.itemTeleport, 1, PITS[pit].tp)

should be deleted (if u already have teleports with action/uid on map then only need to remove the pillar ) changed to

LUA:

 local teleportItem = pillarTile:getItemById(1387)

or if u still using ur own code should not even be any teleport code in the code then. only removing pillar because rest is handled by ur movements scripts technically.

Xarah · Nov 10, 2024

Now the stone disappears, but it looks like it's not retrieving information from the lib, because now there's an issue with the teleport:

LUA:

local condition = Condition(CONDITION_OUTFIT)
condition:setTicks(120000)
condition:setOutfit({lookType = 111})

function onStepIn(creature, item, position, fromPosition)
    local player = creature:getPlayer()
    if not player then
        return true
    end

    local playerId = player.uid
    if item.actionid == 25300 then
        player:addCondition(condition)

        player:setStorageValue(Storage.SvargrondArena.Pit, 0)
        player:teleportTo(SvargrondArena.kickPosition)
        player:say('Coward!', TALKTYPE_MONSTER_SAY)
        SvargrondArena.cancelEvents(playerId)
        return true
    end

    local pitId = player:getStorageValue(Storage.SvargrondArena.Pit)
    local arenaId = player:getStorageValue(Storage.SvargrondArena.Arena)
    if pitId > 10 then
        player:teleportTo(SvargrondArena.rewardPosition)
        player:setStorageValue(Storage.SvargrondArena.Pit, 0)

        if arenaId == 1 then
            SvargrondArena.rewardPosition:sendMagicEffect(CONST_ME_FIREWORK_BLUE)
            player:setStorageValue(Storage.SvargrondArena.Greenhorn, 1)
            player:say('Welcome back, little hero!', TALKTYPE_MONSTER_SAY)
        elseif arenaId == 2 then
            SvargrondArena.rewardPosition:sendMagicEffect(CONST_ME_FIREWORK_YELLOW)
            player:setStorageValue(Storage.SvargrondArena.Scrapper, 1)
            player:say('Congratulations, brave warrior!', TALKTYPE_MONSTER_SAY)
        elseif arenaId == 3 then
            SvargrondArena.rewardPosition:sendMagicEffect(CONST_ME_FIREWORK_RED)
            player:setStorageValue(Storage.SvargrondArena.Warlord, 1)
            player:say('Respect and honour to you, champion!', TALKTYPE_MONSTER_SAY)
        end

        player:setStorageValue(Storage.SvargrondArena.Arena, player:getStorageValue(Storage.SvargrondArena.Arena) + 1)
        player:sendTextMessage(MESSAGE_STATUS_CONSOLE_ORANGE, 'Congratulations! You completed ' .. ARENA[arenaId].name .. ' arena, you should take your reward now.')
        player:setStorageValue(ARENA[arenaId].questLog, 2)
        player:addAchievement(ARENA[arenaId].achievement)
        SvargrondArena.cancelEvents(playerId)
        return true
    end

    local occupant = SvargrondArena.getPitOccupant(pitId, player)
    if occupant then
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, occupant:getName() .. ' is currently in the next arena pit. Please wait until ' .. (occupant:getSex() == PLAYERSEX_FEMALE and 's' or '') .. 'he is done fighting.')
        player:teleportTo(fromPosition, true)
        return true
    end

    SvargrondArena.cancelEvents(playerId)
    SvargrondArena.resetPit(pitId)
    SvargrondArena.scheduleKickPlayer(playerId, pitId)
    Game.createMonster(ARENA[arenaId].creatures[pitId], PITS[pitId].summon, false, true)

    player:teleportTo(PITS[pitId].center)
    player:getPosition():sendMagicEffect(CONST_ME_MAGIC_RED)
    player:say('Fight!', TALKTYPE_MONSTER_SAY)
    return true
end

czouski · Nov 10, 2024

yeah so what do you need to do? move it from miscelanous into the main lib file .
also anytime you update that lib folder make sure to RESTART your server.

Xarah · Nov 10, 2024

It didn't help; is there another file responsible for loading the lib files?

czouski · Nov 10, 2024

Xarah said:
It didn't help; is there another file responsible for loading the lib files?

maybe you have duplicate storage entries or files. anyways this is taking too much of my time its 2024 how does otland not have discord so we can help with screenshare. this website is still in 2000 year forgetting aint nobody got dial up and press f5 to actually see if someone responded etc. Forums are dead because only old people are accustomed to them.

Xarah · Nov 10, 2024

I probably don't have anything duplicated; it would show up in the console.

Svargrond Arena

Xarah

Member

czouski

Banned User

Attachments

Xarah

Member

czouski

Banned User

Xarah

Member

czouski

Banned User

Xarah

Member

czouski

Banned User

Xarah

Member

Xikini

Guest

Xarah

Member

czouski

Banned User

Xarah

Member

czouski

Banned User

Xarah

Member

czouski

Banned User

Xarah

Member

Similar threads