• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Solved [TFS 1.0] Lua Script Error: attempt to call global 'doPlayerDepositMoney' (a nil value)

eduardojuniosm

eduardojuniosm

Full Stack Web Developer
Joined
Dec 16, 2013
Messages
99
Reaction score
35
Location
Brazil
I added a banker NPC on my map and now the TFS return this on start:
Code: 
Lua Script Error: [Npc interface]
data/npc/scripts/banco.lua:onCreatureSay
data/npc/scripts/banco.lua:64: attempt to call global 'doPlayerDepositMoney' (a nil value)
stack traceback:
    [C]: in function 'doPlayerDepositMoney'
    data/npc/scripts/banco.lua:64: in function 'callback'
    data/npc/lib/npcsystem/npchandler.lua:393: in function 'onCreatureSay'
    data/npc/scripts/banco.lua:8: in function <data/npc/scripts/banco.lua:8>
My script (banco.lua):
Code: 
local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)
local talkState = {}
local moneyTo = {}
local playerTo = {}
function onCreatureAppear(cid)  npcHandler:onCreatureAppear(cid)  end
function onCreatureDisappear(cid)  npcHandler:onCreatureDisappear(cid)  end
function onCreatureSay(cid, type, msg)  npcHandler:onCreatureSay(cid, type, msg)  end
function onThink()  npcHandler:onThink()  end
local function isValidMoney(money)
  if isNumber(money) == TRUE and money > 0 and money < 999999999 then
  return TRUE
  end
  return FALSE
end
function creatureSayCallback(cid, type, msg)
  if(not npcHandler:isFocused(cid)) then
  return false
  end
  if msgcontains(msg, 'help') or msgcontains(msg, 'offer') then
  selfSay("You can check the {balance} of your bank account, {deposit} money or {withdraw} it. You can also {transfer} money to other characters, provided that they have a vocation.", cid)
  talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Balance ----------------------------
-----------------------------------------------------------------
  elseif msgcontains(msg, 'balance') or msgcontains(msg, 'Balance') then
  selfSay('Your account balance is '..getPlayerBalance(cid)..' gold.', cid)
  talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Help -------------------------------
-----------------------------------------------------------------
  elseif msgcontains(msg, 'basic functions') then
  selfSay('You can check the {balance{ of your bank account, Pdeposit{ money or Pwithdraw{ it. You can also {transfer} money to othercharacters, provided that they have a vocation.', cid)
  talkState[cid] = 0
  elseif msgcontains(msg, 'advanced functions') then
  selfSay('Renting a house has never been this easy. Simply make a bid for an auction. We will check immediately if you haveenough money.', cid)
  talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Deposit ----------------------------
-----------------------------------------------------------------
  elseif msgcontains(msg, 'deposit all') then
  moneyTo[cid] = getPlayerMoney(cid)
  if moneyTo[cid] < 1 then
  selfSay('You don\'t have any money to deposit in you inventory..', cid)
  talkState[cid] = 0
  else
  selfSay('Would you really like to deposit '..moneyTo[cid]..' gold?', cid)
  talkState[cid] = 2
  end
  elseif msgcontains(msg, 'deposit') then
  selfSay("Please tell me how much gold it is you would like to deposit.", cid)
  talkState[cid] = 1
  elseif talkState[cid] == 1 then
  moneyTo[cid] = tonumber(msg)
  if isValidMoney(moneyTo[cid]) == TRUE then
  selfSay('Would you really like to deposit '..moneyTo[cid]..' gold?', cid)
  talkState[cid] = 2
  else
  selfSay('Is isnt valid amount of gold to deposit.', cid)
  talkState[cid] = 0
  end
  elseif talkState[cid] == 2 then
  if msgcontains(msg, 'yes') then
  if doPlayerDepositMoney(cid, moneyTo[cid], 1) ~= TRUE then
  selfSay('You do not have enough gold.', cid)
  else
  selfSay('Alright, we have added the amount of '..moneyTo[cid]..' gold to your balance. You can withdraw your money anytime you want to. Your account balance is ' .. getPlayerBalance(cid) .. '.', cid)
  end
  elseif msgcontains(msg, 'no') then
  selfSay('As you wish. Is there something else I can do for you?', cid)
  end
  talkState[cid] = 0
-----------------------------------------------------------------
---------------------------- Withdraw ---------------------------
-----------------------------------------------------------------
  elseif msgcontains(msg, 'withdraw') then
  selfSay("Please tell me how much gold you would like to withdraw.", cid)
  talkState[cid] = 6
  elseif talkState[cid] == 6 then
  moneyTo[cid] = tonumber(msg)
  if isValidMoney(moneyTo[cid]) == TRUE then
  selfSay('Are you sure you wish to withdraw '..moneyTo[cid]..' gold from your bank account?', cid)
  talkState[cid] = 7
  else
  selfSay('Is isnt valid amount of gold to withdraw.', cid)
  talkState[cid] = 0
  end
  elseif talkState[cid] == 7 then
  if msgcontains(msg, 'yes') then
  if doPlayerWithdrawMoney(cid, moneyTo[cid]) ~= TRUE then
  selfSay('There is not enough gold on your account. Your account balance is '..getPlayerBalance(cid)..'. Please tell me the amount of gold coins you would like to withdraw.', cid)
  else
  selfSay('Here you are, ' .. moneyTo[cid] .. ' gold. Please let me know if there is something else I can do for you.', cid)
  talkState[cid] = 0
  end
  elseif msgcontains(msg, 'no') then
  selfSay('As you wish. Is there something else I can do for you?', cid)
  talkState[cid] = 0
  end
-----------------------------------------------------------------
---------------------------- Transfer ---------------------------
-----------------------------------------------------------------
  elseif msgcontains(msg, 'transfer') then
  selfSay("Please tell me the amount of gold you would like to transfer.", cid)
  talkState[cid] = 11
  elseif talkState[cid] == 11 then
  moneyTo[cid] = tonumber(msg)
  if isValidMoney(moneyTo[cid]) == TRUE then
  selfSay('Who would you like transfer '..moneyTo[cid]..' gold to?', cid)
  talkState[cid] = 12
  else
  selfSay('Is isnt valid amount of gold to transfer.', cid)
  talkState[cid] = 0
  end
  elseif talkState[cid] == 12 then
  playerTo[cid] = msg
  if getCreatureName(cid) == playerTo[cid] then
  selfSay('Ehm, You want transfer money to yourself? Its impossible!', cid)
  talkState[cid] = 0
  return TRUE
  end
  if playerExists(playerTo[cid]) then
  selfSay('So you would like to transfer ' .. moneyTo[cid] .. ' gold to "' .. playerTo[cid] .. '" ?', cid)
  talkState[cid] = 13
  else
  selfSay('Player with name "' .. playerTo[cid] .. '" doesnt exist.', cid)
  talkState[cid] = 0
  end
  elseif talkState[cid] == 13 then
  if msgcontains(msg, 'yes') then
  if getPlayerBalance(cid) < moneyTo[cid] then
  selfSay('You dont have enought money on your bank account.', cid)
  return TRUE
  end
  if doPlayerTransferMoneyTo(cid, playerTo[cid], moneyTo[cid]) ~= TRUE then
  selfSay('This player does not exist on this world or have no vocation.', cid)
  else
  selfSay('You have transferred ' .. moneyTo[cid] .. ' gold to "' .. playerTo[cid] ..' ".', cid)
  playerTo[cid] = nil
  end
  elseif msgcontains(msg, 'no') then
  selfSay('As you wish. Is there something else I can do for you?', cid)
  end
  talkState[cid] = 0
  end
  return TRUE
end
npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())
Can anyone help me? Thank you in advance!
 
Last edited:
Sort by date Sort by votes
@ 050-functions.lua
Code: 
function doPlayerDepositMoney(cid, amount)
    if(not getBooleanFromString(getConfigInfo('bankSystem'))) then
        return false
    end

    if(not doPlayerRemoveMoney(cid, amount)) then
        return false
    end

    doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
    return true
end
 
Upvote 0 Downvote
Now TFS returns this:
Code: 
Lua Script Error: [Npc interface]
data/npc/scripts/banco.lua:onCreatureSay
data/global.lua:886: attempt to call global 'getBooleanFromString' (a nil value)
stack traceback:
   [C]: in function 'getBooleanFromString'
   data/global.lua:886: in function 'doPlayerDepositMoney'
   data/npc/scripts/banco.lua:70: in function 'callback'
   data/npc/lib/npcsystem/npchandler.lua:393: in function 'onCreatureSay'
   data/npc/scripts/banco.lua:10: in function <data/npc/scripts/banco.lua:10>
 
Upvote 0 Downvote
Code: 
function doPlayerDepositMoney(cid, amount)
   
   if(not doPlayerRemoveMoney(cid, amount)) then
  return false
  end
     
   doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
   
  return true
end

With upgraded 1.0 functions!

Edit: And nicely tabbed lol.
 
Upvote 0 Downvote
dominique120 said:
Code: 
function doPlayerDepositMoney(cid, amount)
  
   if(not doPlayerRemoveMoney(cid, amount)) then
  return false
  end
    
   doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
  
  return true
end

With upgraded 1.0 functions!

Edit: And nicely tabbed lol.
Click to expand...

Someone needs a lesson in tabbing :)
Code: 
function doPlayerDepositMoney(cid, amount) 
    if(not doPlayerRemoveMoney(cid, amount)) then
        return false
    end
    doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
return true
end
 
Upvote 0 Downvote
WibbenZ said:
Someone needs a lesson in tabbing :)
Code: 
function doPlayerDepositMoney(cid, amount)
    if(not doPlayerRemoveMoney(cid, amount)) then
        return false
    end
    doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
return true
end
Click to expand...
Seems like you need a lesson as well :p
Code: 
function doPlayerDepositMoney(cid, amount)
    if not doPlayerRemoveMoney(cid, amount) then
        return false
    end
       
    doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
    return true
end
 
Upvote 0 Downvote
Ninja said:
Seems like you need a lesson as well :p
Code: 
function doPlayerDepositMoney(cid, amount)
    if not doPlayerRemoveMoney(cid, amount) then
        return false
    end
      
    doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
    return true
end
Click to expand...

Haha, I prefer to have everything in one piece, looks to messy otherwise atleast for me. Used to do like that. Same with
Code: 
if statment then
looks to messy and not professional. + What elf said. There for I always use
Code: 
if(statment) then

Why do you use
Code: 
if statment then

? xD
 
Upvote 0 Downvote
Ninja said:
This were about how you indent your code and not why I skip parentheses but if you want an answer, then take a look here. :p
Click to expand...
"Alright thanks, about parentheses will it affect the preformence how i used it?"
"Not really, no. It's more about them being redundant than a performance issue."

I'll stick with what Elf said, after all he and Stian made most of the work on 0.4, and its 0.4 I mainly use. :p
 
Upvote 0 Downvote
Sorry to bump an older thread but was facing something similar and after correct, replace or change the code inside global.lua
from this:
Lua: 
function doPlayerDepositAllMoney(cid)
    return doPlayerDepositMoney(cid, getPlayerMoney(cid))
end
to this
Code: 
function doPlayerDepositMoney(cid, amount)
    if not doPlayerRemoveMoney(cid, amount) then
        return false
    end
     
    doPlayerSetBalance(cid, getPlayerBalance(cid) + amount)
    return true
end
the player can deposit the money into the banker npc. it's even displays the account balance, the problem is when player try to withdraw the money the exe console is sending this

Code: 
attempt to call global 'doPlayerWithdrawMoney' (a nil value)
and in global.lua this is registered
Code: 
function doPlayerWithdrawAllMoney(cid)
    return doPlayerWithdrawMoney(cid, getPlayerBalance(cid))
end
i use tfs 1.5
 
Upvote 0 Downvote

Similar threads

E
  • Question
TFS 0.X 8.60 0.4 NPC Promotion with VIP coin price ID: 11192 Amount: 100 script no function
Replies
2
Views
181
Mateus Robeerto
Mateus Robeerto
demonrage
  • Question
Put item check on this npc
Replies
0
Views
68
demonrage
demonrage
Shoorkill
  • Question
[TFS 1.5]reset level, life and mana, when acquiring vocation evolution
Replies
2
Views
666
Mateus Robeerto
Mateus Robeerto
potinho
  • Question
Lua [TFS 0.X] NPC - Correct doRemoveMoney
Replies
10
Views
619
Mateus Robeerto
Mateus Robeerto
J
  • Question
Npc Problem Help Please
Replies
2
Views
364
Mateus Robeerto
Mateus Robeerto
V
  • Question
NPC adds serial to item
Replies
0
Views
329
vitorelias1
V
J
  • Solved
Grizzly Adams tfs1.5 problem
Replies
10
Views
760
jareczekjsp
J
S
  • Question
Svarground Arena script bug
Replies
0
Views
381
specail
S
Mateus Robeerto
  • Question
TFS 1.X+ I want to learn basic TFS 1X functions
Replies
13
Views
868
Mateus Robeerto
Mateus Robeerto
E
  • Question
TFS 0.X 0.4 Recovery Exp only recovers levels from level 1 to 100, it does not recover levels from level 717217, I want it to recover levels 1 until 717217
Replies
1
Views
180
Enderlop
E
Back
Top