TFS 1.2 What im doing wrong in this storage check

[Tbol]

Hello, trying to add storage check if player dont have storage X, npc would send message "You have to do blalbalbla first" and if he do have X storage everything would go like normal.

so i created local like

local testMission = { 
    [1] = {
        rankName = "test",
        mainStorage = 13251, 
        needstorage = 13250,

its not full config but it gives a sample

then im doing this which doesnt work

function creatureSayCallback(cid, type, msg)
    local player = Player(cid)
    local vocationId = player:getVocation():getId()

    if not npcHandler:isFocused(cid) then
        if msg == "hi" or msg == "hello" then
            npcHandler:addFocus(cid)

            if player:getStorageValue(testMission.needstorage) then
            npcHandler:say("Hello, " .. player:getName() .. ". test mission: " .. getRanksString() .. ".", cid)
            npcHandler.topic[cid] = 0
        else
            npcHandler:say("You have to finish previous missions first!", cid)
        end
    else
            return false
        end
    end

so as you can see trying to add getstoragevalue if he doesnt have that storage it sends npcHandler:say("You have to finish previous missions first!", cid) but if he does have it sends
npcHandler:say("Hello, " .. player:getName() .. ". test mission: " .. getRanksString() .. ".", cid)
npcHandler.topic[cid] = 0
but my shit doesnt work

 

[Xikini]

Hello, trying to add storage check if player dont have storage X, npc would send message "You have to do blalbalbla first" and if he do have X storage everything would go like normal.

so i created local like

local testMission = {
    [1] = {
        rankName = "test",
        mainStorage = 13251,
        needstorage = 13250,

its not full config but it gives a sample

then im doing this which doesnt work

function creatureSayCallback(cid, type, msg)
    local player = Player(cid)
    local vocationId = player:getVocation():getId()

    if not npcHandler:isFocused(cid) then
        if msg == "hi" or msg == "hello" then
            npcHandler:addFocus(cid)

            if player:getStorageValue(testMission.needstorage) then
            npcHandler:say("Hello, " .. player:getName() .. ". test mission: " .. getRanksString() .. ".", cid)
            npcHandler.topic[cid] = 0
        else
            npcHandler:say("You have to finish previous missions first!", cid)
        end
    else
            return false
        end
    end

so as you can see trying to add getstoragevalue if he doesnt have that storage it sends npcHandler:say("You have to finish previous missions first!", cid) but if he does have it sends
npcHandler:say("Hello, " .. player:getName() .. ". test mission: " .. getRanksString() .. ".", cid)
npcHandler.topic[cid] = 0
but my shit doesnt work

Your table is setup like this

tableName[key].key = value

But you are currently accessing it like this

tableName.key = value

So instead of this..

testMission.needstorage

you need to do this

testMission[1].needstorage

 

[Tbol]

Your table is setup like this

tableName[key].key = value

But you are currently accessing it like this

tableName.key = value

So instead of this..

testMission.needstorage

you need to do this

testMission[1].needstorage

Hmm unfortunately didnt worked

 

[Xikini]

Hmm unfortunately didnt worked

Post the errors you're getting, and the full script.

 

[Tbol]

Post the errors you're getting, and the full script.

Getting no errors it just still allows to speak with that npc without having that storage

local keywordHandler = KeywordHandler:new()local npcHandler = NpcHandler:new(k - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

 

[Xikini]

Getting no errors it just still allows to speak with that npc without having that storage

local keywordHandler = KeywordHandler:new()local npcHandler = NpcHandler:new(k - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

If you left the code as-is, then you aren't comparing the storage value to anything.

change

if player:getStorageValue(rankMission[1].needstorage) then

to

if player:getStorageValue(rankMission[1].needstorage) > 0 then

    if not npcHandler:isFocused(cid) then
        if msg == "hi" or msg == "hello" then
            npcHandler:addFocus(cid)
            if player:getStorageValue(rankMission[1].needstorage) > 0 then
                npcHandler:say("Welcome, " .. player:getName() .. ". Choose mission by rank: " .. getRanksString() .. ".", cid)
                npcHandler.topic[cid] = 0
            else
                npcHandler:say("You have to finish Angel missions first!", cid)
                -- probably want to release focus here
            end
        else
            return false
        end
    end

 

[Tbol]

If you left the code as-is, then you aren't comparing the storage value to anything.

change

if player:getStorageValue(rankMission[1].needstorage) then

to

if player:getStorageValue(rankMission[1].needstorage) > 0 then

    if not npcHandler:isFocused(cid) then
        if msg == "hi" or msg == "hello" then
            npcHandler:addFocus(cid)
            if player:getStorageValue(rankMission[1].needstorage) > 0 then
                npcHandler:say("Welcome, " .. player:getName() .. ". Choose mission by rank: " .. getRanksString() .. ".", cid)
                npcHandler.topic[cid] = 0
            else
                npcHandler:say("You have to finish Angel missions first!", cid)
                -- probably want to release focus here
            end
        else
            return false
        end
    end

Still same

 

[Xikini]

Still same

Is the npc saying anything?

Give us screenshots or something.
I don't want to sit here and guess.

 

[Ascuas Funkeln]

Hello, trying to add storage check if player dont have storage X, npc would send message "You have to do blalbalbla first" and if he do have X storage everything would go like normal.

so i created local like

local testMission = {
    [1] = {
        rankName = "test",
        mainStorage = 13251,
        needstorage = 13250,

its not full config but it gives a sample

then im doing this which doesnt work

function creatureSayCallback(cid, type, msg)
    local player = Player(cid)
    local vocationId = player:getVocation():getId()

    if not npcHandler:isFocused(cid) then
        if msg == "hi" or msg == "hello" then
            npcHandler:addFocus(cid)

            if player:getStorageValue(testMission.needstorage) then
            npcHandler:say("Hello, " .. player:getName() .. ". test mission: " .. getRanksString() .. ".", cid)
            npcHandler.topic[cid] = 0
        else
            npcHandler:say("You have to finish previous missions first!", cid)
        end
    else
            return false
        end
    end

so as you can see trying to add getstoragevalue if he doesnt have that storage it sends npcHandler:say("You have to finish previous missions first!", cid) but if he does have it sends
npcHandler:say("Hello, " .. player:getName() .. ". test mission: " .. getRanksString() .. ".", cid)
npcHandler.topic[cid] = 0
but my shit doesnt work

You have
function onCreatureSay(cid, type, msg) npcHandler:onCreatureSay(cid, type, msg) end
and other functions define in script?

 

[Tbol]

Is the npc saying anything?

Give us screenshots or something.
I don't want to sit here and guess.

Yes it says
npcHandler:say("Welcome, " .. player:getName() .. ". Choose mission by rank: " .. getRanksString() .. ".", cid)

 

[Xikini]

Yes it says
npcHandler:say("Welcome, " .. player:getName() .. ". Choose mission by rank: " .. getRanksString() .. ".", cid)

Then your character has that storage above 0.

Reset the storage, or create a new character to test.

    if not npcHandler:isFocused(cid) then
        if msg == "hi" or msg == "hello" then
            npcHandler:addFocus(cid)
            print("Player storage value = " .. player:getStorageValue(rankMission[1].needstorage))
            if player:getStorageValue(rankMission[1].needstorage) > 0 then
                npcHandler:say("Welcome, " .. player:getName() .. ". Choose mission by rank: " .. getRanksString() .. ".", cid)
                npcHandler.topic[cid] = 0
            else
                npcHandler:say("You have to finish Angel missions first!", cid)
                -- probably want to release focus here
            end
        else
            return false
        end
    end

 

[Tbol]

Then your character has that storage above 0.

Reset the storage, or create a new character to test.

    if not npcHandler:isFocused(cid) then
        if msg == "hi" or msg == "hello" then
            npcHandler:addFocus(cid)
            print("Player storage value = " .. player:getStorageValue(rankMission[1].needstorage))
            if player:getStorageValue(rankMission[1].needstorage) > 0 then
                npcHandler:say("Welcome, " .. player:getName() .. ". Choose mission by rank: " .. getRanksString() .. ".", cid)
                npcHandler.topic[cid] = 0
            else
                npcHandler:say("You have to finish Angel missions first!", cid)
                -- probably want to release focus here
            end
        else
            return false
        end
    end

Yea you right somehow it got that storage. How no idea how. But it works now thanks