TFS 1.X+ TFS 1.3 onSay param broken...

[Itutorial]

So I am making a banking code and I can't seem to use param at all...

function onSay(player, words, param)
    if words == "!balance" then
        player:popupFYI("[Balance]: "..player:getBankBalance())
        return false
   
    elseif words == "!deposit" then
        if not param then
            player:sendCancelMessage("Usage: !deposit all / !deposit amount")
            return false
        end
       
        if param == "all" then
            local amount = player:getMoney()
           
            if not amount then
                player:sendCancelMessage("You do not have any gold to deposit.")
                return false
            end
           
            player:removeMoney(amount)
            local oldBalance = player:getBankBalance()
            player:setBankBalance(player:getBankBalance() + amount)
            player:popupFYI("[Old Balance]: "..oldBalance.."\n[New Balance]: "..player:getBankBalance())
            return false
        else
            local amount = tonumber(param)
           
            if amount < 0 or amount > 100000000 then
                player:sendCancelMessage("You can only deposit 1-100kk gold at a time.")
                return false
            end
           
            if not player:removeMoney(amount) then
                player:sendCancelMessage("You do not have that much gold.")
                return false
            end
           
            local oldBalance = player:getBankBalance()
            player:setBankBalance(player:getBankBalance() + amount)
            player:popupFYI("[Old Balance]: "..oldBalance.."\n[New Balance]: "..player:getBankBalance())
            return false
        end
       
       
       
       
    end
    return false
end

I can use !balance but I can't do !deposit all or !deposit 1000. I cant even print the param it is just empty....

in xml

<talkaction words="!balance" separator=" " script="banking.lua" />
    <talkaction words="!deposit" separator=" " script="banking.lua" />
    <talkaction words="!withdraw" separator=" " script="banking.lua" />
    <talkaction words="!transfer" separator=" " script="banking.lua" />

 

[Itutorial]

This can be done simpler as I did in my script: local amount = math.abs(tonumber(param) or 0) < this will always return a positive, easy and bulletproof number

 if param:find("-") then
                param = param:gsub("-", "")
            end
            amount = tonumber(param)
end

This check is wrong, use if amount <= 0 instead of if amount < 0, unless you want to transfer, withdraw or deposit 0 coins

        if amount < 0 or amount > 100000000 then

Actually forgot to check the amount transfered too so its 1-100kk. updated

 

[Codinablack]

Glad to see you got it the way you intended, while helping TFS find and solve another bug