CreatureEvent [TFS 1.3 / 1.4] Upgrade System

[Xikini]

oof.
Our armor/weapon systems are eerily congruent with this release.

Good job nonetheless!
It's great to see this community still growing and contributing.

 

[Infernum]

Not many people are using TFS 1.3, not to mention revscripts. It's too fresh.

If people are using 1.3 but not updating a development version of a server engine they shouldn't bother using it.
The new scripts system will be in the release so it'll be better to use it in the long run when people actually start using the 1.3 release.
Whatever though, just thinking about ease of access/installation for user (not to mention for yourself as well, when developing large systems like this)

 

[oen432]

If people are using 1.3 but not updating a development version of a server engine they shouldn't bother using it.
The new scripts system will be in the release so it'll be better to use it in the long run when people actually start using the 1.3 release.
Whatever though, just thinking about ease of access/installation for user (not to mention for yourself as well, when developing large systems like this)

I'll make next feature using revscripts then, will see. I'm creating features for TFS 1.3 only and hope that there are people updating their servers because of that. Using revscripts can be even better that way... Sure.

 

[Evil Hero]

mind if I package it up for revscriptsys? so you can include it here aswell then

 

[oen432]

mind if I package it up for revscriptsys? so you can include it here aswell then

No need, I'll make update at some point.

 

[Soaresdk]

where can I download TFS 1.3

 

[oen432]

onde posso baixar o TFS 1.3

Here otland/forgottenserver (https://github.com/otland/forgottenserver)

 

[Shadow_]

Thank you for your contributions definitely going to use it in my 2 projects

 

[sakero]

Nice. I was working on the same system, but yours is much more elaborate xD

great contribution.

PD: Devil has good systems.

 

[oen432]

Nice. I was working on the same system, but yours is much more elaborate xD

great contribution.

PD: Devil has good systems.
View attachment 36622

My system includes unidentified items and scrolls of identification too
I have made teleport scrolls already - Action - [TFS 1.X] Town Portals like in Diablo (https://otland.net/threads/tfs-1-x-town-portals-like-in-diablo.263705/)
You can find some Diablo-style features that I made.

 

[sakero]

Yes I saw it, is very good

 

[Aeronx]

Im implementing this on TFS 1.2 instead of 3. I get and error, not finding getCustomAttribute function is non-existent. Is something that its from tfs 1.3 or its just missing from the system?

 

[oen432]

Im implementing this on TFS 1.2 instead of 3. I get and error, not finding getCustomAttribute function is non-existent. Is something that its from tfs 1.3 or its just missing from the system?

Added in 1.3.

Item custom attributes by Mkalo · Pull Request #1997 · otland/forgottenserver

Introducing 3 new methods to Item class to Lua API: item:setCustomAttribute(key, value) item:getCustomAttribute(key) item:removeCustomAttribute(key) Key types: string or number Value types: string,...

github.com

 

[oen432]

Had to rewrite attributes refreshing...

[1.1.2] - 2019-05-26

• Rewritten attributes refreshing when removing items
• Removed onMoveItem event usage

Can't update first post anymore, so before mods do that, here is new version.
Inside data/events/scripts/player.lua, find Player:onMoveItem and remove

onUpgradeMove(self, item, count, fromPosition, toPosition, fromCylinder, toCylinder)

It's not needed anymore. Only upgrade_system_core.lua file needs to be replaced.

 

[Aeronx]

there's a small bug on your system. If you have summons, and a summon kills the monster, lasthitkiller will give you problems.

 

[oen432]

there's a small bug on your system. If you have summons, and a summon kills the monster, lasthitkiller will give you problems.

if not lasthitkiller:isPlayer() or not creature:isMonster() or not corpse or not corpse:isContainer() then
    return true
  end

I'm checking if it's a player.

 

[Aeronx]

Lua Script Error: [CreatureScript Interface]
data/creaturescripts/scripts/upgrade_system_cs.lua:onDeath
data/upgrade_system_core.lua:366: attempt to index local 'lasthitkiller' (a nil value)
stack traceback:
        [C]: in function '__index'
        data/upgrade_system_core.lua:366: in function <data/upgrade_system_core.lua:365>

That happens when my summon kills the monster.

Also, a function to add specific attributes would be great, since all being left to rng can sometimes be wrong.

 

[oen432]

Also, a function to add specific attributes would be great

That's why I made Unique items where you can predefine which attributes will be rolled every time. Very known in RPG games like Diablo and PoE.
Thank you for noticing this error, fixed.

[1.1.3] - 2019-05-26

• Fixed error when Summon kills a creature
• Added Summons support

If you are updating, replace core script only.

 

[Aeronx]

Yeah i understand the unique items part, what i mean, is a way to add with another gem an attribute of you choosing.
a function like
Function item.addSpecialAttribute(attribute, value)
Which will let you create as many and different gems as you want with the different attributes and values of your liking.
Its just additional features and customization.

 

[oen432]

Yeah i understand the unique items part, what i mean, is a way to add with another gem an attribute of you choosing.
a function like
Function item.addSpecialAttribute(attribute, value)
Which will let you create as many and different gems as you want with the different attributes and values of your liking.

44 new gems, yeah, sure
I think that amount of RNG is not too big but actually nice. No need to make everything so easy. I'm not going to implement that, I don't see the need, sorry.
Let them have fun trying to get that perfect attributes, they would get way more joy out of it.