CreatureEvent [TFS 1.3 / 1.4] Upgrade System

[oen432]

Lua Script Error: [Event Interface]
data/events/scripts/player.lualayer@onMoveItem
data/lib/crafting/upgrade_system_core.lua:840: attempt to index local 'thing' (a nil value)
stack traceback:
[C]: in function '__index'
data/lib/crafting/upgrade_system_core.lua:840: in function 'onItemUpgradeLook'
data/events/scripts/player.lua:332: in function <data/events/scripts/player.lua:330>
otservbr 1.3

This is for OTServBR.

Looks like onMoveItem is not reaching last return. Just tried and there are few lines to edit.

    -- Handle move items to the ground
    if toPosition.x ~= CONTAINER_POSITION then
        if item:isContainer() then
            local container = Container(item.uid)
            for categoryId = LOOT_START, LOOT_END do
                if container:hasQuickLootCategory(categoryId) then
                    container:removeQuickLootCategory(categoryId)
                    self:setQuickLootBackpack(categoryId, nil)
                end
            end
        end

        return true -- HERE
    end


    -- Reward System
    if toPosition.x == CONTAINER_POSITION then
        local containerId = toPosition.y - 64
        local container = self:getContainerById(containerId)
        if not container then
            return true -- HERE
        end

And return true at the end of this function. Change these lines to

return us_onMoveItem(self, item, fromPosition, toPosition)

 

[matthew123456]

This is for OTServBR.

ahh ok fixed it thanks

 

[pedrohfw]

> Loading config: config.lua
> Establishing database connection... MySQL 6.1.6
> Running database manager
No tables were optimized.
> Loading vocations
> Loading items
> Loading script systems
> Loaded Upgrade System v2.4.4

[Warning - Events::load] Unknown player method: onItemMoved

> Loading monsters

Do anyone know how to fix?

 

[oen432]

[Warning - Events::load] Unknown player method: onItemMoved


Do anyone know how to fix?

TFS 1.3?

 

[Awesomedudei]

[Warning - Events::load] Unknown player method: onItemMoved


Do anyone know how to fix?

Did you enable
<event class="Player" method="onItemMoved" enabled="1" />
?

 

[oen432]

Did you enable
<event class="Player" method="onItemMoved" enabled="1" />
?

He doesn't have this event added to sources, probably not using 1.3.

 

[Awesomedudei]

He doesn't have this event added to sources, probably not using 1.3.

Ahh i see

 

[Rhyund]

I got erros:



TFS 1.3

 

[oen432]

I got erros:

View attachment 48328

TFS 1.3

Use latest version from Github...

 

[Rhyund]

Use latest version from Github...

It is the last version from there

 

[oen432]

It is the last version from there

No, no it's not. Do you see isContainer anywhere near these lines Oen44/TFS-Upgrade-System (https://github.com/Oen44/TFS-Upgrade-System/blob/master/upgrade_system_core.lua#L651-L652) ? Because errors are about these lines.

 

[Rhyund]

No, no it's not. Do you see isContainer anywhere near these lines Oen44/TFS-Upgrade-System (https://github.com/Oen44/TFS-Upgrade-System/blob/master/upgrade_system_core.lua#L651-L652) ? Because errors are about these lines.

Oh, my mistake! I was thinking about TFS, not your system

Now it is working perfectly, thank you

 

[sikret]

Someone know the right items ID's? I using TFS 1.3 and id's on first post are different from that on movie.. I can't figure out how get exactly that items from tutorial

 

[oen432]

Someone know the right items ID's? I using TFS 1.3 and id's on first post are different from that on movie.. I can't figure out how get exactly that items from tutorial

These items are custom.

 

[noshirtstan]

Hey man, I'm getting this error when I try to use the upgrade crystal.

Post automatically merged: Aug 23, 2020

Got it fixed up and working! Thanks man amazing addon!

 

[Przemyslaw1101]

Hey, can someone help me understand, why is this exist? I using clear 1.3 TFS

target:registerEvent("UpgradeSystemHealth")
target:registerEvent("UpgradeSystemDeath")
function Creature:onChangeOutfit(outfit)
    return true
end

function Creature:onAreaCombat(tile, isAggressive)
    return RETURNVALUE_NOERROR
end

function Creature:onTargetCombat(target)
    return RETURNVALUE_NOERROR
end

function Creature:onHear(speaker, words, type)
end

 

[oen432]

Hey, can someone help me understand, why is this exist? I using clear 1.3 TFS

target:registerEvent("UpgradeSystemHealth")
target:registerEvent("UpgradeSystemDeath")
function Creature:onChangeOutfit(outfit)
    return true
end

function Creature:onAreaCombat(tile, isAggressive)
    return RETURNVALUE_NOERROR
end

function Creature:onTargetCombat(target)
    return RETURNVALUE_NOERROR
end

function Creature:onHear(speaker, words, type)
end

Oh boy...

function Creature:onChangeOutfit(outfit)
    return true
end

function Creature:onAreaCombat(tile, isAggressive)
    return RETURNVALUE_NOERROR
end

function Creature:onTargetCombat(target)
    target:registerEvent("UpgradeSystemHealth")
    target:registerEvent("UpgradeSystemDeath")
    return RETURNVALUE_NOERROR
end

function Creature:onHear(speaker, words, type)
end

 

[Shadow_]

enchantments are causing quite a bit of server lag, especially on large groups of monsters. For instance with this weapon: 12:55 You see a legendary Slayer Of Domination +2 (Atk:12900, sword fighting +3, critical hit chance +3%, critical hit damage +50%, life leech chance +3%, life leech amount +25%, mana leech chance +3%, mana leech amount +25%). Item Level: 5 20% to cast Energy Strike on Attack dealing 1-13844 damage 20% to cast Ice Strike on Attack dealing 1-574006 damage Earth Damage +1% 20% to cast Flame Strike on Attack dealing 1-107113 damage It can only be wielded properly by knights and elite knights of level 50000 or higher. It weighs 50.00 oz. This weapon proves how you were powerful inront of deepling spellsinger!

The ping jumps from my normal 32-50ms to 200-250+ and on massive groups of monsters it can go up to 400 on the initial attack start But with a normal weapon without enchantments the ping does not jump higher than 150-180 and the lag difference is pretty noticeable.

 

[miguelshta]

Error:

Lua Script Error: [Action Interface]
data/actions/scripts/upgrade_system_actions.lua:onUse
data/upgrade_system_core.lua:989: bad argument #1 to 'random' (interval is empty)
stack traceback:
        [C]: in ?
        [C]: in function 'math.random'
        data/upgrade_system_core.lua:989: in method 'rollAttribute'
        data/upgrade_system_core.lua:69: in function 'us_onUse'
        (...tail calls...)

 

[oen432]

Error:

Lua Script Error: [Action Interface]
data/actions/scripts/upgrade_system_actions.lua:onUse
data/upgrade_system_core.lua:989: bad argument #1 to 'random' (interval is empty)
stack traceback:
        [C]: in ?
        [C]: in function 'math.random'
        data/upgrade_system_core.lua:989: in method 'rollAttribute'
        data/upgrade_system_core.lua:69: in function 'us_onUse'
        (...tail calls...)

Check your config, looks like you missed or misspelled something.