TFS 1.4.2 onMoveItem does not react?

[Marko999x]

For some reason item can still be moved, idk why.
It worked perfect on TFS 1.5 while TFS 1.4.2 react weird.
Maybe you guys can see the problem here

local ids = {9999, 6000}

local ec = EventCallback

ec.onMoveItem = function(self, item, count, fromPosition, toPosition, fromCylinder, toCylinder)
    if table.contains(ids, item:getActionId()) and toPosition.x ~= CONTAINER_POSITION then
        self:sendTextMessage(MESSAGE_INFO_DESCR, 'This item can not be moved.')
        return RETURNVALUE_NOTPOSSIBLE
    end
    return RETURNVALUE_NOERROR

end
ec:register()

 

[Codinablack]

I just found something we could attribute the weird behavior on the system

TFS-1.5-Downgrades/data/scripts/lib/event_callbacks.lua at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

The system uses pairs as the iterator to iterate through an array, it should be ipairs to fully guaranteed the order of execution.


Even if you apply the fix I mentioned? For the onMoveItem

That is a helluva catch. Now I am undecided which version I want to use, I suppose the nekiro version is still better once switched to ipairs.

The thing is this, 1.4.2 is the version we were talking about having the problem on, not nekiro's downgrade. So now I am curious what server @Xikini is using?

 

[Roddet]

Both systems are pretty much the same, they use the same base (at least nekiro's).
I would definitely choose 1.5 version over 1.4.2, yep!

 

[Xikini]

That is a helluva catch. Now I am undecided which version I want to use, I suppose the nekiro version is still better once switched to ipairs.

The thing is this, 1.4.2 is the version we were talking about having the problem on, not nekiro's downgrade. So now I am curious what server @Xikini is using?

Default 1.4.2
But I mean, I'm not really using it. xD
Only installed it to do the free scripting service.

 

[Evil Hero]

I would just update eventcallback.lua to the one from master and apply the necessary changes in the event folder lua files and everything should be working correct then, it's also up to date then

 

[Mateus Robeerto]

My base has been modified and updated with 123 commits by Evil Punker. Now it's at 70 commits, totaling 193 that have been updated in my source. I've tested it several times and haven't noticed anything strange; everything seems to be working well. However, can someone confirm if everything is okay or not? I've tried inputting -1, -2, -3 all the way to -99999, and it has worked fine; I didn't notice anything unusual. If I don't use negative numbers, it doesn't work; it's necessary to use -1 or -3 and so on. I've attached a video for you to better understand.

If I use a strange negative number like '-1231545', is there no problem? If not, I'll feel relieved and can create other systems the way I want. Thank you!

https://imgur.com/MzboGL2

 

[Roddet]

Just apply the fixes I mentioned or update your eventcallback.lua as Evil Hero suggested and all should be ok.

If I don't use negative numbers, it doesn't work; it's necessary to use -1 or 2- and so on

Assuming that you only have that callback and the default callback, could be possible that the callback with negative index is being executed after the default callback <index: 0> due the use of pairs instead of ipairs

 

[Mateus Robeerto]

Assuming that you only have that callback and the default callback, could be possible that the callback with negative index is being executed after the default callback <index: 0> due the use of pairs instead of ipairs

My TFS 1.4.3 base was updated three months ago, so everything is fine, thank God.