[TFS 1.4] Small Upgrade System (allowed wand and rods)

[Zarosiano]

New update of the system, it is no longer small, but it is still in a single file, it is possible that problems may be found, but if you want to use it and test it, it is welcome, any error, or suggestion you can leave it in the comments, this way I will find out and then I will do my best to update it one more time.

¡Warning!
The system will only work correctly if you are using the latest version of TFS master, to be sure, you must use the version that contains the latest changes of today, November 29, 2021

¡The File!
The file is a bit big so I will upload it to a repository on github and they must download it from there, Click Here to see the file.
Remember: that the file must be located in the data/scripts/ folder
Não se esqueça de acionar os seguintes eventos no arquivo events.xml

<event class="Creature" method="onTargetCombat" habilitado="1" />
...
<event class="Player" method="onItemMoved" enabled="1" />

Do que se trata este sistema?
Este é um sistema simples que atualiza os atributos do item.
por exemplo:
Ataque de uma arma
A armadura de uma perna
As habilidades de um escudo ou outra coisa
em geral, qualquer atributo pode ser atualizável

Você deve ter em mente que nem todos os atributos podem ser atualizados, mas aqui vou deixar uma lista dos atributos que podem ser atualizados

ataque
defesa
extradefesa
armaduras
varinhaDanos
elementoDanos
luta de punho
clube de luta
luta de espadas
luta de machado
luta à distância
blindagem
pescaria
saúde máxima
Maximo mana
nível mágico
saúde regular
reg mana
Rapidez
chance de acerto crítico
dano extra crítico
chance de sanguessuga de pontos de vida
quantidade de sanguessuga de pontos de vida
chance de sanguessuga de pontos de mana
quantidade de sanguessuga de pontos de mana

I have the latest version of TFS 1.4. And I use client 10.98. The specialskills don't work... the item just boosts the other stats. Do I need anything else besides this script?

 

[beenii]

how remplace getAbilities()?

New update of the system, it is no longer small, but it is still in a single file, it is possible that problems may be found, but if you want to use it and test it, it is welcome, any error, or suggestion you can leave it in the comments, this way I will find out and then I will do my best to update it one more time.

¡Warning!
The system will only work correctly if you are using the latest version of TFS master, to be sure, you must use the version that contains the latest changes of today, November 29, 2021

¡The File!
The file is a bit big so I will upload it to a repository on github and they must download it from there, Click Here to see the file.
Remember: that the file must be located in the data/scripts/ folder
Don't forget to trigger the following events in the events.xml file

<event class="Creature" method="onTargetCombat" enabled="1" />
...
<event class="Player" method="onItemMoved" enabled="1" />

¿What is this system about?
This is a simple system that updates item attributes.
per example:
Attack from a weapon
The armor of an legs
The abilities of a shield or something else
in general any attribute can be upgradeable

You must bear in mind that not all attributes can be upgrade, but here I will leave a list of the attributes that can be upgrade

attack
defense
extraDefense
armor
wandDamage
elementDamage
fist fighting
club fighting
sword fighting
axe fighting
distance fighting
shielding
fishing
max health
max mana
magic level
reg health
reg mana
speed
critical hit chance
critical extra damage
hitpoints leech chance
hitpoints leech amount
manapoints leech chance
mana points leech amount

What value does that getAbilities() function return? The truth is that I am going to simplify the system but that function stops me, how can I eliminate it?

Since I only look for 1 attack point to the weapons, 1 arm to the other items with arm, and 1 magic point to the wands for each level.
I don't need any of the other skills, just those 3 things xD

Could you help me modify it to eliminate that getAbilities() function?

 

[Mahdi10]

I want to disable upgrading any weapon type, changing all validWeapons to false is enough for this?

 

[Sarah Wesker]

I want to disable upgrading any weapon type, changing all validWeapons to false is enough for this?

that table is not for that.

however you can do what you want by modifying this function:

Item upgrade system, with the possibility of improving the damage of wands

Item upgrade system, with the possibility of improving the damage of wands - upgrading_system.lua

gist.github.com

You can also add a check here if you don't want to modify the above function:

if target:getType():getWeaponType() ~= WEAPON_NONE then
    player:sendCancelMessage("You can't use this.")
    return true
end

though remember that shields have a weapon type, WEAPON_SHIELD, so you better check each type, or create a table to use table.contains

if table.contains({WEAPON_SWORD, WEAPON_WAND}, target:getType():getWeaponType()) then
    player:sendCancelMessage("You can't use this.")
    return true
end

 

[pips]

I want to disable upgrading any weapon type, changing all validWeapons to false is enough for this?

that table is not for that.

however you can do what you want by modifying this function:

Item upgrade system, with the possibility of improving the damage of wands

Item upgrade system, with the possibility of improving the damage of wands - upgrading_system.lua

gist.github.com

You can also add a check here if you don't want to modify the above function:
View attachment 74451

if target:getType():getWeaponType() ~= WEAPON_NONE then
    player:sendCancelMessage("You can't use this.")
    return true
end

though remember that shields have a weapon type, WEAPON_SHIELD, so you better check each type, or create a table to use table.contains

if table.contains({WEAPON_SWORD, WEAPON_WAND}, target:getType():getWeaponType()) then
    player:sendCancelMessage("You can't use this.")
    return true
end

i was going to suggest this:
think also works, at least on tfs 1.5..

search

---@return boolean
local function isValidObj(item)
    local iType = item:getType()

change to

---@return boolean
local function isValidObj(item)
    local iType = item:getType()
    if iType:isWeapon() then return false end

Post automatically merged: Mar 28, 2023

isWeapon function:

local notWeapons = {WEAPON_NONE, WEAPON_SHIELD, WEAPON_AMMO}
function ItemType:isWeapon()
  return not table.contains(notWeapons, self:getWeaponType())
end

 

[Mahdi10]

Thank you both, is there a better way than the other or all do the same job?
I used this one and added all weapon types except shield and it worked.

if table.contains({WEAPON_SWORD, WEAPON_WAND}, target:getType():getWeaponType()) then
    player:sendCancelMessage("You can't use this.")
    return true
end

 

[VitoxMaster]

Hey,
first of all nice script its very usefull.
I had some problems with the application of the wand damge but I have solved it. Now I have a new problem comming up, the script upgrades each skill perfectly but not the magic level, I am useing the latest TFS 1.4 Version and your newest script.

You can try to define magic level as a custom attribute.

    ["magic level"] = {
        abilitie = {
            type = "stats",
            index = STAT_MAGICPOINTS
        },

        condition = {
            id = CONDITIONID_DEFAULT,
            subId = 1009,
            type = CONDITION_ATTRIBUTES,
            param = CONDITION_PARAM_STAT_MAGICPOINTS,
            ticks = -1
        }
    }

And then set line in doUpgradeItem function:

setCustomAttribute(item, "SarahWesker_magic level" , this.upgrade["magic level"], newLevel)

Tested on TFS 1.5 downgrade to 8.6

 

[jakub742]

Tested on TFS 1.5 nekiro's 772 downgrade works good on weapons but not on wands. I have the callbacks and everything that was mentonied here ORIGIN_WAND etc. But the wand damage is not added.

I also tried it with this: Monster - Training Dummy with DPS calculation (https://otland.net/threads/training-dummy-with-dps-calculation.263659/)

And the DPS message is corresponding to wand base damage + extra damage. But the monk only receive base damage

You see a wand of inferno.
It can only be wielded properly by sorcerers of level 33 or higher.
Item ID: 2187
Position: 43, 260, 7
Extra Attributes (level 5, extra damage +50)

15:41 A training dummy loses 11 hitpoints due to your attack.

Real damage was 11, but reported DPS from script was 61 so i guess it counted the extra damage. Weird

 

[Lemonice]

that table is not for that.

however you can do what you want by modifying this function:

Item upgrade system, with the possibility of improving the damage of wands

Item upgrade system, with the possibility of improving the damage of wands - upgrading_system.lua

gist.github.com

You can also add a check here if you don't want to modify the above function:
View attachment 74451

if target:getType():getWeaponType() ~= WEAPON_NONE then
    player:sendCancelMessage("You can't use this.")
    return true
end

though remember that shields have a weapon type, WEAPON_SHIELD, so you better check each type, or create a table to use table.contains

if table.contains({WEAPON_SWORD, WEAPON_WAND}, target:getType():getWeaponType()) then
    player:sendCancelMessage("You can't use this.")
    return true
end

Thanks

 

[endziu2222]

Small Upgrade System
The upgrade of wands and rods is allowed.

You can add several types of object to use the system, in example code I have configured two objects
per example:
View attachment 63526
Each object has its well defined properties and it is already a matter of you using your imagination
||||||||: Here we have a 100% chance so it will be very easy to improve with this object, however we will give few attributes
||||||||: Here we have a 50% chance so it will be easy to improve with this object, in this case we will give more attributes for the difficulty

per example:
View attachment 63525
||||||||: We only define the variable chance here, this is because it is level 0
||||||||: We only define downLvl and chance here, This is because we can have a degradation or an increase
||||||||: We only define downLvl here, This is because we can have a degradation but not an increase

others:
View attachment 63527
||||||||: If this variable is true, then failed attempts degrade the object
||||||||: If this variable is true, the attempts are infinite

images:
View attachment 63529

File: data/scripts/small_upgrade_system.lua


Don't forget to trigger the following events in the events.xml file

<event class="Creature" method="onTargetCombat" enabled="1" />
...
<event class="Player" method="onItemMoved" enabled="1" />

¿What is this system about?
This is a simple system that updates item attributes.
per example:
Attack from a weapon
The armor of an legs
The abilities of a shield or something else
in general any attribute can be upgradeable

You must bear in mind that not all attributes can be upgrade, but here I will leave a list of the attributes that can be upgrade

attack
defense
extraDefense
armor
wandDamage
elementDamage
fist fighting
club fighting
sword fighting
axe fighting
distance fighting
shielding
fishing
max health
max mana
magic level
reg health
reg mana
speed
critical hit chance
critical extra damage
hitpoints leech chance
hitpoints leech amount
manapoints leech chance
mana points leech amount

Note:
I will try to add more attributes to it in the future.
If you notice any bug you can leave me a comment.
I know there are better systems and with many more details, but I just wanted to share my small version

is it possible to make it work on canary? ots?

 

[archer32]

i am wondering... i really want to use healthgain and managain.. but this only UPGRADES the values if they are already there, how can we use for example "mind stone" on item to GIVE a random bonus, or am i looking at this the wrong way

 

[VitoxMaster]

@archer32
Hi, in my case it was working, I've made upgrade only for backpacks - I could upgrade my backpack from scratch even if it didn't have a basic health/mana gain.

My item which will provide regen.

        [10026] = { -- HP & mana regen
        chance = 100,
        minRequireLvl = 0,
        maxRequireLvl = 10,
        breakWhenFail = false,
        breakLvl = 10,
        effect = CONST_ME_MAGIC_GREEN,
        upgrade = {
            ["reg health"] = 1,
            ["reg mana"] = 1,
        }
    },

Conditions:

    ["reg health"] = {
        abilitie = {
            type = "healthGain"
        },

        condition = {
            id = CONDITIONID_DEFAULT,
            subId = 1010,
            type = CONDITION_REGENERATION,
            param = CONDITION_PARAM_HEALTHGAIN,
            ticks = -1,
            healthTicks = 4000
        }
    },
    ["reg mana"] = {
        abilitie = {
            type = "manaGain"
        },

        condition = {
            id = CONDITIONID_DEFAULT,
            subId = 1011,
            type = CONDITION_REGENERATION,
            param = CONDITION_PARAM_MANAGAIN,
            ticks = -1,
            manaTicks = 4000
        }
    },

Check if item to upgrade is backpack

local function isBackpack(item)
    return item:getType():isBackpack()
end

In function "doUpgradeItem"

if isBackpack(item) then
        setCustomAttribute(item, "SarahWesker_reg health" , this.upgrade["reg health"], objLevel, newLevel, success)
        setCustomAttribute(item, "SarahWesker_reg mana" , this.upgrade["reg mana"], objLevel, newLevel, success)
 end

I've modified setCustomAttribute function, so number of parameters probably won't match yours.