Lua TFS 1.5 lua error

[Akira1992]

Was trying to add this daily chest script in temple for people to take but a bit lost in the 1.5 TFS
Thanks for the help in making me understand what is wrong!

data\scripts\actions\daily_chest.lua:21: attempt to perform arithmetic on a nil value
stack traceback:
        [C]: in metamethod 'sub'

local expItem = Action()

local items = {{2160, 1}}

local function secondsToReadable(s)
    local hours   = math.floor(s / 3600)
    local minutes = math.floor(math.fmod(s, 3600)/60)
    local seconds = math.floor(math.fmod(s, 60))
    return (hours   > 0 and (hours   .. ' hour'   .. (hours   > 1 and 's ' or ' ')) or '') ..
           (minutes > 0 and (minutes .. ' minute' .. (minutes > 1 and 's ' or ' ')) or '') ..
           (seconds > 0 and (seconds .. ' second' .. (seconds > 1 and 's ' or ' ')) or '')
end

function expItem.onUse(player, item, fromPosition, target, toPosition, isHotkey)

    local randomIndex = math.random(1, #items)
    local itemId = items[randomIndex][1]
    local itemCount = items[randomIndex][2]
    local exhaust = 53964

    if player:getStorageValue(exhaust) - os.time() > 0 then
        local timeRemaining = secondsToReadable(player:getStorageValue(exhaust) - os.time())
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: ".. timeRemaining .."")
        return true
    end

    local item = player:addItem(itemId, itemCount)
    player:setStorageValue(exhaust, os.time() + 1)
    --player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You have received "..itemCount.."x "..itemId:getName().."")
    print(item:getName())
    return true
end

expItem:aid(64053)
expItem:register()

 

[sharinn]

as far as i know(probably for 2y) TFS for storage can return value or nil, you must check if getStorageValue return value number or nil

 

[Akira1992]

Thank you for the replies, still learning so just to be clear this, doesn't this entire part check for storage?

if player:getStorageValue(exhaust) - os.time() > 0 then
        local timeRemaining = secondsToReadable(player:getStorageValue(exhaust) - os.time())

I tried adding the line you mentioned above but getting

'then' expected near '='

Thank you for all your help and helping me understand!

 

[Mateus Robeerto]

Just find this part of the code,

if player:getStorageValue(exhaust) - os.time() > 0 then
        local timeRemaining = secondsToReadable(player:getStorageValue(exhaust) - os.time())
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: ".. timeRemaining .."")
        return true
    end

replace it with the new version, and test it. It should work fine.

 local storedTime = player:getStorageValue(exhaust)
    if storedTime ~= -1 and storedTime - os.time() > 0 then
        local timeRemaining = secondsToReadable(storedTime - os.time())
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: " .. timeRemaining)
        return true
    end

 

[Akira1992]

Just find this part of the code,

if player:getStorageValue(exhaust) - os.time() > 0 then
        local timeRemaining = secondsToReadable(player:getStorageValue(exhaust) - os.time())
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: ".. timeRemaining .."")
        return true
    end

replace it with the new version, and test it. It should work fine.

 local storedTime = player:getStorageValue(exhaust)
    if storedTime ~= -1 and storedTime - os.time() > 0 then
        local timeRemaining = secondsToReadable(storedTime - os.time())
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: " .. timeRemaining)
        return true
    end

Thank you for providing me with this code, however this is showing now

\data\scripts\actions\daily_chest.lua:callback
\data\scripts\actions\daily_chest.lua:22: attempt to perform arithmetic on a nil value (local 'storedTime')
stack traceback:
        [C]: in metamethod 'sub'
        \data\scripts\actions\daily_chest.lua:22: in function <\data\scripts\actions\daily_chest.lua:14>

Kind Regards

Post automatically merged: Jun 14, 2025

I have only provided you with pseudocode logic you will have to figure out how operators and or == work first before you start scripting i recommend going into lua tutorials

Programming in Lua : 3.2

if you feel like this is too hard then just try using the local forum tutorials.

I will defo look into it and hopefully learn something useful my friend. Thank you

Post automatically merged: Jun 14, 2025

Also I am using TFS 1.5 by GitHub - MillhioreBT/forgottenserver-downgrade: TFS Downgrade 1.5+ is an engine based on nekiro downgrade but highly updated with current tfs code, it also has the lua modules divided and uses lua5.4 (https://github.com/MillhioreBT/forgottenserver-downgrade/tree/main) so not sure how much different it is compared to Nekiros original 1.5

 

[Error 502]

lua 5.4

Exaust Problem · Issue #19 · MillhioreBT/forgottenserver-downgrade

I'm having problems with Exhaustor in Scripts I want to set time to use x item or use x command and I can't because the base doesn't pull the os.time or something similar. When I put 1 it works fin...

github.com

 

[Akira1992]

local expItem = Action()

local items = {
    {2160, 1}
}

local function secondsToReadable(s)
    local hours   = math.floor(s / 3600)
    local minutes = math.floor(math.fmod(s, 3600) / 60)
    local seconds = math.floor(math.fmod(s, 60))
    return (hours   > 0 and (hours   .. ' hour'   .. (hours   > 1 and 's ' or ' ')) or '') ..
           (minutes > 0 and (minutes .. ' minute' .. (minutes > 1 and 's ' or ' ')) or '') ..
           (seconds > 0 and (seconds .. ' second' .. (seconds > 1 and 's ' or ' ')) or '')
end

function expItem.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    local exhaust = 53964

    local lastUse = player:getStorageValue(exhaust)
    local now = os.time()

    if lastUse ~= -1 and lastUse > now then
        local timeRemaining = secondsToReadable(lastUse - now)
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: " .. timeRemaining)
        return true
    end

    local randomIndex = math.random(1, #items)
    local itemId = items[randomIndex][1]
    local itemCount = items[randomIndex][2]

    local addedItem = player:addItem(itemId, itemCount)
    if addedItem then
        player:setStorageValue(exhaust, math.floor(now + 86400))  -- 24h cooldown
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You have received " .. itemCount .. "x " .. addedItem:getName())
        print(addedItem:getName())
    else
        player:sendTextMessage(MESSAGE_STATUS_WARNING, "Unable to add item to your inventory.")
    end

    return true
end

expItem:aid(64053)
expItem:register()

Lua Script Error: [Scripts Interface]
C:\Users\Desktop\TFS 1.5\data\scripts\actions\others\daily_chest.lua:callback
... Updated\data\scripts\actions\others\daily_chest.lua:22: attempt to compare number with nil
stack traceback:
        [C]: in metamethod 'lt'
        ... Updated\data\scripts\actions\others\daily_chest.lua:22: in function <... Updated\data\scripts\actions\others\daily_chest.lua:16>

Thanks for trying to help

 

[Akira1992]

local lastUse = player:getStorageValue(exhaust) or 0

you can also try.

local lastUse = tonumber(player:getStorageValue(exhaust)) or 0

Tonumber will ensure that even if it returns nil it will return a number most

local rawValue = player:getStorageValue(exhaust)

local lastUse = tonumber(rawValue)



if not lastUse then

    lastUse = 0

end

local rawValue = player:getStorageValue(exhaust)

local lastUse = type(rawValue) == "number" and rawValue or tonumber(rawValue) or 0

try any of those combinations I have not used this engine ( and for good reasons such as this bs)

Thank you I will try this, you think the engine is the issue here? Have been looking at other possibilites such us 0.4 or just the 1.5 Nekiros without any further work as this one seems to use lua 5.4 and others older versions? Just wanted a stable trunk without major issues

Post automatically merged: Jun 14, 2025

local lastUse = player:getStorageValue(exhaust) or 0

you can also try.

local lastUse = tonumber(player:getStorageValue(exhaust)) or 0

Tonumber will ensure that even if it returns nil it will return a number most

local rawValue = player:getStorageValue(exhaust)

local lastUse = tonumber(rawValue)



if not lastUse then

    lastUse = 0

end

local rawValue = player:getStorageValue(exhaust)

local lastUse = type(rawValue) == "number" and rawValue or tonumber(rawValue) or 0

try any of those combinations I have not used this engine ( and for good reasons such as this bs)

local lastUse = player:getStorageValue(exhaust) or 0

This seems to have fixed it and is working without any issues or errors in console.

Appreciate the help also is there a reason why the console prints out the reward name? After pressing on the chest the crystal coin message shows up in the console x

 

[sharinn]

Just find this part of the code,

if player:getStorageValue(exhaust) - os.time() > 0 then
        local timeRemaining = secondsToReadable(player:getStorageValue(exhaust) - os.time())
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: ".. timeRemaining .."")
        return true
    end

replace it with the new version, and test it. It should work fine.

 local storedTime = player:getStorageValue(exhaust)
    if storedTime ~= -1 and storedTime - os.time() > 0 then
        local timeRemaining = secondsToReadable(storedTime - os.time())
        player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You can take your daily reward again in: " .. timeRemaining)
        return true
    end

i will change

local storedTime = player:getStorageValue(exhaust)

to

local storedTime = player:getStorageValue(exhaust) or -1