You'r welcome! That is the attitude that will make you a great developer.
I managed to review the code you posted, and I have a couple of suggestions to make your code even cleaner now.
1. Create reusable code
Your code is over-specialised, specific to magic level, while it could increase any skill with a given argument.
Why not make it
addSkill(SKILL_CRAFTING, true), first argument dictates which skill we increase, and later if we want to keep the current percentage.
2. Use in-built tools
When faced with a block like
LUA:
if pos < 0 then
pos = 0
elseif pos > 1 then
pos = 1
end
You can use math.max and math.min
It's not only cleaner, but does explicitly what you want, "clamps" the value between the arguments.
Unfortunately math.clamp comes in later Lua versions, thus you likely won't be able to use it without additional chores.
3. Use rvalues
In simple words, don't name variables redundantly.
For example, here
LUA:
local reqOld = voc:getRequiredManaSpent(baseMl + 1)
local pos = self:getManaSpent() / reqOld
reqOld is used only once, and the process of creating it as a named variable (lvalue) has some overhead.
After applying 2 and 3, that line should look something like
LUA:
local pos = math.min(1, math.max(0, self:getManaSpent() / voc:getRequiredManaSpent(baseMl + 1))
4. Avoid defensive programming
Although I assume this might be an AI artefact, I will mention it nonetheless.
LUA:
if delta > 0 then
self:addManaSpent(delta)
elseif delta < 0 then
self:removeManaSpent(-delta)
end
Assuming we
addMagicLevelKeepPercent, this function should never reduce your mana spent.
Although it is wise to ensure that we are not passing any negative value to that function, as it casts it to uint, and a negative value here would result in a very big uint (and a lot of mlvl gain
), we should ensure that implicitly, or raise an error when this condition is met.
5. Avoid excessive commenting
That is, I am sure due to AI, as it is a staple of generated code.
What's interesting (another proof that LLMs are not yet smart), that the same generator will run into issues because it reads those comments
Both because the comments will mislead it and because it will bloat its context.
Anyway, code should be
self-documenting, it should read like a book - if it doesn't, you should work on your variable and method names, not add a comment.
Don't confuse that with
docstrings, whose sole purpose is to document something in the code, but comments like
-- mana cost for the current band: ML -> ML + 1
are a bloat, and if the logic is not really correct - simply confusing.
Wall of text, but I hope I didn't bore you at any point
Feel free to ask any questions
![[TFS 1.5] Player function - add magic level keeping progress](/data/resource_icons/0/109.jpg?1763857466){kind=icon}
