Feature [TFS 1.X] All players from your account can enter to your house

[Joe Rod]

Hi again . With this code all the players from your account can enter to your house (they become owners too)

house.h

find

uint32_t owner = 0;

add below

uint32_t ownerAcc = 0;

find:

uint32_t getOwner() const {
    return owner;
}

add below:

void setOwnerAcc(uint32_t accId)
{
    this->ownerAcc = accId;
}
uint32_t getOwnerAcc() const {
    return ownerAcc;
}

house.cpp

find

owner = 0;

add below:

ownerAcc = 0;

find

    if (guid != 0) {
        std::string name = IOLoginData::getNameByGuid(guid);
        if (!name.empty()) {
            owner = guid;
            ownerName = name;

add below:

Database& db1 = Database::getInstance();
std::ostringstream query1;
query1 << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
DBResult_ptr result = db1.storeQuery(query1.str());
ownerAcc = result->getNumber<uint32_t>("account_id");

find

if (player->getGUID() == owner) {
    return HOUSE_OWNER;
}

add this below:

if (player->getAccount() == ownerAcc)
{
    return HOUSE_OWNER;
}

That's all

 

[Acubens]

Nice edit greetings.

 

[Itutorial]

TFS 1.2

Error with this code:

Database& db1 = Database::getInstance();
std::ostringstream query1;
query1 << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
DBResult_ptr result = db1.storeQuery(query1.str());
ownerAcc = result->getNumber<uint32_t>("account_id");

 

[Itutorial]

Anyone know what to do?

 

[Itutorial]

Here is the code for TFS 1.2

std::ostringstream query;
            query << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
            DBResult_ptr result = Database::getInstance()->storeQuery(query.str());
            ownerAcc = result->getNumber<uint32_t>("account_id");

 

[Mr Erimyth]

Here is the code for TFS 1.2

std::ostringstream query;
            query << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
            DBResult_ptr result = Database::getInstance()->storeQuery(query.str());
            ownerAcc = result->getNumber<uint32_t>("account_id");

Thxx here work ....

 

[Zombiegod]

everytime i add the datavase code into the editor i get this error TFS 1.2 (technically 1.3)

Severity    Code    Description    Project    File    Line    Suppression State
Error (active)    E0461    initial value of reference to non-const must be an lvalue    theforgottenserver    G:\Tibia\forgottenserver-1.2\forgottenserver-1.2\src\house.cpp    100

 

[Evil Puncker]

Here is the code for TFS 1.2

std::ostringstream query;
            query << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
            DBResult_ptr result = Database::getInstance()->storeQuery(query.str());
            ownerAcc = result->getNumber<uint32_t>("account_id");

@Zombiegod are you using this? (and no, 1.2 is not 1.3, they are quite different)

 

[Zombiegod]

@Zombiegod are you using this? (and no, 1.2 is not 1.3, they are quite different)

Both give the same error(yea folder says 1.2 but following guides and stuff, turns out i have 1.3)

Post automatically merged: Mar 6, 2020

found the issue

change

Database& db1 = Database::getInstance();

too

Database* db1 = Database::getInstance();

Edited to correct the solution

 

[Infernum]

Both give the same error(yea folder says 1.2 but following guides and stuff, turns out i have 1.3)

Post automatically merged: Mar 6, 2020

found the issue

change

Database& db1 = Database::getInstance();

too

Database & db1 = Database::getInstance();

There is absolutely no way that fixes the problem, the two are compiled to the exact same instructions, any spaces after the first don't affect anything.

int a = 0;
int& b = a;
int & c = a; // the exact same

 

[Zombiegod]

all i know is visual studios complained with that error and said

Severity    Code    Description    Project    File    Line    Suppression State
Error    C2440    'initializing': cannot convert from 'Database *' to 'Database &'    theforgottenserver    G:\Tibia\forgottenserver-1.2\forgottenserver-1.2\src\house.cpp    100

when i accidentally pressed build, changing it to "database &" got rid of the previous error.

Turns out that failed to compile, but exanging & for * allowed it too for some reason, i do not know i am not a coder.

 

[StreamSide]

oh but thats different

 

[Zombiegod]

Well i just tested, and even though it spit out a complaint while compiling (still compiled) it seems to be working without flaw.

 

[Zombiegod]

figured i would update the code i told. If you are using the source.zip from releases section on github.

change

Database& db1 = Database::getInstance();
std::ostringstream query1;
query1 << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
DBResult_ptr result = db1.storeQuery(query1.str());
ownerAcc = result->getNumber<uint32_t>("account_id");

to

Database* db1 = Database::getInstance();
std::ostringstream query1;
query1 << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
DBResult_ptr result = db1->storeQuery(query1.str());
ownerAcc = result->getNumber<uint32_t>("account_id");

 

[ralke]

thanks for sharing, no errors on compiling tfs 1.3

 

[Evil Puncker]

thanks for sharing, no errors on compiling tfs 1.3

btw if you are using latest tfs it is already included by default:

config: houseOwnedByAccount (#2935) · otland/forgottenserver@20f50a0

This enables or disables the possibility that characters from the same account automatically become "owners" and have full access to the house.

github.com

 

[Itutorial]

for TFS 1.3+

Follow everything but on the database part use this

std::ostringstream query;
            Database& db = Database::getInstance();
            query << "SELECT `account_id` FROM `players` WHERE `id` = " << guid;
            DBResult_ptr result = db.storeQuery(query.str());
            ownerAcc = result->getNumber<uint32_t>("account_id");

welp