[TFS 1.x] Talkaction to enable/disable loot message.

Peonso · Oct 27, 2015

I'm in need of a talkaction to enable/disable loot message [TFS 1.x]. I'm no C++ magician, and I believe it's impossible to do without editing sources, since the event is not in any lua file. Any ideas? Relevant:
https://github.com/otland/forgottenserver/blob/master/src/monsters.cpp#L146

Printer · Oct 27, 2015

You are on the right line, you can do it with storage:

Code:

int32_t value;
if (owner && (owner->getStorageValue(1000, value) && value == 1)) {

Code:

function onSay(player, words, param)
    if player:getStorageValue(1000) == 1 then
        player:setStorageValue(1000, 0)
        player:sendTextMessage(MESSAGE_INFO_DESCR, "Loot message has been disabled.")
    else
        player:setStorageValue(1000, 1)
        player:sendTextMessage(MESSAGE_INFO_DESCR, "Loot message has been enabled.")
    end

    return false
end

Peonso · Nov 3, 2015

Printer said:

You are on the right line, you can do it with storage:

Code:

int32_t value;
if (owner && (player->getStorageValue(1000, value) && value > 1)) {

Code:

function onSay(player, words, param)
    if player:getStorageValue(1000) == 1 then
        player:setStorageValue(1000, 0)
        player:sendTextMessage(MESSAGE_INFO_DESCR, "Loot message has been disabled.")
    else
        player:setStorageValue(1000, 1)
        player:sendTextMessage(MESSAGE_INFO_DESCR, "Loot message has been enabled.")
    end
 
    return false
end

Please HELP!!!

Code:

/home/otsmanager/forgottenserver/forgottenserver-8d4745e6fcd3caf69cc5c941869fe5c2b27c903f/src/monsters.cpp: In member function ‘void MonsterType::createLoot(Container*)’:
/home/otsmanager/forgottenserver/forgottenserver-8d4745e6fcd3caf69cc5c941869fe5c2b27c903f/src/monsters.cpp:165:17: error: ‘player’ was not declared in this scope
  if (owner && (player->getStorageValue(30016, value) && value > 1)) {
  ^
make[2]: *** [CMakeFiles/tfs.dir/src/monsters.cpp.o] Error 1
make[1]: *** [CMakeFiles/tfs.dir/all] Error 2
make: *** [all] Error 2
root@46-105-246-41:/home/otsmanager/forgottenserver/forgottenserver-8d4745e6fcd3caf69cc5c941869fe5c2b27c903f/build#

Codex NG · Nov 3, 2015

Peonso said:

Please HELP!!!

Code:

/home/otsmanager/forgottenserver/forgottenserver-8d4745e6fcd3caf69cc5c941869fe5c2b27c903f/src/monsters.cpp: In member function ‘void MonsterType::createLoot(Container*)’:
/home/otsmanager/forgottenserver/forgottenserver-8d4745e6fcd3caf69cc5c941869fe5c2b27c903f/src/monsters.cpp:165:17: error: ‘player’ was not declared in this scope
  if (owner && (player->getStorageValue(30016, value) && value > 1)) {
  ^
make[2]: *** [CMakeFiles/tfs.dir/src/monsters.cpp.o] Error 1
make[1]: *** [CMakeFiles/tfs.dir/all] Error 2
make: *** [all] Error 2
root@46-105-246-41:/home/otsmanager/forgottenserver/forgottenserver-8d4745e6fcd3caf69cc5c941869fe5c2b27c903f/build#

Rather than saying "Please HELP!!!" tell us what the problem is, errors can only tell you soo much, what were you trying to accomplish?

Printer · Nov 3, 2015

Ups, recopy c++ Code.

Peonso · Nov 3, 2015

Codex NG said:
Rather than saying "Please HELP!!!" tell us what the problem is, errors can only tell you soo much, what were you trying to accomplish?

Well, the short posts above tell it all. @Printer edited it now, I gonna test. Thx anyway.

viking · Nov 3, 2015

Peonso said:
Well, the short posts above tell it all. @Printer edited it now, I gonna test. Thx anyway.

This "Codex NG" only come to threads for flooding ever. Zzz I was think only for me, but is for all

Danger II · Nov 3, 2015

viking said:
This "Codex NG" only come to threads for flooding ever. Zzz I was think only for me, but is for all

If people can not fix "not declared"-errors, they shouldn't touch sources at all.

viking · Nov 3, 2015

Danger II said:
If people can not fix "not declared"-errors, they shouldn't touch sources at all.

what does this have to do with what I said?

Danger II · Nov 3, 2015

viking said:
what does this have to do with what I said?

He is flooding because people cannot even clean their ass alone.

viking · Nov 3, 2015

Danger II said:
He is flooding because people cannot even clean their ass alone.

And what you have to do with it ? You can not take care of your ass alone without flooding too?

Codex NG · Nov 3, 2015

viking said:
This "Codex NG" only come to threads for flooding ever. Zzz I was think only for me, but is for all

I guess what you are trying to say in your broken english, If i post something in a thread i am not helpful at all.. if this is the case then don't read anything I post & you won't feel that way.

viking · Nov 3, 2015

Codex NG said:
I guess what you are trying to say in your broken english, If i post something in a thread i am not helpful at all.. if this is the case then don't read anything I post & you won't feel that way.

1 AT LEAST I KNOW HOW TO SPEAK OTHER LANGUAGES, EXCEPT THE MINE.
2 SURE, JUST DONT POST ANYTHING IN MY THREADS, THANKS.

Codex NG · Nov 3, 2015

viking said:
1 AT LEAST I KNOW HOW TO SPEAK OTHER LANGUAGES, EXCEPT THE MINE.
2 SURE, JUST DONT POST ANYTHING IN MY THREADS, THANKS.

But you can't program, script, compile, form a complete sentence or follow simple instructions for shit.. yea I soo wanna be you.

Danger II · Nov 3, 2015

viking said:
1 AT LEAST I KNOW HOW TO SPEAK OTHER LANGUAGES, EXCEPT THE MINE.
2 SURE, JUST DONT POST ANYTHING IN MY THREADS, THANKS.

1. I think this is the first sentence you wrote that is real english, everything else your posting is just terrible to read. That might be a reason why people cannot help you.
2. As I can see this thread is not yours, Peonso did open this thread.

viking · Nov 3, 2015

Codex NG said:
But you can't program, script, compile, form a complete sentence or follow simple instructions for shit.. yea I soo wanna be you.

I do not know programming but have money to have my car, my house and buy programs/scripts (and i know compile lol), one thing that you do not spend anywhere near . Patetic life, thanks

Codex NG · Nov 3, 2015

viking said:
I do not know programming but have money to have my car, my house and buy programs/scripts (and i know compile lol), one thing that you do not spend anywhere near . Patetic life, thanks

I am not the one on here 24/7 begging for help with my server..
Out of all my posts I've asked 1 question and @Printer answered it
If my life is pathetic what does that make yours?

Nekiro · Nov 3, 2015

Guys please. Stop this childish play. Calm down, hit the high five and go on!

Peonso · Nov 13, 2015

I did got some weird behavior, when in a party people would get loot messages based on the killer storage value only. Change it that way:

https://github.com/otland/forgotten...cc5c941869fe5c2b27c903f/src/monsters.cpp#L164

Code:

    if (owner) {
       std::ostringstream ss;
       ss << "Loot of " << nameDescription << ": " << corpse->getContentDescription();

       if (owner->getParty()) {
         owner->getParty()->broadcastPartyLoot(ss.str());
       } else {
int32_t value;
         if (owner->getStorageValue(1000, value) && value == 1) {
           owner->sendTextMessage(MESSAGE_INFO_DESCR, ss.str());
         }
       }
     }

https://github.com/otland/forgotten...f69cc5c941869fe5c2b27c903f/src/party.cpp#L348

Code:

    void Party::broadcastPartyLoot(const std::string& loot)
     {
int32_t value;
       if (leader->getStorageValue(1000, value) && value == 1) {
         leader->sendTextMessage(MESSAGE_INFO_DESCR, loot);
       }
       for (Player* member : memberList) {
         if (member->getStorageValue(1000, value) && value == 1) {
           member->sendTextMessage(MESSAGE_INFO_DESCR, loot);
         }
       }
     }

@Printer

[TFS 1.x] Talkaction to enable/disable loot message.

Peonso

Godly Member

Printer

if Printer then print("LUA") end

Peonso

Godly Member

Codex NG

Recurrent Flamer

Printer

if Printer then print("LUA") end

Peonso

Godly Member

viking

Member

Danger II

tibiara.com

viking

Member

Danger II

tibiara.com

viking

Member

Codex NG

Recurrent Flamer

viking

Member

Codex NG

Recurrent Flamer

Danger II

tibiara.com

viking

Member

Codex NG

Recurrent Flamer

Nekiro

Legendary OT User

Peonso

Godly Member

Similar threads