Trying to change Protocol Login from lua into C++ file

[darkshin]

DEVELOPMENT SO FAR:
https://gist.github.com/DarkShinz/5ffbc9e72519366f5537 (without compiler errors)

BUGS SO FAR:
Something related to the removal of the protocolLogin.lua file of the modules affected some

other structures. I think it's related to a connection sutff or something, because some

modules cannot call functions that aren't removed and are related with the other protocols.

A print:

Hello Guys!!!

I'm trying to change the protocollogin.lua, located at the modules lib, into a C++ file, within the sourcers. For me, I prefer this way because I sucks at lua.
So far I've found some differences, like some functions that aren't within the sourcers and I can't find them at module libs. Like: " onOpcode "; " onMotd "; " onSessionKey ";
Someone knows where I can find those functions?

Also, I have no idea if it will workout after is done.
Does someone tried it before? And most important, why it was made in lua instead of C++, like it's in the server's file?

Are you ppl interested in this ?

 

[Summ]

Those "functions" are just callbacks which are called when a specific event happens, just like ProtocolGame has ProtocolGame:: onConnect, ProtocolGame:: onError.
There is no reason not to do it in lua.

 

[darkshin]

Those "functions" are just callbacks which are called when a specific event happens, just like ProtocolGame has ProtocolGame:: onConnect, ProtocolGame:: onError.
There is no reason not to do it in lua.

Yes, but these callbacks are used at lua to call a C++ function, example:

signalcall(self.onLoginError, self, errorMessage)

This event refers to the:

void Game::processLoginError(const std::string& error)
{  g_lua.callGlobalField("g_game", "onLoginError", error); }

Thing is...

I can't find anything that the " onOpcode "; " onMotd "; " onSessionKey "; are refering to. Do they do anything or are just empty callbacks?

 

[Summ]

Which function is

signalcall(self.onLoginError, self, errorMessage)

calling?

 

[darkshin]

Which function is

signalcall(self.onLoginError, self, errorMessage)

calling?

This one (I believe):

void Game::processLoginError(const std::string& error)
{ 

g_lua.callGlobalField("g_game", "onLoginError", error);

}

 

[Summ]

processLoginError != onLoginError

It calls the onLoginError field of ProtocolLogin which is defined in this file:
https://github.com/edubart/otclient...f2c45e/modules/client_entergame/entergame.lua

 

[darkshin]

processLoginError != onLoginError

It calls the onLoginError field of ProtocolLogin which is defined in this file:
https://github.com/edubart/otclient...f2c45e/modules/client_entergame/entergame.lua

Oh Thank you! That is what I was looking for!

 

[darkshin]

@Summ Do you know if "std::to_string" at the following code, could replace "iptostring"?

character.worldIp = std::to_string(msg->getU32()); //iptostring

Also, do you know if I have to create a function or there's something already set up to replace "getTable()" from the following code:

int8_t characters = msg->getTable();

 

[Summ]

1) Just use the C++ function which iptostring calls => stdext::ip_to_string
2) extendedCharacterList is not used by the default protocol, but InputMessage.getTable is declared at https://github.com/edubart/otclient...c45e/modules/corelib/inputmessage.lua#L25-L34

 

[darkshin]

1) Just use the C++ function which iptostring calls => stdext::ip_to_string
2) extendedCharacterList is not used by the default protocol, but InputMessage.getTable is declared at https://github.com/edubart/otclient...c45e/modules/corelib/inputmessage.lua#L25-L34

Thanks!
So, If I want a "getTable()" at C++ I will have to make one XD

I've solved what I asked here. So I edited.

 

[darkshin]

I think I've worked the sources out... now need to fix modules errors