Vocation bug/Suggestion

[Jgarder]

---------Bug#1---------
Title = Dissappearing promotion!
Problem with = its a automatic system in game.cpp that has no ability to be turned off!
Description = any character must be premium to be promoted.
Other information = i have commented the automatic system and everything works fine
Suggestions = This fix i want is included Just 2 boxes down from here in the vocations.xml
----------------------------------------------------------------

//		if(player->isPremium())
//		{
//			uint64_t value;
//			player->getStorageValue(30018, value);
//			if(player->isPromoted() && value != 1)
//				player->addStorageValue(30018, 1);
//			else if(!player->isPromoted() && value == 1)
//				player->setVocation(g_vocations.getPromotedVocation(player->getVocationId()));
//		}
//		else if(player->isPromoted())
//			player->setVocation(player->vocation->getFromVocation());

PLEASE LOOK AT THE FOLLOWING CHANGE PLEASE TALATUREN!

<vocation id="5" name="Master Sorcerer" description="a master sorcerer" gaincap="15" gainhp="10" gainmana="40" gainhpticks="4" gainhpamount="60" gainmanaticks="2" gainmanaamount="120" manamultiplier="1.1" attackspeed="600" 
soulmax="200" gainsoulticks="15" fromvoc="1" [color=red]premium="0"[/color]>
		<formula meleeDamage="1.0" magicDamage="1.0" distDamage="1.0" defense="2.0" armor="1.0"/>
		<skill id="0" multiplier="1.5"/>
		<skill id="1" multiplier="2.0"/>
		<skill id="2" multiplier="2.0"/>
		<skill id="3" multiplier="2.0"/>
		<skill id="4" multiplier="2.0"/>
		<skill id="5" multiplier="1.5"/>
		<skill id="6" multiplier="1.1"/>

	</vocation>

 

[Mokerhamer]

why make it only in vocations why not in config.lua??


---If the player has no premium days left, does his promotion disapear?

promotion = "Yes" or no ofcourse

 

[Jgarder]

my point still remains! just mine is more customizable to your needs! great idea though