what is wrong with this

[Doggynub]

function onCombat(cid, target)
   
    if getPlayerStorageValue(cid,2345) == 2 and getPlayerStorageValue(target,2345) == 2 then 
        doCreatureSay(cid,"You cannot attack players which pvp mode is off.", TALKTYPE_ORANGE_1)
    else
	  return true
    end

end

it works fine no errors but when i relog server close any idea why?>

 

[zieworski denero]

try replacing return true with false

dunno if it would work then

 

[Doggynub]

still....

 

[Summ]

I don't really understand what is wrong with the script. Can you explain?

try?

  function onCombat(cid, target)
   
    if getPlayerStorageValue(cid,2345) == 2 and getPlayerStorageValue(target,2345) == 2 then
        doCreatureSay(cid,"You cannot attack players which pvp mode is off.", TALKTYPE_ORANGE_1)
        return false
    end
return true
end

 

[Doggynub]

with yours every thing messed no one can attack any
but thx for try i fixed it.It has some troubles with return in my server.

 

[Fallen]

function onCombat(cid, target)
	if getPlayerStorageValue(cid, 2345) == 2 and getPlayerStorageValue(target, 2345) == 2 then
		doCreatureSay(cid, "You cannot attack players which pvp mode is off.", 19)
		return false
	end
	return true
end

 

[Cykotitan]

function onCombat(cid, target)
	if getPlayerStorageValue(cid, 2345) == 2 and getPlayerStorageValue(target, 2345) == 2 then
		return doCreatureSay(cid, "You cannot attack players which pvp mode is off.", 19)
	end
	return true
end

doCreatureSay returns true, ffs

 

[Fallen]

doCreatureSay returns true, ffs

,,l,,

 

[Cykotitan]

,,l,,

.

 

[Doggynub]

thx.