TFS 0.X Wrong sex at character creation

[Sanzenkai]

Hi, when i create a character and select Male it always come as a female, please help me..

Shinobi (Male) = 1
Kunoichi (Female) = 0

Znote ACC
OTX2 8.6

As you can see on the images down there, i create the character as male (1) and its 0 on the database (and the game), i already tested on the game to see if people with sex 1 is male, and it is all good, just this little part when i create the character is bugged.

 

[Danger II]

The POST value (selected_gender) seems to be a string which will return as 0 when parsing into database.
Znote is validating it's value here:

ZnoteAAC/createcharacter.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

You can see that he's converting POST value into an integer to validate it's input (either 0 or 1)

What you could do here is trying to changing this line:

https://github.com/Znote/ZnoteAAC/blob/master/createcharacter.php#L96

'sex'        =>    $_POST['selected_gender'],

to:

'sex'        =>    (int) $_POST['selected_gender'],

I rather would change this instead:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

            'sex' => $character_data['sex'],

to:

            'sex' => (int) $character_data['sex'],

This will convert your passed value (former string) into an integer.
Both ways will probably work but doing it directly in the main function is the cleaner way.

 

[Sanzenkai]

The POST value (selected_gender) seems to be a string which will return as 0 when parsing into database.
Znote is validating it's value here:

ZnoteAAC/createcharacter.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

You can see that he's converting POST value into an integer to validate it's input (either 0 or 1)

What you could do here is trying to changing this line:

https://github.com/Znote/ZnoteAAC/blob/master/createcharacter.php#L96

'sex'        =>    $_POST['selected_gender'],

to:

'sex'        =>    (int) $_POST['selected_gender'],

I rather would change this instead:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

            'sex' => $character_data['sex'],

to:

            'sex' => (int) $character_data['sex'],

This will convert your passed value (former string) into an integer.
Both ways will probably work but doing it directly in the main function is the cleaner way.

Neither of them do the job.. i attach the files you mentioned can you see if i did something wrong please?

 

[Danger II]

Neither of them do the job.. i attach the files you mentioned can you see if i did something wrong please?

You changed both files instead of one of them which is not bad but not necessary.
Try this, add below this:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

    $sex = (int)$character_data['sex'];

And change:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

to:

            'sex' => $sex,

Add:

            'sex' => $sex,

Below:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

I have attached the changed files

 

[Sanzenkai]

You changed both files instead of one of them which is not bad but not necessary.
Try this, add below this:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

    $sex = (int)$character_data['sex'];

And change:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

to:

            'sex' => $sex,

Add:

            'sex' => $sex,

Below:

ZnoteAAC/engine/function/users.php at master · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC

github.com

I have attached the changed files

It worked, thanks.

Post automatically merged: Sep 26, 2023

Since we are here, can you help me with something else? on my shop if you do F5 he buy the same item again.. And another problem is that sometimes he just buy the same item even if you clicked on a diferent one. There is a way to fix those problems?

Post automatically merged: Sep 26, 2023

@Danger II