xml attribute problem

[Zuxus]

I was wondering if it existed a increaseMagicPercent attribute on tfs, but I didn't find any, so is it possible to add:

This is what I found in another items.cpp:

#ifdef __ROGIER_WEAPONMOD__
	attackSpeedIncreasePercent = 0;
	attackBonus = 0;
	defenseBonus = 0;
	increaseMagicPercent = 0;
#endif

#ifdef __ROGIER_WEAPONMOD__ 
 							else if(strcasecmp(strValue.c_str(), "increasePhysicalPercent") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.increasePhysicalPercent = std::max(0, intValue);
 								}
 							}                            
 							else if(strcasecmp(strValue.c_str(), "increaseMagicPercent") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.increaseMagicPercent = std::max(0, intValue);
 								}
 							}
 							else if(strcasecmp(strValue.c_str(), "attackSpeedIncreasePercent") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.attackSpeedIncreasePercent = intValue;
 								}
 							}
 							else if(strcasecmp(strValue.c_str(), "attackBonus") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.attackBonus = intValue;
 								}
 							}
 							else if(strcasecmp(strValue.c_str(), "defenseBonus") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.defenseBonus = intValue;
 								}
 							}
#endif

in to tfs source somewhere?

Any suggestions?

 

[Zuxus]

bump

 

[artofwork]

I was wondering if it existed a increaseMagicPercent attribute on tfs, but I didn't find any, so is it possible to add:

This is what I found in another items.cpp:

#ifdef __ROGIER_WEAPONMOD__
	attackSpeedIncreasePercent = 0;
	attackBonus = 0;
	defenseBonus = 0;
	increaseMagicPercent = 0;
#endif

#ifdef __ROGIER_WEAPONMOD__ 
 							else if(strcasecmp(strValue.c_str(), "increasePhysicalPercent") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.increasePhysicalPercent = std::max(0, intValue);
 								}
 							}                            
 							else if(strcasecmp(strValue.c_str(), "increaseMagicPercent") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.increaseMagicPercent = std::max(0, intValue);
 								}
 							}
 							else if(strcasecmp(strValue.c_str(), "attackSpeedIncreasePercent") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.attackSpeedIncreasePercent = intValue;
 								}
 							}
 							else if(strcasecmp(strValue.c_str(), "attackBonus") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.attackBonus = intValue;
 								}
 							}
 							else if(strcasecmp(strValue.c_str(), "defenseBonus") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.defenseBonus = intValue;
 								}
 							}
#endif

in to tfs source somewhere?

Any suggestions?

Not sure if there is code anywhere but combining old attributes to create new ones is childs play
You don't need to create any addtional code or an #ifdef and #endif

Adding additional attributes is as simple as copy and paste
Also since your dealing primarily with integer values these attributes can be easily assigned to one another without any conflicts or divide by 0 errors.

else if(strcasecmp(strValue.c_str(), "badass") == 0)
 							{
 								if(readXMLInteger(itemAttributesNode, "value", intValue)) {
 									it.attackBonus += intValue;
									it.defenseBonus += intValue;
									it.attackSpeedIncreasePercent += intValue;
									it.increaseMagicPercent += std::max(0, intValue);
									it.increasePhysicalPercent += std::max(0, intValue);
 								}
									
 								}
 							}

 

[Zuxus]

What do you mean? Just copy and past on the bottom? A little guidance, kinda new to c++.

 

[exique]

Yes copy, and paste :O

 

[Zuxus]

That's weird, when I try to compile even without editing I get an error from actions.o?? Suggestions? It also says you have to compile with atleast one database driver?? I am using this tutorial: http://otland.net/f137/tutorial-how-compile-forgotten-server-latest-sources-166/.
Using windows btw.

 

[Cykotitan]

Yes copy, and paste :O

aff drim u dunno how 2 compile >,> <,<